* [PATCH] igb: Fix format with line continuation whitespace
@ 2018-11-01 7:03 Joe Perches
2018-11-15 0:17 ` Brown, Aaron F
2018-11-15 1:04 ` Vinicius Costa Gomes
0 siblings, 2 replies; 3+ messages in thread
From: Joe Perches @ 2018-11-01 7:03 UTC (permalink / raw)
To: Jeff Kirsher; +Cc: David S. Miller, intel-wired-lan, netdev, linux-kernel
The line continuation unintentionally adds whitespace so
instead use a coalesced format to remove the whitespace.
Miscellanea:
o Use a more typical style for ternaries and arguments
for this logging message
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/ethernet/intel/igb/igb_main.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 5df88ad8ac81..3a3410f03d04 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -1850,13 +1850,12 @@ static void igb_config_tx_modes(struct igb_adapter *adapter, int queue)
* configuration' in respect to these parameters.
*/
- netdev_dbg(netdev, "Qav Tx mode: cbs %s, launchtime %s, queue %d \
- idleslope %d sendslope %d hiCredit %d \
- locredit %d\n",
- (ring->cbs_enable) ? "enabled" : "disabled",
- (ring->launchtime_enable) ? "enabled" : "disabled", queue,
- ring->idleslope, ring->sendslope, ring->hicredit,
- ring->locredit);
+ netdev_dbg(netdev, "Qav Tx mode: cbs %s, launchtime %s, queue %d idleslope %d sendslope %d hiCredit %d locredit %d\n",
+ ring->cbs_enable ? "enabled" : "disabled",
+ ring->launchtime_enable ? "enabled" : "disabled",
+ queue,
+ ring->idleslope, ring->sendslope,
+ ring->hicredit, ring->locredit);
}
static int igb_save_txtime_params(struct igb_adapter *adapter, int queue,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] igb: Fix format with line continuation whitespace
2018-11-01 7:03 [PATCH] igb: Fix format with line continuation whitespace Joe Perches
@ 2018-11-15 0:17 ` Brown, Aaron F
2018-11-15 1:04 ` Vinicius Costa Gomes
1 sibling, 0 replies; 3+ messages in thread
From: Brown, Aaron F @ 2018-11-15 0:17 UTC (permalink / raw)
To: Joe Perches, Kirsher, Jeffrey T
Cc: David S. Miller, intel-wired-lan, netdev, linux-kernel
> From: netdev-owner@vger.kernel.org [mailto:netdev-
> owner@vger.kernel.org] On Behalf Of Joe Perches
> Sent: Thursday, November 1, 2018 12:04 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
> Cc: David S. Miller <davem@davemloft.net>; intel-wired-
> lan@lists.osuosl.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] igb: Fix format with line continuation whitespace
>
> The line continuation unintentionally adds whitespace so
> instead use a coalesced format to remove the whitespace.
>
> Miscellanea:
>
> o Use a more typical style for ternaries and arguments
> for this logging message
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] igb: Fix format with line continuation whitespace
2018-11-01 7:03 [PATCH] igb: Fix format with line continuation whitespace Joe Perches
2018-11-15 0:17 ` Brown, Aaron F
@ 2018-11-15 1:04 ` Vinicius Costa Gomes
1 sibling, 0 replies; 3+ messages in thread
From: Vinicius Costa Gomes @ 2018-11-15 1:04 UTC (permalink / raw)
To: Joe Perches, Jeff Kirsher
Cc: David S. Miller, intel-wired-lan, netdev, linux-kernel
Joe Perches <joe@perches.com> writes:
> The line continuation unintentionally adds whitespace so
> instead use a coalesced format to remove the whitespace.
>
> Miscellanea:
>
> o Use a more typical style for ternaries and arguments
> for this logging message
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cheers,
--
Vinicius
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-15 1:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-01 7:03 [PATCH] igb: Fix format with line continuation whitespace Joe Perches
2018-11-15 0:17 ` Brown, Aaron F
2018-11-15 1:04 ` Vinicius Costa Gomes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).