* [PATCH -next] net: pcs: pcs-xpcs: Fix build error when CONFIG_PCS_XPCS=y && CONFIG_PHYLINK=m
@ 2022-06-21 13:12 Zheng Bin
2022-06-21 13:29 ` Russell King (Oracle)
2022-06-21 13:34 ` Paolo Abeni
0 siblings, 2 replies; 3+ messages in thread
From: Zheng Bin @ 2022-06-21 13:12 UTC (permalink / raw)
To: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni,
boon.leong.ong, rmk+kernel, netdev, linux-kernel
Cc: zhengbin13, gaochao49
If CONFIG_PCS_XPCS=y, CONFIG_PHYLINK=m, bulding fails:
drivers/net/pcs/pcs-xpcs.o: in function `xpcs_do_config':
pcs-xpcs.c:(.text+0x64f): undefined reference to `phylink_mii_c22_pcs_encode_advertisement'
drivers/net/pcs/pcs-xpcs.o: in function `xpcs_get_state':
pcs-xpcs.c:(.text+0x10f8): undefined reference to `phylink_mii_c22_pcs_decode_state
Make PCS_XPCS depends on PHYLINK to fix this.
Fixes: b47aec885bcd ("net: pcs: xpcs: add CL37 1000BASE-X AN support")
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/net/pcs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/pcs/Kconfig b/drivers/net/pcs/Kconfig
index 22ba7b0b476d..faec931b1e65 100644
--- a/drivers/net/pcs/Kconfig
+++ b/drivers/net/pcs/Kconfig
@@ -8,6 +8,7 @@ menu "PCS device drivers"
config PCS_XPCS
tristate "Synopsys DesignWare XPCS controller"
depends on MDIO_DEVICE && MDIO_BUS
+ depends on PHYLINK
help
This module provides helper functions for Synopsys DesignWare XPCS
controllers.
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] net: pcs: pcs-xpcs: Fix build error when CONFIG_PCS_XPCS=y && CONFIG_PHYLINK=m
2022-06-21 13:12 [PATCH -next] net: pcs: pcs-xpcs: Fix build error when CONFIG_PCS_XPCS=y && CONFIG_PHYLINK=m Zheng Bin
@ 2022-06-21 13:29 ` Russell King (Oracle)
2022-06-21 13:34 ` Paolo Abeni
1 sibling, 0 replies; 3+ messages in thread
From: Russell King (Oracle) @ 2022-06-21 13:29 UTC (permalink / raw)
To: Zheng Bin
Cc: andrew, hkallweit1, davem, edumazet, kuba, pabeni,
boon.leong.ong, netdev, linux-kernel, gaochao49
On Tue, Jun 21, 2022 at 09:12:51PM +0800, Zheng Bin wrote:
> If CONFIG_PCS_XPCS=y, CONFIG_PHYLINK=m, bulding fails:
>
> drivers/net/pcs/pcs-xpcs.o: in function `xpcs_do_config':
> pcs-xpcs.c:(.text+0x64f): undefined reference to `phylink_mii_c22_pcs_encode_advertisement'
> drivers/net/pcs/pcs-xpcs.o: in function `xpcs_get_state':
> pcs-xpcs.c:(.text+0x10f8): undefined reference to `phylink_mii_c22_pcs_decode_state
>
> Make PCS_XPCS depends on PHYLINK to fix this.
>
> Fixes: b47aec885bcd ("net: pcs: xpcs: add CL37 1000BASE-X AN support")
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
Paolo Abeni has already sent a patch, which I think is addressing a
similar issue. Please see:
https://lore.kernel.org/r/6959a6a51582e8bc2343824d0cee56f1db246e23.1655797997.git.pabeni@redhat.com
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] net: pcs: pcs-xpcs: Fix build error when CONFIG_PCS_XPCS=y && CONFIG_PHYLINK=m
2022-06-21 13:12 [PATCH -next] net: pcs: pcs-xpcs: Fix build error when CONFIG_PCS_XPCS=y && CONFIG_PHYLINK=m Zheng Bin
2022-06-21 13:29 ` Russell King (Oracle)
@ 2022-06-21 13:34 ` Paolo Abeni
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Abeni @ 2022-06-21 13:34 UTC (permalink / raw)
To: Zheng Bin, andrew, hkallweit1, linux, davem, edumazet, kuba,
boon.leong.ong, rmk+kernel, netdev, linux-kernel
Cc: gaochao49
Hello,
On Tue, 2022-06-21 at 21:12 +0800, Zheng Bin wrote:
> If CONFIG_PCS_XPCS=y, CONFIG_PHYLINK=m, bulding fails:
>
> drivers/net/pcs/pcs-xpcs.o: in function `xpcs_do_config':
> pcs-xpcs.c:(.text+0x64f): undefined reference to `phylink_mii_c22_pcs_encode_advertisement'
> drivers/net/pcs/pcs-xpcs.o: in function `xpcs_get_state':
> pcs-xpcs.c:(.text+0x10f8): undefined reference to `phylink_mii_c22_pcs_decode_state
>
> Make PCS_XPCS depends on PHYLINK to fix this.
>
> Fixes: b47aec885bcd ("net: pcs: xpcs: add CL37 1000BASE-X AN support")
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---
> drivers/net/pcs/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/pcs/Kconfig b/drivers/net/pcs/Kconfig
> index 22ba7b0b476d..faec931b1e65 100644
> --- a/drivers/net/pcs/Kconfig
> +++ b/drivers/net/pcs/Kconfig
> @@ -8,6 +8,7 @@ menu "PCS device drivers"
> config PCS_XPCS
> tristate "Synopsys DesignWare XPCS controller"
> depends on MDIO_DEVICE && MDIO_BUS
> + depends on PHYLINK
> help
> This module provides helper functions for Synopsys DesignWare XPCS
> controllers.
> --
> 2.31.1
Thank you for the patch. There is already a similar fix pending:
https://patchwork.kernel.org/project/netdevbpf/patch/6959a6a51582e8bc2343824d0cee56f1db246e23.1655797997.git.pabeni@redhat.com/
Cheers,
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-21 13:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-21 13:12 [PATCH -next] net: pcs: pcs-xpcs: Fix build error when CONFIG_PCS_XPCS=y && CONFIG_PHYLINK=m Zheng Bin
2022-06-21 13:29 ` Russell King (Oracle)
2022-06-21 13:34 ` Paolo Abeni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).