* [PATCH] staging: r8188eu: os_dep: simplifiy the rtw_resume function
@ 2021-09-04 9:39 Saurav Girepunje
2021-09-04 10:06 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Saurav Girepunje @ 2021-09-04 9:39 UTC (permalink / raw)
To: Larry.Finger, phil, straube.linux, martin, saurav.girepunje,
linux-staging, linux-kernel
Cc: saurav.girepunje
Remove unused variable ret and pwrpriv.
Remove the condition with no effect (if == else) in usb_intf.c
file.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
drivers/staging/r8188eu/os_dep/usb_intf.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
index bb85ab77fd26..673cd3001183 100644
--- a/drivers/staging/r8188eu/os_dep/usb_intf.c
+++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
@@ -493,14 +493,8 @@ static int rtw_resume(struct usb_interface *pusb_intf)
{
struct dvobj_priv *dvobj = usb_get_intfdata(pusb_intf);
struct adapter *padapter = dvobj->if1;
- struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
- int ret = 0;
- if (pwrpriv->bInternalAutoSuspend)
- ret = rtw_resume_process(padapter);
- else
- ret = rtw_resume_process(padapter);
- return ret;
+ return rtw_resume_process(padapter);
}
int rtw_resume_process(struct adapter *padapter)
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: r8188eu: os_dep: simplifiy the rtw_resume function
2021-09-04 9:39 [PATCH] staging: r8188eu: os_dep: simplifiy the rtw_resume function Saurav Girepunje
@ 2021-09-04 10:06 ` Greg KH
2021-09-04 12:04 ` Saurav Girepunje
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2021-09-04 10:06 UTC (permalink / raw)
To: Saurav Girepunje
Cc: Larry.Finger, phil, straube.linux, martin, linux-staging,
linux-kernel, saurav.girepunje
On Sat, Sep 04, 2021 at 03:09:13PM +0530, Saurav Girepunje wrote:
> Remove unused variable ret and pwrpriv.
> Remove the condition with no effect (if == else) in usb_intf.c
> file.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
> drivers/staging/r8188eu/os_dep/usb_intf.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
> index bb85ab77fd26..673cd3001183 100644
> --- a/drivers/staging/r8188eu/os_dep/usb_intf.c
> +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
> @@ -493,14 +493,8 @@ static int rtw_resume(struct usb_interface *pusb_intf)
> {
> struct dvobj_priv *dvobj = usb_get_intfdata(pusb_intf);
> struct adapter *padapter = dvobj->if1;
> - struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
> - int ret = 0;
>
> - if (pwrpriv->bInternalAutoSuspend)
> - ret = rtw_resume_process(padapter);
> - else
> - ret = rtw_resume_process(padapter);
> - return ret;
> + return rtw_resume_process(padapter);
> }
>
> int rtw_resume_process(struct adapter *padapter)
Why not just delete the rtw_resume_process() declaration line and make
the rtw_resume() function be the whole thing, as rtw_resume_process() is
never called anywhere else. That would be even more lines of code
removed and simplified here.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: r8188eu: os_dep: simplifiy the rtw_resume function
2021-09-04 10:06 ` Greg KH
@ 2021-09-04 12:04 ` Saurav Girepunje
0 siblings, 0 replies; 3+ messages in thread
From: Saurav Girepunje @ 2021-09-04 12:04 UTC (permalink / raw)
To: Greg KH
Cc: saurav.girepunje, Larry.Finger, phil, straube.linux, martin,
linux-staging, linux-kernel
On 04/09/21 3:36 pm, Greg KH wrote:
> On Sat, Sep 04, 2021 at 03:09:13PM +0530, Saurav Girepunje wrote:
>> Remove unused variable ret and pwrpriv.
>> Remove the condition with no effect (if == else) in usb_intf.c
>> file.
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
>> ---
>> drivers/staging/r8188eu/os_dep/usb_intf.c | 8 +-------
>> 1 file changed, 1 insertion(+), 7 deletions(-)
>>
>> diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
>> index bb85ab77fd26..673cd3001183 100644
>> --- a/drivers/staging/r8188eu/os_dep/usb_intf.c
>> +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
>> @@ -493,14 +493,8 @@ static int rtw_resume(struct usb_interface *pusb_intf)
>> {
>> struct dvobj_priv *dvobj = usb_get_intfdata(pusb_intf);
>> struct adapter *padapter = dvobj->if1;
>> - struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
>> - int ret = 0;
>>
>> - if (pwrpriv->bInternalAutoSuspend)
>> - ret = rtw_resume_process(padapter);
>> - else
>> - ret = rtw_resume_process(padapter);
>> - return ret;
>> + return rtw_resume_process(padapter);
>> }
>>
>> int rtw_resume_process(struct adapter *padapter)
>
> Why not just delete the rtw_resume_process() declaration line and make
> the rtw_resume() function be the whole thing, as rtw_resume_process() is
> never called anywhere else. That would be even more lines of code
> removed and simplified here.
>
> thanks,
>
> greg k-h
>
Yes, rtw_resume_process function can be removed .
Thanks for review greg.
Regards,
Saurav Girepunje
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-04 12:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-04 9:39 [PATCH] staging: r8188eu: os_dep: simplifiy the rtw_resume function Saurav Girepunje
2021-09-04 10:06 ` Greg KH
2021-09-04 12:04 ` Saurav Girepunje
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).