From: Aaron Ma <aaron.ma@canonical.com>
To: "Masaki Ota" <masaki.ota@jp.alps.com>,
"Pali Rohár" <pali.rohar@gmail.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] Input: ALPS - fix DualPoint flag for 74 03 28 devices
Date: Thu, 16 Nov 2017 17:07:12 +0800 [thread overview]
Message-ID: <30b4c473-9f7b-1657-4a23-e5f789d07c80@canonical.com> (raw)
In-Reply-To: <TYXPR01MB07195A0116F835764DE99882C72E0@TYXPR01MB0719.jpnprd01.prod.outlook.com>
Hi Masaki Ota:
Yes, the laptop is L570.
If your code is right, the workaround code for L570 must be done.
Please fix it ASAP.
Regards,
Aaron
On 11/16/2017 03:27 PM, Masaki Ota wrote:
> Hi, Pali, Aaron,
>
> Current code is correct device setting, previous code is wrong.
> If the trackstick does not work(DUALPOINT flag disable), Device Firmware setting is wrong.
>
> But recently I received the same report from Thinkpad L570 user, and I checked this device and found this device Firmware setting is wrong. Sorry for our mistake.
> Is your laptop L570 ?
>
> I will add code that supports the trackstick for this device.
>
> Best Regards,
> Masaki Ota
> -----Original Message-----
> From: Pali Rohár [mailto:pali.rohar@gmail.com]
> Sent: Wednesday, November 15, 2017 5:35 PM
> To: 太田 真喜 Masaki Ota <masaki.ota@jp.alps.com>
> Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; dmitry.torokhov@gmail.com; Aaron Ma <aaron.ma@canonical.com>
> Subject: Re: [PATCH] Input: ALPS - fix DualPoint flag for 74 03 28 devices
>
> On Wednesday 15 November 2017 14:34:04 Aaron Ma wrote:
>> There is a regression of commit 4a646580f793 ("Input: ALPS - fix
>> two-finger scroll breakage"), ALPS device fails with log:
>>
>> psmouse serio1: alps: Rejected trackstick packet from non DualPoint
>> device
>>
>> ALPS device with id "74 03 28" report OTP[0] data 0xCE after commit
>> 4a646580f793, after restore the OTP reading order, it becomes to 0x10
>> as before and reports the right flag.
>>
>> Fixes: 4a646580f793 ("Input: ALPS - fix two-finger scroll breakage")
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
>> ---
>> drivers/input/mouse/alps.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
>> index 579b899add26..c59b8f7ca2fc 100644
>> --- a/drivers/input/mouse/alps.c
>> +++ b/drivers/input/mouse/alps.c
>> @@ -2562,8 +2562,8 @@ static int alps_set_defaults_ss4_v2(struct
>> psmouse *psmouse,
>>
>> memset(otp, 0, sizeof(otp));
>>
>> - if (alps_get_otp_values_ss4_v2(psmouse, 1, &otp[1][0]) ||
>> - alps_get_otp_values_ss4_v2(psmouse, 0, &otp[0][0]))
>> + if (alps_get_otp_values_ss4_v2(psmouse, 0, &otp[0][0]) ||
>> + alps_get_otp_values_ss4_v2(psmouse, 1, &otp[1][0]))
>> return -1;
>>
>> alps_update_device_area_ss4_v2(otp, priv);
>
> Masaki Ota, please look at this patch as it partially revert your commit
> 4a646580f793 ("Input: ALPS - fix two-finger scroll breakage"). Something smells here.
>
> --
> Pali Rohár
> pali.rohar@gmail.com
>
next prev parent reply other threads:[~2017-11-16 9:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 6:34 [PATCH] Input: ALPS - fix DualPoint flag for 74 03 28 devices Aaron Ma
2017-11-15 8:35 ` Pali Rohár
2017-11-16 7:27 ` Masaki Ota
2017-11-16 9:07 ` Aaron Ma [this message]
2018-01-29 22:51 ` dmitry.torokhov
2018-03-20 18:47 ` Dmitry Torokhov
2018-03-25 21:25 ` Pali Rohár
2018-03-27 4:37 ` Masaki Ota
2018-03-28 7:38 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30b4c473-9f7b-1657-4a23-e5f789d07c80@canonical.com \
--to=aaron.ma@canonical.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masaki.ota@jp.alps.com \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).