From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Vignesh Raghavendra <vigneshr@ti.com>, <nm@ti.com>, <t-kristo@ti.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<nsekhar@ti.com>
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Correct the name of io expander on main_i2c1
Date: Fri, 20 Nov 2020 09:07:32 +0200 [thread overview]
Message-ID: <30c98749-5893-ffa4-6351-ee805b93bcb6@ti.com> (raw)
In-Reply-To: <dc2f740a-e53e-d612-0ec7-e69bf8228e71@ti.com>
On 19/11/2020 18.10, Vignesh Raghavendra wrote:
>
>
> On 11/19/20 6:56 PM, Peter Ujfalusi wrote:
>> J7200 main_i2c1 is connected to the i2c bus on the CPB marked as main_i2c3
>>
>> The i2c1 devices on the CPB are _not_ connected to the SoC, they are not
>> usable with the J7200 SOM.
>>
>> Correct the expander name from exp4 to exp3 and at the same time add the
>> line names as well.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
>
> Yes, the schematics call this expander as exp3. Thanks for the fix
The CPB is the same for both j721e and j7200 SOMs.
I'll send v2 with a small comment block to explain this.
> Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
>
>> arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> index 2721137d8943..83e043c65f81 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> @@ -159,11 +159,14 @@ &main_i2c1 {
>> pinctrl-0 = <&main_i2c1_pins_default>;
>> clock-frequency = <400000>;
>>
>> - exp4: gpio@20 {
>> + exp3: gpio@20 {
>> compatible = "ti,tca6408";
>> reg = <0x20>;
>> gpio-controller;
>> #gpio-cells = <2>;
>> + gpio-line-names = "CODEC_RSTz", "CODEC_SPARE1", "UB926_RESETn",
>> + "UB926_LOCK", "UB926_PWR_SW_CNTRL",
>> + "UB926_TUNER_RESET", "UB926_GPIO_SPARE", "";
>
> I assume these lines have same meaning in J721e and J7200? If so, then
> no issues.
>
>> };
>> };
>>
>>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
prev parent reply other threads:[~2020-11-20 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 13:26 [PATCH 0/2] arm64: dts: ti: k3-j7200-som/cpb: Correct i2c bus representations Peter Ujfalusi
2020-11-19 13:26 ` [PATCH 1/2] arm64: dts: ti: k3-j7200-som-p0: main_i2c0 have an ioexpander on the SOM Peter Ujfalusi
2020-11-19 14:45 ` Vignesh Raghavendra
2020-11-19 13:26 ` [PATCH 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Correct the name of io expander on main_i2c1 Peter Ujfalusi
2020-11-19 16:10 ` Vignesh Raghavendra
2020-11-20 7:07 ` Peter Ujfalusi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30c98749-5893-ffa4-6351-ee805b93bcb6@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=t-kristo@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).