From: "Jonas Mark (BT-FIR/ENG1-Grb)" <Mark.Jonas@de.bosch.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Support Opensource <support.opensource@diasemi.com>,
Lee Jones <lee.jones@linaro.org>,
"Streidl Hubert (BT-FIR/ENG1-Grb)" <Hubert.Streidl@de.bosch.com>,
"stwiss.opensource@diasemi.com" <stwiss.opensource@diasemi.com>,
"Jonas Mark (BT-FIR/ENG1-Grb)" <Mark.Jonas@de.bosch.com>
Subject: AW: [PATCH] mfd: da9063: propagate errno when I2C mode fails
Date: Tue, 25 May 2021 14:03:32 +0000 [thread overview]
Message-ID: <31c67c873f564ccda7e0f1860ec13806@de.bosch.com> (raw)
In-Reply-To: <20210525134243.4003-1-wsa+renesas@sang-engineering.com>
> Von: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Gesendet: Dienstag, 25. Mai 2021 15:43
> An: linux-kernel@vger.kernel.org
> Cc: Support Opensource <support.opensource@diasemi.com>; Lee Jones
> <lee.jones@linaro.org>; Jonas Mark (BT-FIR/ENG1-Grb)
> <Mark.Jonas@de.bosch.com>; Streidl Hubert (BT-FIR/ENG1-Grb)
> <Hubert.Streidl@de.bosch.com>; stwiss.opensource@diasemi.com; Wolfram
> Sang <wsa+renesas@sang-engineering.com>
> Betreff: [PATCH] mfd: da9063: propagate errno when I2C mode fails
>
> Don't hardocde EIO but use the obtained value.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/mfd/da9063-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c index
> 783a14af18e2..4b7f707b7952 100644
> --- a/drivers/mfd/da9063-i2c.c
> +++ b/drivers/mfd/da9063-i2c.c
> @@ -448,7 +448,7 @@ static int da9063_i2c_probe(struct i2c_client *i2c,
> DA9063_TWOWIRE_TO);
> if (ret < 0) {
> dev_err(da9063->dev, "Failed to set Two-Wire Bus
> Mode.\n");
> - return -EIO;
> + return ret;
> }
> }
>
> --
> 2.30.2
Reviewed-by: Mark Jonas <mark.jonas@de.bosch.com>
next prev parent reply other threads:[~2021-05-25 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 13:42 [PATCH] mfd: da9063: propagate errno when I2C mode fails Wolfram Sang
2021-05-25 14:03 ` Jonas Mark (BT-FIR/ENG1-Grb) [this message]
2021-06-01 15:00 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31c67c873f564ccda7e0f1860ec13806@de.bosch.com \
--to=mark.jonas@de.bosch.com \
--cc=Hubert.Streidl@de.bosch.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stwiss.opensource@diasemi.com \
--cc=support.opensource@diasemi.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).