[PATCH] mfd: da9063: propagate errno when I2C mode fails

[PATCH] mfd: da9063: propagate errno when I2C mode fails

[Wolfram Sang]

Don't hardocde EIO but use the obtained value.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/mfd/da9063-i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c
index 783a14af18e2..4b7f707b7952 100644
--- a/drivers/mfd/da9063-i2c.c
+++ b/drivers/mfd/da9063-i2c.c
@@ -448,7 +448,7 @@ static int da9063_i2c_probe(struct i2c_client *i2c,
 					DA9063_TWOWIRE_TO);
 		if (ret < 0) {
 			dev_err(da9063->dev, "Failed to set Two-Wire Bus Mode.\n");
-			return -EIO;
+			return ret;
 		}
 	}
 
-- 
2.30.2

AW: [PATCH] mfd: da9063: propagate errno when I2C mode fails

[Jonas Mark (BT-FIR/ENG1-Grb)]

> Von: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Gesendet: Dienstag, 25. Mai 2021 15:43
> An: linux-kernel@vger.kernel.org
> Cc: Support Opensource <support.opensource@diasemi.com>; Lee Jones
> <lee.jones@linaro.org>; Jonas Mark (BT-FIR/ENG1-Grb)
> <Mark.Jonas@de.bosch.com>; Streidl Hubert (BT-FIR/ENG1-Grb)
> <Hubert.Streidl@de.bosch.com>; stwiss.opensource@diasemi.com; Wolfram
> Sang <wsa+renesas@sang-engineering.com>
> Betreff: [PATCH] mfd: da9063: propagate errno when I2C mode fails
> 
> Don't hardocde EIO but use the obtained value.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  drivers/mfd/da9063-i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c index
> 783a14af18e2..4b7f707b7952 100644
> --- a/drivers/mfd/da9063-i2c.c
> +++ b/drivers/mfd/da9063-i2c.c
> @@ -448,7 +448,7 @@ static int da9063_i2c_probe(struct i2c_client *i2c,
>  					DA9063_TWOWIRE_TO);
>  		if (ret < 0) {
>  			dev_err(da9063->dev, "Failed to set Two-Wire Bus
> Mode.\n");
> -			return -EIO;
> +			return ret;
>  		}
>  	}
> 
> --
> 2.30.2

Reviewed-by: Mark Jonas <mark.jonas@de.bosch.com>

Re: [PATCH] mfd: da9063: propagate errno when I2C mode fails

[Lee Jones]

On Tue, 25 May 2021, Wolfram Sang wrote:

> Don't hardocde EIO but use the obtained value.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  drivers/mfd/da9063-i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog