* [PATCH V3] venus: core: add shutdown callback for venus
@ 2020-08-06 6:21 Mansur Alisha Shaik
2020-08-17 9:43 ` Stanimir Varbanov
0 siblings, 1 reply; 2+ messages in thread
From: Mansur Alisha Shaik @ 2020-08-06 6:21 UTC (permalink / raw)
To: linux-media, stanimir.varbanov
Cc: linux-kernel, linux-arm-msm, vgarodia, saiprakash.ranjan,
Mansur Alisha Shaik
After the SMMU translation is disabled in the
arm-smmu shutdown callback during reboot, if
any subsystem are still alive then IOVAs they
are using will become PAs on bus, which may
lead to crash.
Below are the consumers of smmu from venus
arm-smmu: consumer: aa00000.video-codec supplier=15000000.iommu
arm-smmu: consumer: video-firmware.0 supplier=15000000.iommu
So implemented shutdown callback, which detach iommu maps.
Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>
---
Changes in V3:
- Fix build errors
drivers/media/platform/qcom/venus/core.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
index 203c653..cfe211a 100644
--- a/drivers/media/platform/qcom/venus/core.c
+++ b/drivers/media/platform/qcom/venus/core.c
@@ -341,6 +341,16 @@ static int venus_remove(struct platform_device *pdev)
return ret;
}
+static void venus_core_shutdown(struct platform_device *pdev)
+{
+ struct venus_core *core = platform_get_drvdata(pdev);
+ int ret;
+
+ ret = venus_remove(pdev);
+ if (ret)
+ dev_warn(core->dev, "shutdown failed %d\n", ret);
+}
+
static __maybe_unused int venus_runtime_suspend(struct device *dev)
{
struct venus_core *core = dev_get_drvdata(dev);
@@ -592,6 +602,7 @@ static struct platform_driver qcom_venus_driver = {
.of_match_table = venus_dt_match,
.pm = &venus_pm_ops,
},
+ .shutdown = venus_core_shutdown,
};
module_platform_driver(qcom_venus_driver);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V3] venus: core: add shutdown callback for venus
2020-08-06 6:21 [PATCH V3] venus: core: add shutdown callback for venus Mansur Alisha Shaik
@ 2020-08-17 9:43 ` Stanimir Varbanov
0 siblings, 0 replies; 2+ messages in thread
From: Stanimir Varbanov @ 2020-08-17 9:43 UTC (permalink / raw)
To: Mansur Alisha Shaik, linux-media, stanimir.varbanov
Cc: linux-kernel, linux-arm-msm, vgarodia, saiprakash.ranjan
Hi Mansur,
On 8/6/20 9:21 AM, Mansur Alisha Shaik wrote:
> After the SMMU translation is disabled in the
> arm-smmu shutdown callback during reboot, if
> any subsystem are still alive then IOVAs they
> are using will become PAs on bus, which may
> lead to crash.
>
> Below are the consumers of smmu from venus
> arm-smmu: consumer: aa00000.video-codec supplier=15000000.iommu
> arm-smmu: consumer: video-firmware.0 supplier=15000000.iommu
>
> So implemented shutdown callback, which detach iommu maps.
>
> Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>
> ---
> Changes in V3:
> - Fix build errors
>
> drivers/media/platform/qcom/venus/core.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
As there is no more comments and it looks good to me:
Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index 203c653..cfe211a 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -341,6 +341,16 @@ static int venus_remove(struct platform_device *pdev)
> return ret;
> }
>
> +static void venus_core_shutdown(struct platform_device *pdev)
> +{
> + struct venus_core *core = platform_get_drvdata(pdev);
> + int ret;
> +
> + ret = venus_remove(pdev);
> + if (ret)
> + dev_warn(core->dev, "shutdown failed %d\n", ret);
> +}
> +
> static __maybe_unused int venus_runtime_suspend(struct device *dev)
> {
> struct venus_core *core = dev_get_drvdata(dev);
> @@ -592,6 +602,7 @@ static struct platform_driver qcom_venus_driver = {
> .of_match_table = venus_dt_match,
> .pm = &venus_pm_ops,
> },
> + .shutdown = venus_core_shutdown,
> };
> module_platform_driver(qcom_venus_driver);
>
>
--
regards,
Stan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-17 9:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-06 6:21 [PATCH V3] venus: core: add shutdown callback for venus Mansur Alisha Shaik
2020-08-17 9:43 ` Stanimir Varbanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).