linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] MAINTAINERS: Add an additional maintainer to the AMD XGBE driver
@ 2022-06-28 13:17 Tom Lendacky
  2022-06-28 17:37 ` Joe Perches
  0 siblings, 1 reply; 3+ messages in thread
From: Tom Lendacky @ 2022-06-28 13:17 UTC (permalink / raw)
  To: netdev, linux-kernel
  Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Shyam Sundar S K

Add Shyam Sundar S K as an additional maintainer to support the AMD XGBE
network device driver.

Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 36f0a205c54a..02e0d0464312 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1037,6 +1037,7 @@ F:	arch/arm64/boot/dts/amd/
 
 AMD XGBE DRIVER
 M:	Tom Lendacky <thomas.lendacky@amd.com>
+M:	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
 L:	netdev@vger.kernel.org
 S:	Supported
 F:	arch/arm64/boot/dts/amd/amd-seattle-xgbe*.dtsi
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] MAINTAINERS: Add an additional maintainer to the AMD XGBE driver
  2022-06-28 13:17 [PATCH net-next] MAINTAINERS: Add an additional maintainer to the AMD XGBE driver Tom Lendacky
@ 2022-06-28 17:37 ` Joe Perches
  2022-07-13 22:07   ` Tom Lendacky
  0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2022-06-28 17:37 UTC (permalink / raw)
  To: Tom Lendacky, netdev, linux-kernel
  Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Shyam Sundar S K

On Tue, 2022-06-28 at 08:17 -0500, Tom Lendacky wrote:
> Add Shyam Sundar S K as an additional maintainer to support the AMD XGBE
> network device driver.
> 
> Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
[]
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -1037,6 +1037,7 @@ F:	arch/arm64/boot/dts/amd/
>  
>  AMD XGBE DRIVER
>  M:	Tom Lendacky <thomas.lendacky@amd.com>
> +M:	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>

While this is a valid email address, get_maintainer assumes
name formats use "first middle last" when parsing a name
before an email address. (look around line 2460 in get_maintainer)

Perhaps this should use quotes around the name like:

M:	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] MAINTAINERS: Add an additional maintainer to the AMD XGBE driver
  2022-06-28 17:37 ` Joe Perches
@ 2022-07-13 22:07   ` Tom Lendacky
  0 siblings, 0 replies; 3+ messages in thread
From: Tom Lendacky @ 2022-07-13 22:07 UTC (permalink / raw)
  To: Joe Perches, netdev, linux-kernel
  Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Shyam Sundar S K

On 6/28/22 12:37, Joe Perches wrote:
> On Tue, 2022-06-28 at 08:17 -0500, Tom Lendacky wrote:
>> Add Shyam Sundar S K as an additional maintainer to support the AMD XGBE
>> network device driver.
>>
>> Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
>> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> []
>> diff --git a/MAINTAINERS b/MAINTAINERS
> []
>> @@ -1037,6 +1037,7 @@ F:	arch/arm64/boot/dts/amd/
>>   
>>   AMD XGBE DRIVER
>>   M:	Tom Lendacky <thomas.lendacky@amd.com>
>> +M:	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> 
> While this is a valid email address, get_maintainer assumes
> name formats use "first middle last" when parsing a name
> before an email address. (look around line 2460 in get_maintainer)
> 
> Perhaps this should use quotes around the name like:
> 
> M:	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>

Totally lost this in my Inbox, I'll submit a v2 with the quotes.

Thanks,
Tom

> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-07-13 22:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-28 13:17 [PATCH net-next] MAINTAINERS: Add an additional maintainer to the AMD XGBE driver Tom Lendacky
2022-06-28 17:37 ` Joe Perches
2022-07-13 22:07   ` Tom Lendacky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).