* Re: [PATCH v2 6/6] [media] Only descend into directory when CONFIG_MEDIA_SUPPORT is set
[not found] ` <20170105210158.14204-7-afd@ti.com>
@ 2017-01-05 21:42 ` Arnd Bergmann
2017-01-05 22:35 ` Andrew F. Davis
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2017-01-05 21:42 UTC (permalink / raw)
To: linuxppc-dev
Cc: Andrew F. Davis, Russell King, Miguel Ojeda Sandonis,
Wolfram Sang, Richard Purdie, Benjamin Herrenschmidt,
Mauro Carvalho Chehab, Ulf Hansson, Lauro Ramos Venancio,
Aloisio Almeida Jr, Samuel Ortiz, Ingo Molnar, linux-pwm,
linux-wireless, linux-kernel, linux-media
On Thursday, January 5, 2017 3:01:58 PM CET Andrew F. Davis wrote:
> @@ -109,7 +109,8 @@ obj-$(CONFIG_SERIO) += input/serio/
> obj-$(CONFIG_GAMEPORT) += input/gameport/
> obj-$(CONFIG_INPUT) += input/
> obj-$(CONFIG_RTC_LIB) += rtc/
> -obj-y += i2c/ media/
> +obj-y += i2c/
> +obj-$(CONFIG_MEDIA_SUPPORT) += media/
> obj-$(CONFIG_PPS) += pps/
> obj-y += ptp/
> obj-$(CONFIG_W1) += w1/
>
This one seems wrong: if CONFIG_MEDIA_SUPPORT=m, but some I2C drivers
inside of drivers/media/ are built-in, we will fail to enter the directory,
see drivers/media/Makefile.
I checked the other five patches in the series as well, they all look
ok to me.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 6/6] [media] Only descend into directory when CONFIG_MEDIA_SUPPORT is set
2017-01-05 21:42 ` [PATCH v2 6/6] [media] Only descend into directory when CONFIG_MEDIA_SUPPORT is set Arnd Bergmann
@ 2017-01-05 22:35 ` Andrew F. Davis
2017-01-05 23:12 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Andrew F. Davis @ 2017-01-05 22:35 UTC (permalink / raw)
To: Arnd Bergmann, linuxppc-dev
Cc: Russell King, Miguel Ojeda Sandonis, Wolfram Sang,
Richard Purdie, Benjamin Herrenschmidt, Mauro Carvalho Chehab,
Ulf Hansson, Lauro Ramos Venancio, Aloisio Almeida Jr,
Samuel Ortiz, Ingo Molnar, linux-pwm, linux-wireless,
linux-kernel, linux-media
On 01/05/2017 03:42 PM, Arnd Bergmann wrote:
> On Thursday, January 5, 2017 3:01:58 PM CET Andrew F. Davis wrote:
>> @@ -109,7 +109,8 @@ obj-$(CONFIG_SERIO) += input/serio/
>> obj-$(CONFIG_GAMEPORT) += input/gameport/
>> obj-$(CONFIG_INPUT) += input/
>> obj-$(CONFIG_RTC_LIB) += rtc/
>> -obj-y += i2c/ media/
>> +obj-y += i2c/
>> +obj-$(CONFIG_MEDIA_SUPPORT) += media/
>> obj-$(CONFIG_PPS) += pps/
>> obj-y += ptp/
>> obj-$(CONFIG_W1) += w1/
>>
>
> This one seems wrong: if CONFIG_MEDIA_SUPPORT=m, but some I2C drivers
> inside of drivers/media/ are built-in, we will fail to enter the directory,
> see drivers/media/Makefile.
Not sure if I see this, it looks like everything in drivers/media/
depends on CONFIG_MEDIA_SUPPORT (directly or indirectly). If
CONFIG_MEDIA_SUPPORT is =m then all dependents should be locked out of
being built-in.
Any bool symbol that controls compilation of source that depends on a
tristate symbol is broken and should be fixed anyway.
>
> I checked the other five patches in the series as well, they all look
> ok to me.
>
> Arnd
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 6/6] [media] Only descend into directory when CONFIG_MEDIA_SUPPORT is set
2017-01-05 22:35 ` Andrew F. Davis
@ 2017-01-05 23:12 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-01-05 23:12 UTC (permalink / raw)
To: Andrew F. Davis
Cc: linuxppc-dev, Russell King, Miguel Ojeda Sandonis, Wolfram Sang,
Richard Purdie, Benjamin Herrenschmidt, Mauro Carvalho Chehab,
Ulf Hansson, Lauro Ramos Venancio, Aloisio Almeida Jr,
Samuel Ortiz, Ingo Molnar, linux-pwm, linux-wireless,
linux-kernel, linux-media
On Thursday, January 5, 2017 4:35:33 PM CET Andrew F. Davis wrote:
> On 01/05/2017 03:42 PM, Arnd Bergmann wrote:
> > On Thursday, January 5, 2017 3:01:58 PM CET Andrew F. Davis wrote:
> >> @@ -109,7 +109,8 @@ obj-$(CONFIG_SERIO) += input/serio/
> >> obj-$(CONFIG_GAMEPORT) += input/gameport/
> >> obj-$(CONFIG_INPUT) += input/
> >> obj-$(CONFIG_RTC_LIB) += rtc/
> >> -obj-y += i2c/ media/
> >> +obj-y += i2c/
> >> +obj-$(CONFIG_MEDIA_SUPPORT) += media/
> >> obj-$(CONFIG_PPS) += pps/
> >> obj-y += ptp/
> >> obj-$(CONFIG_W1) += w1/
> >>
> >
> > This one seems wrong: if CONFIG_MEDIA_SUPPORT=m, but some I2C drivers
> > inside of drivers/media/ are built-in, we will fail to enter the directory,
> > see drivers/media/Makefile.
>
> Not sure if I see this, it looks like everything in drivers/media/
> depends on CONFIG_MEDIA_SUPPORT (directly or indirectly). If
> CONFIG_MEDIA_SUPPORT is =m then all dependents should be locked out of
> being built-in.
>
> Any bool symbol that controls compilation of source that depends on a
> tristate symbol is broken and should be fixed anyway.
I don't think it's this easy, we have a couple of cases where that doesn't
work. I have not looked at the media example in detail, but at least it
looks intentional.
Note that drivers/media is rather creative with expressing dependencies.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-05 23:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170105210158.14204-1-afd@ti.com>
[not found] ` <20170105210158.14204-7-afd@ti.com>
2017-01-05 21:42 ` [PATCH v2 6/6] [media] Only descend into directory when CONFIG_MEDIA_SUPPORT is set Arnd Bergmann
2017-01-05 22:35 ` Andrew F. Davis
2017-01-05 23:12 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).