* rio_init, tty_io call confusion. 2.4.8-pre4
@ 2001-08-06 4:22 Keith Owens
2001-08-06 12:21 ` Alan Cox
0 siblings, 1 reply; 3+ messages in thread
From: Keith Owens @ 2001-08-06 4:22 UTC (permalink / raw)
To: R.E.Wolff; +Cc: linux-kernel
drivers/char/tty_io calls rio_init and gets a link error when rio is
linked into the kenrel because rio_init is declared as static. However
rio_init is also declared as module_init() so it gets called twice, one
from tty_io and once from the kernel initcall code. One of those calls
has to go. If you keep the tty_io call then rio_init cannot be static.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: rio_init, tty_io call confusion. 2.4.8-pre4
2001-08-06 4:22 rio_init, tty_io call confusion. 2.4.8-pre4 Keith Owens
@ 2001-08-06 12:21 ` Alan Cox
2001-08-06 12:23 ` Rogier Wolff
0 siblings, 1 reply; 3+ messages in thread
From: Alan Cox @ 2001-08-06 12:21 UTC (permalink / raw)
To: Keith Owens; +Cc: R.E.Wolff, linux-kernel
> drivers/char/tty_io calls rio_init and gets a link error when rio is
> linked into the kenrel because rio_init is declared as static. However
> rio_init is also declared as module_init() so it gets called twice, one
> from tty_io and once from the kernel initcall code. One of those calls
> has to go. If you keep the tty_io call then rio_init cannot be static.
The tty_io call appears to be stale
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: rio_init, tty_io call confusion. 2.4.8-pre4
2001-08-06 12:21 ` Alan Cox
@ 2001-08-06 12:23 ` Rogier Wolff
0 siblings, 0 replies; 3+ messages in thread
From: Rogier Wolff @ 2001-08-06 12:23 UTC (permalink / raw)
To: Alan Cox; +Cc: Keith Owens, R.E.Wolff, linux-kernel
Alan Cox wrote:
> > drivers/char/tty_io calls rio_init and gets a link error when rio is
> > linked into the kenrel because rio_init is declared as static. However
> > rio_init is also declared as module_init() so it gets called twice, one
> > from tty_io and once from the kernel initcall code. One of those calls
> > has to go. If you keep the tty_io call then rio_init cannot be static.
>
> The tty_io call appears to be stale
Agreed, thought so too, but haven't had the time to look into
it. Alan, while you're at it, can you remove the call and we'll try to
test "in kernel" and "as a module" ASAP. (which looks as if it's going
to be months, as we're swamped with other stuff.....)
Roger.
--
** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2137555 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
* There are old pilots, and there are bold pilots.
* There are also old, bald pilots.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-08-06 12:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-08-06 4:22 rio_init, tty_io call confusion. 2.4.8-pre4 Keith Owens
2001-08-06 12:21 ` Alan Cox
2001-08-06 12:23 ` Rogier Wolff
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).