* [PATCH] staging/rdma/hfi1: do not use u8 to store a 32-bit integer
@ 2015-09-20 14:07 Nicolas Iooss
2015-09-21 14:49 ` Marciniszyn, Mike
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Iooss @ 2015-09-20 14:07 UTC (permalink / raw)
To: Mike Marciniszyn, Doug Ledford, Sean Hefty, Hal Rosenstock,
Greg Kroah-Hartman, linux-rdma
Cc: devel, linux-kernel, Nicolas Iooss
hfi1_rc_hdrerr() stores the result of be32_to_cpu() into opcode, which
is a local variable declared as u8. Later this variable is used in a
24-bit logical right shift, which makes clang complains (when building
an allmodconfig kernel with LLVMLinux patches):
drivers/staging/rdma/hfi1/rc.c:2399:9: warning: shift count >= width
of type [-Wshift-count-overflow]
opcode >>= 24;
^ ~~
All of this lead to the point that opcode may have been designed to be
a 32-bit integer instead of an 8-bit one. Therefore make this variable
u32.
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
---
drivers/staging/rdma/hfi1/rc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rdma/hfi1/rc.c b/drivers/staging/rdma/hfi1/rc.c
index 632dd5ba7dfd..1e9caebb0281 100644
--- a/drivers/staging/rdma/hfi1/rc.c
+++ b/drivers/staging/rdma/hfi1/rc.c
@@ -2383,7 +2383,7 @@ void hfi1_rc_hdrerr(
struct hfi1_other_headers *ohdr;
struct hfi1_ibport *ibp = to_iport(qp->ibqp.device, qp->port_num);
int diff;
- u8 opcode;
+ u32 opcode;
u32 psn;
/* Check for GRH */
--
2.5.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] staging/rdma/hfi1: do not use u8 to store a 32-bit integer
2015-09-20 14:07 [PATCH] staging/rdma/hfi1: do not use u8 to store a 32-bit integer Nicolas Iooss
@ 2015-09-21 14:49 ` Marciniszyn, Mike
0 siblings, 0 replies; 2+ messages in thread
From: Marciniszyn, Mike @ 2015-09-21 14:49 UTC (permalink / raw)
To: Nicolas Iooss, Doug Ledford, Hefty, Sean, Hal Rosenstock,
Greg Kroah-Hartman, linux-rdma
Cc: devel, linux-kernel
> Subject: [PATCH] staging/rdma/hfi1: do not use u8 to store a 32-bit integer
>
Thanks for the patch!
Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-21 14:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-20 14:07 [PATCH] staging/rdma/hfi1: do not use u8 to store a 32-bit integer Nicolas Iooss
2015-09-21 14:49 ` Marciniszyn, Mike
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).