From: Andrew Davis <afd@ti.com>
To: Eugene Syromiatnikov <esyr@redhat.com>
Cc: Jens Wiklander <jens.wiklander@linaro.org>,
Sumit Garg <sumit.garg@linaro.org>,
<op-tee@lists.trustedfirmware.org>,
<linux-kernel@vger.kernel.org>, <ldv@strace.io>
Subject: Re: [PATCH v2 2/2] tee: remove flags TEE_IOCTL_SHM_MAPPED and TEE_IOCTL_SHM_DMA_BUF
Date: Wed, 8 Jun 2022 17:35:18 -0500 [thread overview]
Message-ID: <32a53ead-c5ec-bb7e-abd1-8bfc1bf67959@ti.com> (raw)
In-Reply-To: <20220608135116.GA27854@asgard.redhat.com>
On 6/8/22 8:52 AM, Eugene Syromiatnikov wrote:
> On Mon, Apr 25, 2022 at 09:16:17AM -0500, Andrew Davis wrote:
>> These look to be leftover from an early edition of this driver. Userspace
>> does not need this information. Checking all users of this that I have
>> access to I have verified no one is using them.
>
> This change has broken build of strace's test suite against the latest kernel
> headers[1]; the usage prety much shows up in the Debian's code search[2].
>
> [1] https://github.com/strace/strace/runs/6794205205?check_suite_focus=true#step:4:3862
> [2] https://codesearch.debian.net/search?q=TEE_IOCTL_SHM_MAPPED+package%3A%5CQstrace%5CE&literal=1
>
Thanks for the headsup, I've sent a patch to fix strace tests.
Andrew
>> They leak internal use flags out to userspace. Even more they are not
>> correct anymore after a45ea4efa358. Lets drop these flags before
>> someone does try to use them for something and they become ABI.
>
next prev parent reply other threads:[~2022-06-08 22:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 14:16 [PATCH v2 1/2] tee: remove tee_shm_va2pa() and tee_shm_pa2va() Andrew Davis
2022-04-25 14:16 ` [PATCH v2 2/2] tee: remove flags TEE_IOCTL_SHM_MAPPED and TEE_IOCTL_SHM_DMA_BUF Andrew Davis
2022-04-25 14:18 ` Sumit Garg
2022-04-26 8:21 ` Jens Wiklander
2022-06-08 13:52 ` Eugene Syromiatnikov
2022-06-08 22:35 ` Andrew Davis [this message]
2022-04-26 8:20 ` [PATCH v2 1/2] tee: remove tee_shm_va2pa() and tee_shm_pa2va() Jens Wiklander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32a53ead-c5ec-bb7e-abd1-8bfc1bf67959@ti.com \
--to=afd@ti.com \
--cc=esyr@redhat.com \
--cc=jens.wiklander@linaro.org \
--cc=ldv@strace.io \
--cc=linux-kernel@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=sumit.garg@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).