From: Jens Wiklander <jens.wiklander@linaro.org>
To: Andrew Davis <afd@ti.com>
Cc: Sumit Garg <sumit.garg@linaro.org>,
op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] tee: remove tee_shm_va2pa() and tee_shm_pa2va()
Date: Tue, 26 Apr 2022 10:20:56 +0200 [thread overview]
Message-ID: <CAHUa44HMbsthyH1FN-Ug3ArGCApWtWT=H4D1qKk-PTKRsyJPBw@mail.gmail.com> (raw)
In-Reply-To: <20220425141617.23925-1-afd@ti.com>
On Mon, Apr 25, 2022 at 4:16 PM Andrew Davis <afd@ti.com> wrote:
>
> We should not need to index into SHMs based on absolute VA/PA.
> These functions are not used and this kind of usage should not be
> encouraged anyway. Remove these functions.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
> ---
> drivers/tee/tee_shm.c | 50 -----------------------------------------
> include/linux/tee_drv.h | 18 ---------------
> 2 files changed, 68 deletions(-)
Looks good to me, I'm picking up this.
Thanks,
Jens
>
> diff --git a/drivers/tee/tee_shm.c b/drivers/tee/tee_shm.c
> index f31e29e8f1cac..b0c6d553d3a70 100644
> --- a/drivers/tee/tee_shm.c
> +++ b/drivers/tee/tee_shm.c
> @@ -414,56 +414,6 @@ void tee_shm_free(struct tee_shm *shm)
> }
> EXPORT_SYMBOL_GPL(tee_shm_free);
>
> -/**
> - * tee_shm_va2pa() - Get physical address of a virtual address
> - * @shm: Shared memory handle
> - * @va: Virtual address to tranlsate
> - * @pa: Returned physical address
> - * @returns 0 on success and < 0 on failure
> - */
> -int tee_shm_va2pa(struct tee_shm *shm, void *va, phys_addr_t *pa)
> -{
> - if (!shm->kaddr)
> - return -EINVAL;
> - /* Check that we're in the range of the shm */
> - if ((char *)va < (char *)shm->kaddr)
> - return -EINVAL;
> - if ((char *)va >= ((char *)shm->kaddr + shm->size))
> - return -EINVAL;
> -
> - return tee_shm_get_pa(
> - shm, (unsigned long)va - (unsigned long)shm->kaddr, pa);
> -}
> -EXPORT_SYMBOL_GPL(tee_shm_va2pa);
> -
> -/**
> - * tee_shm_pa2va() - Get virtual address of a physical address
> - * @shm: Shared memory handle
> - * @pa: Physical address to tranlsate
> - * @va: Returned virtual address
> - * @returns 0 on success and < 0 on failure
> - */
> -int tee_shm_pa2va(struct tee_shm *shm, phys_addr_t pa, void **va)
> -{
> - if (!shm->kaddr)
> - return -EINVAL;
> - /* Check that we're in the range of the shm */
> - if (pa < shm->paddr)
> - return -EINVAL;
> - if (pa >= (shm->paddr + shm->size))
> - return -EINVAL;
> -
> - if (va) {
> - void *v = tee_shm_get_va(shm, pa - shm->paddr);
> -
> - if (IS_ERR(v))
> - return PTR_ERR(v);
> - *va = v;
> - }
> - return 0;
> -}
> -EXPORT_SYMBOL_GPL(tee_shm_pa2va);
> -
> /**
> * tee_shm_get_va() - Get virtual address of a shared memory plus an offset
> * @shm: Shared memory handle
> diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h
> index 911cad324acc7..17eb1c5205d34 100644
> --- a/include/linux/tee_drv.h
> +++ b/include/linux/tee_drv.h
> @@ -298,24 +298,6 @@ void tee_shm_free(struct tee_shm *shm);
> */
> void tee_shm_put(struct tee_shm *shm);
>
> -/**
> - * tee_shm_va2pa() - Get physical address of a virtual address
> - * @shm: Shared memory handle
> - * @va: Virtual address to tranlsate
> - * @pa: Returned physical address
> - * @returns 0 on success and < 0 on failure
> - */
> -int tee_shm_va2pa(struct tee_shm *shm, void *va, phys_addr_t *pa);
> -
> -/**
> - * tee_shm_pa2va() - Get virtual address of a physical address
> - * @shm: Shared memory handle
> - * @pa: Physical address to tranlsate
> - * @va: Returned virtual address
> - * @returns 0 on success and < 0 on failure
> - */
> -int tee_shm_pa2va(struct tee_shm *shm, phys_addr_t pa, void **va);
> -
> /**
> * tee_shm_get_va() - Get virtual address of a shared memory plus an offset
> * @shm: Shared memory handle
> --
> 2.17.1
>
prev parent reply other threads:[~2022-04-26 8:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 14:16 [PATCH v2 1/2] tee: remove tee_shm_va2pa() and tee_shm_pa2va() Andrew Davis
2022-04-25 14:16 ` [PATCH v2 2/2] tee: remove flags TEE_IOCTL_SHM_MAPPED and TEE_IOCTL_SHM_DMA_BUF Andrew Davis
2022-04-25 14:18 ` Sumit Garg
2022-04-26 8:21 ` Jens Wiklander
2022-06-08 13:52 ` Eugene Syromiatnikov
2022-06-08 22:35 ` Andrew Davis
2022-04-26 8:20 ` Jens Wiklander [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHUa44HMbsthyH1FN-Ug3ArGCApWtWT=H4D1qKk-PTKRsyJPBw@mail.gmail.com' \
--to=jens.wiklander@linaro.org \
--cc=afd@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=sumit.garg@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).