linux-next: build warning after merge of the leds tree

linux-next: build warning after merge of the leds tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Hi all,

After merging the leds tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/leds/leds-pca9532.c: In function 'pca9532_probe':
drivers/leds/leds-pca9532.c:536:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   devid = (int)of_id->data;
           ^

Introduced by commit

  6b788fae618c ("leds: fix a potential NULL pointer dereference")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the leds tree

[Jacek Anaszewski]

Hi Stephen,

Thank you for the report.

On 3/19/19 3:58 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the leds tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/leds/leds-pca9532.c: In function 'pca9532_probe':
> drivers/leds/leds-pca9532.c:536:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>     devid = (int)of_id->data;
>             ^

Applied the fixup to the original commit, which missed to carry
the cast properly from the previous state of code.

-               devid = (int)of_id->data;
+               devid = (int)(uintptr_t) of_id->data;


> Introduced by commit
> 
>    6b788fae618c ("leds: fix a potential NULL pointer dereference")
> 

-- 
Best regards,
Jacek Anaszewski

Re: linux-next: build warning after merge of the leds tree

[Jacek Anaszewski]

Hi Stephen and all,

On 2/14/19 4:46 AM, Stephen Rothwell wrote:
> Hi Jacek,
> 
> After merging the leds tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_firmware_loaded':
> drivers/leds/leds-lp55xx-common.c:217:1: warning: label 'out' defined but not used [-Wunused-label]
>   out:
>   ^~~

Thank you for the heads-up. It's my bad - I didn't use sparse on it.

Fixed up the original patch.

> Introduced by commit
> 
>    905c2157dd19 ("leds: lp55xx: fix null deref on firmware load failure")
> 

-- 
Best regards,
Jacek Anaszewski

Re: linux-next: build warning after merge of the leds tree

[Michal Kazior]

On Thu, Feb 14, 2019 at 4:46 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Jacek,
>
> After merging the leds tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_firmware_loaded':
> drivers/leds/leds-lp55xx-common.c:217:1: warning: label 'out' defined but not used [-Wunused-label]
>  out:
>  ^~~
>
> Introduced by commit
>
>   905c2157dd19 ("leds: lp55xx: fix null deref on firmware load failure")

I'm sorry guys, that's my fault. Let me fix that.


Michał

linux-next: build warning after merge of the leds tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

Hi Jacek,

After merging the leds tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/leds/leds-lp55xx-common.c: In function 'lp55xx_firmware_loaded':
drivers/leds/leds-lp55xx-common.c:217:1: warning: label 'out' defined but not used [-Wunused-label]
 out:
 ^~~

Introduced by commit

  905c2157dd19 ("leds: lp55xx: fix null deref on firmware load failure")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]