From: Jiri Slaby <jslaby@suse.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] tty: use tty_init_dev_retry() to workaround a race condition
Date: Mon, 25 Nov 2019 11:42:50 +0100 [thread overview]
Message-ID: <337ba6f4-925d-3636-e18a-ad6d20181329@suse.com> (raw)
In-Reply-To: <20191124000233.xc2rp5umut4g3mnx@debian>
On 24. 11. 19, 1:02, Sudip Mukherjee wrote:
>> BTW do you see the warning from tty_init_dev:
>> "driver does not set tty->port. This will crash the kernel later. Fix
>> the driver!\n"
>> ? Maybe not given console is registered already, but crashes.
>
> yes. I do see the warning but I have always assumed that the warning is
> because console is openend as soon as it registers and so uart_add_one_port()
> does not get the chance to link it. Is it not so?
Yes it is, I was just curious...
thanks,
--
js
suse labs
next prev parent reply other threads:[~2019-11-25 10:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 15:22 [PATCH v2 1/2] tty: add retry capability to tty_init_dev() Sudip Mukherjee
2019-11-21 15:22 ` [PATCH v2 2/2] tty: use tty_init_dev_retry() to workaround a race condition Sudip Mukherjee
2019-11-21 16:41 ` Greg Kroah-Hartman
2019-11-21 21:01 ` Sudip Mukherjee
2019-11-22 9:05 ` Jiri Slaby
2019-11-22 9:11 ` Jiri Slaby
2019-11-24 0:02 ` Sudip Mukherjee
2019-11-25 10:42 ` Jiri Slaby [this message]
2019-12-10 11:41 ` Sudip Mukherjee
2019-12-12 11:15 ` Greg Kroah-Hartman
2019-12-17 11:47 ` Sudip Mukherjee
2019-12-17 12:05 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=337ba6f4-925d-3636-e18a-ad6d20181329@suse.com \
--to=jslaby@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).