* [PATCH] cpufreq: speedstep-lib: make several arrays static, makes code smaller
@ 2017-08-25 17:00 Colin King
2017-08-30 23:32 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-08-25 17:00 UTC (permalink / raw)
To: Rafael J . Wysocki, Viresh Kumar, linux-pm; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Don't populate arrays on the stack, instead make them static.
Makes the object code smaller by over 860 bytes:
Before:
text data bss dec hex filename
10716 5196 0 15912 3e28 drivers/cpufreq/speedstep-lib.o
After:
text data bss dec hex filename
9690 5356 0 15046 3ac6 drivers/cpufreq/speedstep-lib.o
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/cpufreq/speedstep-lib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/cpufreq/speedstep-lib.c b/drivers/cpufreq/speedstep-lib.c
index 1b8062182c81..ccab452a4ef5 100644
--- a/drivers/cpufreq/speedstep-lib.c
+++ b/drivers/cpufreq/speedstep-lib.c
@@ -35,7 +35,7 @@ static int relaxed_check;
static unsigned int pentium3_get_frequency(enum speedstep_processor processor)
{
/* See table 14 of p3_ds.pdf and table 22 of 29834003.pdf */
- struct {
+ static const struct {
unsigned int ratio; /* Frequency Multiplier (x10) */
u8 bitmap; /* power on configuration bits
[27, 25:22] (in MSR 0x2a) */
@@ -58,7 +58,7 @@ static unsigned int pentium3_get_frequency(enum speedstep_processor processor)
};
/* PIII(-M) FSB settings: see table b1-b of 24547206.pdf */
- struct {
+ static const struct {
unsigned int value; /* Front Side Bus speed in MHz */
u8 bitmap; /* power on configuration bits [18: 19]
(in MSR 0x2a) */
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cpufreq: speedstep-lib: make several arrays static, makes code smaller
2017-08-25 17:00 [PATCH] cpufreq: speedstep-lib: make several arrays static, makes code smaller Colin King
@ 2017-08-30 23:32 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2017-08-30 23:32 UTC (permalink / raw)
To: Colin King; +Cc: Viresh Kumar, linux-pm, kernel-janitors, linux-kernel
On Friday, August 25, 2017 7:00:16 PM CEST Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate arrays on the stack, instead make them static.
> Makes the object code smaller by over 860 bytes:
>
> Before:
> text data bss dec hex filename
> 10716 5196 0 15912 3e28 drivers/cpufreq/speedstep-lib.o
>
> After:
> text data bss dec hex filename
> 9690 5356 0 15046 3ac6 drivers/cpufreq/speedstep-lib.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/cpufreq/speedstep-lib.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/speedstep-lib.c b/drivers/cpufreq/speedstep-lib.c
> index 1b8062182c81..ccab452a4ef5 100644
> --- a/drivers/cpufreq/speedstep-lib.c
> +++ b/drivers/cpufreq/speedstep-lib.c
> @@ -35,7 +35,7 @@ static int relaxed_check;
> static unsigned int pentium3_get_frequency(enum speedstep_processor processor)
> {
> /* See table 14 of p3_ds.pdf and table 22 of 29834003.pdf */
> - struct {
> + static const struct {
> unsigned int ratio; /* Frequency Multiplier (x10) */
> u8 bitmap; /* power on configuration bits
> [27, 25:22] (in MSR 0x2a) */
> @@ -58,7 +58,7 @@ static unsigned int pentium3_get_frequency(enum speedstep_processor processor)
> };
>
> /* PIII(-M) FSB settings: see table b1-b of 24547206.pdf */
> - struct {
> + static const struct {
> unsigned int value; /* Front Side Bus speed in MHz */
> u8 bitmap; /* power on configuration bits [18: 19]
> (in MSR 0x2a) */
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-30 23:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-25 17:00 [PATCH] cpufreq: speedstep-lib: make several arrays static, makes code smaller Colin King
2017-08-30 23:32 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).