From: Luca Weiss <luca@z3ntu.xyz>
To: Petr Vorel <petr.vorel@gmail.com>,
linux-arm-msm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
Oleksij Rempel <linux@rempel-privat.de>,
Sam Ravnborg <sam@ravnborg.org>,
Linus Walleij <linus.walleij@linaro.org>,
Daniel Palmer <daniel@0x0f.com>,
Max Merchel <Max.Merchel@tq-group.com>,
Hao Fang <fanghao11@huawei.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Jean THOMAS <virgule@jeanthomas.me>
Subject: Re: [PATCH 6/8] dt-bindings: vendor-prefixes: add LG Electronics
Date: Sat, 29 Jan 2022 10:45:23 +0100 [thread overview]
Message-ID: <3398674.ElGaqSPkdT@g550jk> (raw)
In-Reply-To: <64ee2334-aa99-7226-8946-84c95676041a@canonical.com>
Hi Krzysztof,
On Freitag, 28. Jänner 2022 10:57:15 CET Krzysztof Kozlowski wrote:
> On 27/01/2022 21:51, Luca Weiss wrote:
> > Hi all,
> >
> > On Donnerstag, 27. Jänner 2022 08:45:33 CET Krzysztof Kozlowski wrote:
> >> On 27/01/2022 01:20, Petr Vorel wrote:
> >>> Hi all,
> >>>
> >>>>> Hi Krzysztof,
> >>>>>
> >>>>> On Montag, 13. September 2021 10:49:43 CEST Krzysztof Kozlowski wrote:
> >>>>>> On 12/09/2021 01:27, Luca Weiss wrote:
> >>>>>>> LG Electronics is a part of the LG Corporation and produces, amongst
> >>>>>>> other things, consumer electronics such as phones and smartwatches.
> >>>>>>
> >>>>>> Hi,
> >>>>>>
> >>>>>> Thanks for the patches.
> >>>>>>
> >>>>>> I think "lge" it's the same prefix as "lg". There is no sense in
> >>>>>> having
> >>>>>> multiple vendor prefixes just because company splits inside business
> >>>>>> units or subsidiaries. The same as with other conglomerates, e.g.
> >>>>>> Samsung - if we wanted to be specific, there will be 4-5 Samsung
> >>>>>> vendors... Not mentioning that company organisation is not always
> >>>>>> disclosed and can change.
> >>>>>
> >>>>> I was mostly following qcom-msm8974-lge-nexus5-hammerhead as it's the
> >>>>> other LG device tree I am aware of so I've picked lge instead of lg.
> >>>>> Also worth noting that Google uses "LGE" in the Android device tree[1]
> >>>>> or in the model name in the LG G Watch R kernel sources ("LGE APQ
> >>>>> 8026v2 LENOK rev-1.0")
> >>>>
> >>>> [1] Does not point to kernel tree. Downstream user could be a good
> >>>> argument to switch to lge, but then I would expect correcting other
> >>>> "lg"
> >>>> devices which are in fact made by LGE.
> >>>>
> >>>>> I don't have a strong opinion either way so I'm fine with either.
> >>>>>
> >>>>> If we decide to go with "lg" do we want to change the Nexus 5
> >>>>> devicetree
> >>>>> (hammerhead) also, that one has the lge name in at least compatible
> >>>>> and
> >>>>> filename (I don't know how much of a breaking change that would be
> >>>>> considered as).
> >>>>
> >>>> We would have to add a new one and mark the old compatible as
> >>>> deprecated.
> >>>
> >>> Have we sorted this lg- vs. lge- ?
> >>>
> >>> There are both:
> >>> arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> >>> vs
> >>> arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
> >>
> >> Probably renaming/unifying/correcting prefix in existing compatibles is
> >> not worth the effort. This would make a mess and affect other DTS users.
> >
> > If wanted I can send a patch renaming the Nexus 5 to just LG, this would
> > adjust both compatible in the file (which shouldn't really affect
> > anything) and the filename (which probably will affect various scripts
> > and whatnot used by existing users of the dtb).
> > Is this something that can be done in mainline or should we rather just
> > let it be? I'm not sure what the policies there are.
>
> The "lge" compatible is already in the bindings, so it should not be
> changed without valid reason. Imagine there is an user-space code
> parsing compatibles to adjust some power-management settings to
> different models. It would be broken now.
>
> What could be done is to mark it as deprecated and a add new one:
> compatible = "lg,hammerhead", "lge,hammerhead", "qcom,msm8974";
> This should be safe for user-space and allow transition to common "lg".
What can or should be done about the filename then?
For compatible in the file it's now clear from my side.
Regards
Luca
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2022-01-29 9:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 23:26 [PATCH 0/8] Initial LG G Watch R support Luca Weiss
2021-09-11 23:26 ` [PATCH 1/8] pinctrl: qcom: msm8226: fill in more functions Luca Weiss
2021-09-13 17:45 ` Bjorn Andersson
2021-09-17 22:31 ` Linus Walleij
2021-09-11 23:26 ` [PATCH 2/8] dt-bindings: mmc: sdhci-msm: Add compatible string for msm8226 Luca Weiss
2021-09-14 11:24 ` Ulf Hansson
2021-09-11 23:26 ` [PATCH 3/8] dt-bindings: firmware: scm: Add compatible " Luca Weiss
2021-09-11 23:26 ` [PATCH 4/8] ARM: dts: qcom: msm8226: Add more SoC bits Luca Weiss
2021-09-11 23:26 ` [PATCH 5/8] ARM: dts: qcom: Add pm8226 PMIC Luca Weiss
2021-09-11 23:27 ` [PATCH 6/8] dt-bindings: vendor-prefixes: add LG Electronics Luca Weiss
2021-09-13 8:49 ` Krzysztof Kozlowski
2021-09-13 19:14 ` Luca Weiss
2021-09-14 7:24 ` Krzysztof Kozlowski
2022-01-27 0:20 ` Petr Vorel
2022-01-27 7:45 ` Krzysztof Kozlowski
2022-01-27 20:51 ` Luca Weiss
2022-01-28 9:57 ` Krzysztof Kozlowski
2022-01-29 9:45 ` Luca Weiss [this message]
2022-01-29 10:34 ` Krzysztof Kozlowski
2021-09-11 23:27 ` [PATCH 7/8] dt-bindings: arm: qcom: Document APQ8026 SoC binding Luca Weiss
2021-09-20 21:53 ` Rob Herring
2021-09-11 23:27 ` [PATCH 8/8] ARM: dts: qcom: Add support for LG G Watch R Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3398674.ElGaqSPkdT@g550jk \
--to=luca@z3ntu.xyz \
--cc=Max.Merchel@tq-group.com \
--cc=daniel@0x0f.com \
--cc=devicetree@vger.kernel.org \
--cc=fanghao11@huawei.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=petr.vorel@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=virgule@jeanthomas.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).