linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jordan Hand <jorhand@linux.microsoft.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
	linux-doc@vger.kernel.org
Cc: tweek@google.com, matthewgarrett@google.com,
	Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH] tpm: Document UEFI event log quirks
Date: Sun, 7 Jul 2019 21:10:48 -0700	[thread overview]
Message-ID: <33ff21e2-1e27-cc85-0ea3-5127cb2598ba@linux.microsoft.com> (raw)
In-Reply-To: <fcf497b7aa95cd6915986bc4581f10814c4d5341.camel@linux.intel.com>

On 7/5/19 3:26 AM, Jarkko Sakkinen wrote:
> On Wed, 2019-07-03 at 10:08 -0700, Jordan Hand wrote:
>>> +This introduces another problem: nothing guarantees that it is not
>>> +called before the stub gets to run. Thus, it needs to copy the final
>>> +events table preboot size to the custom configuration table so that
>>> +kernel offset it later on.
>>
>> This doesn't really explain what the size will be used for. Matthew's
>> patch description for "tpm: Don't duplicate events from the final event
>> log in the TCG2 log" outlines this well. You could maybe word it
>> differently but I think the information is necessary:
>>
>> "We can avoid this problem by looking at the size of the Final Event Log
>> just before we call ExitBootServices() and exporting this to the main
>> kernel. The kernel can then skip over all events that occured before
>> ExitBootServices() and only append events that were not also logged to
>> the main log."
> 
> Not exactly sure what is missing from my paragraph. The way I see it has
> more information as it states what is used at as the vessel for
> exportation (the custom configuration table).
> 
> Maybe something like:
> 
> "Thus, it nees to save the final events table size at the time to the
> custom configuration table so that the TPM driver can later on skip the
> events generated during the preboot time."
> 
Yes, that sounds more clear to me.

Thanks,
Jordan

  reply	other threads:[~2019-07-08  4:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-03 16:11 [PATCH] tpm: Document UEFI event log quirks Jarkko Sakkinen
2019-07-03 16:45 ` Randy Dunlap
2019-07-05 10:15   ` Jarkko Sakkinen
2019-07-07 19:33     ` Randy Dunlap
2019-07-08 15:25       ` Jarkko Sakkinen
2019-07-03 17:08 ` Jordan Hand
2019-07-05 10:26   ` Jarkko Sakkinen
2019-07-08  4:10     ` Jordan Hand [this message]
2019-07-08 15:27       ` Jarkko Sakkinen
2019-07-05 10:11 ` Jarkko Sakkinen
2019-07-08 20:43 ` Matthew Garrett
2019-07-12 12:41   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33ff21e2-1e27-cc85-0ea3-5127cb2598ba@linux.microsoft.com \
    --to=jorhand@linux.microsoft.com \
    --cc=corbet@lwn.net \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthewgarrett@google.com \
    --cc=tweek@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).