From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-doc@vger.kernel.org
Cc: tweek@google.com, matthewgarrett@google.com,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH] tpm: Document UEFI event log quirks
Date: Mon, 08 Jul 2019 18:25:38 +0300 [thread overview]
Message-ID: <846cacae8cede764a2e84f628f539d94582fdbe0.camel@linux.intel.com> (raw)
In-Reply-To: <ec274596-6bc8-07a0-d09b-1d191646c5cd@infradead.org>
On Sun, 2019-07-07 at 12:33 -0700, Randy Dunlap wrote:
> On 7/5/19 3:15 AM, Jarkko Sakkinen wrote:
> > On Wed, 2019-07-03 at 09:45 -0700, Randy Dunlap wrote:
> > > > +This introduces another problem: nothing guarantees that it is not
> > > > +called before the stub gets to run. Thus, it needs to copy the final
> > > > +events table preboot size to the custom configuration table so that
> > > > +kernel offset it later on.
>
> (so that)
> the kernel can use that final table preboot size as an events table
> offset later on.
>
> > > ? kernel can offset it later on.
> >
> > EFI stub calculates the total size of the events in the final events
> > table at the time.
> >
> > Later on, TPM driver uses this offset to copy only the events that
> > were actually generated after ExitBootServices():
> >
> > /*
> > * Copy any of the final events log that didn't also end up in the
> > * main log. Events can be logged in both if events are generated
> > * between GetEventLog() and ExitBootServices().
> > */
> > memcpy((void *)log->bios_event_log + log_size,
> > final_tbl->events + log_tbl->final_events_preboot_size,
> > efi_tpm_final_log_size);
> >
> > What would be a better way to describe this?
>
> Yeah, I think I see what it's doing, how it's using that.
> See above.
>
> OK?
Your propsal looks legit, thank you. I'll send an update that
tries to address yours and Jordan's feedback.
/Jarkko
next prev parent reply other threads:[~2019-07-08 15:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 16:11 [PATCH] tpm: Document UEFI event log quirks Jarkko Sakkinen
2019-07-03 16:45 ` Randy Dunlap
2019-07-05 10:15 ` Jarkko Sakkinen
2019-07-07 19:33 ` Randy Dunlap
2019-07-08 15:25 ` Jarkko Sakkinen [this message]
2019-07-03 17:08 ` Jordan Hand
2019-07-05 10:26 ` Jarkko Sakkinen
2019-07-08 4:10 ` Jordan Hand
2019-07-08 15:27 ` Jarkko Sakkinen
2019-07-05 10:11 ` Jarkko Sakkinen
2019-07-08 20:43 ` Matthew Garrett
2019-07-12 12:41 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=846cacae8cede764a2e84f628f539d94582fdbe0.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthewgarrett@google.com \
--cc=rdunlap@infradead.org \
--cc=tweek@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).