From: "Daniel Xu" <dxu@dxuuu.xyz>
To: "Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
"Andrii Nakryiko" <andriin@fb.com>,
peterz@infradead.org, mingo@redhat.com, acme@kernel.org
Cc: ast@fb.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 bpf-next 0/4] tracing/probe: Add PERF_EVENT_IOC_QUERY_PROBE
Date: Fri, 09 Aug 2019 14:50:47 -0700 [thread overview]
Message-ID: <3429be0c-1a10-452e-a566-bf02db72f5ba@www.fastmail.com> (raw)
In-Reply-To: <20190809214642.12078-1-dxu@dxuuu.xyz>
On Fri, Aug 9, 2019, at 2:47 PM, Daniel Xu wrote:
> It's useful to know [uk]probe's nmissed and nhit stats. For example with
> tracing tools, it's important to know when events may have been lost.
> debugfs currently exposes a control file to get this information, but
> it is not compatible with probes registered with the perf API.
>
> While bpf programs may be able to manually count nhit, there is no way
> to gather nmissed. In other words, it is currently not possible to
> retrieve information about FD-based probes.
>
> This patch adds a new ioctl that lets users query nmissed (as well as
> nhit for completeness). We currently only add support for [uk]probes
> but leave the possibility open for other probes like tracepoint.
>
> v1 -> v2:
> - More descriptive cover letter
> - Make API more generic and support uprobes as well
> - Use casters/getters for libbpf instead of single getter
> - Fix typos
> - Remove size field from ioctl struct
> - Split out libbpf.h sync to tools dir to separate commit
>
> Daniel Xu (4):
> tracing/probe: Add PERF_EVENT_IOC_QUERY_PROBE ioctl
> libbpf: Add helpers to extract perf fd from bpf_link
> tracing/probe: Sync perf_event.h to tools
> tracing/probe: Add self test for PERF_EVENT_IOC_QUERY_PROBE
>
> include/linux/trace_events.h | 12 +++
> include/uapi/linux/perf_event.h | 19 ++++
> kernel/events/core.c | 20 ++++
> kernel/trace/trace_kprobe.c | 23 ++++
> kernel/trace/trace_uprobe.c | 23 ++++
> tools/include/uapi/linux/perf_event.h | 19 ++++
> tools/lib/bpf/libbpf.c | 19 ++++
> tools/lib/bpf/libbpf.h | 8 ++
> tools/lib/bpf/libbpf.map | 6 ++
> .../selftests/bpf/prog_tests/attach_probe.c | 102 ++++++++++++++++++
> 10 files changed, 251 insertions(+)
>
> --
> 2.20.1
>
>
CC PeterZ, whose email I misspelled. Apologies.
Daniel
prev parent reply other threads:[~2019-08-09 21:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 21:46 [PATCH v2 bpf-next 0/4] tracing/probe: Add PERF_EVENT_IOC_QUERY_PROBE Daniel Xu
2019-08-09 21:46 ` [PATCH v2 bpf-next 1/4] tracing/probe: Add PERF_EVENT_IOC_QUERY_PROBE ioctl Daniel Xu
2019-08-12 15:56 ` Andrii Nakryiko
2019-08-13 0:38 ` Daniel Xu
2019-08-13 19:48 ` Andrii Nakryiko
2019-08-13 21:47 ` Song Liu
2019-08-13 23:07 ` Daniel Xu
2019-08-09 21:46 ` [PATCH v2 bpf-next 2/4] libbpf: Add helpers to extract perf fd from bpf_link Daniel Xu
2019-08-12 16:02 ` Andrii Nakryiko
2019-08-09 21:46 ` [PATCH v2 bpf-next 3/4] tracing/probe: Sync perf_event.h to tools Daniel Xu
2019-08-09 21:46 ` [PATCH v2 bpf-next 4/4] tracing/probe: Add self test for PERF_EVENT_IOC_QUERY_PROBE Daniel Xu
2019-08-12 17:46 ` Andrii Nakryiko
2019-08-09 21:50 ` Daniel Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3429be0c-1a10-452e-a566-bf02db72f5ba@www.fastmail.com \
--to=dxu@dxuuu.xyz \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).