* [PATCH v4] platform/x86: touchscreen_dmi: Add info for the ONDA V891W Dual OS tablet
@ 2018-06-17 23:58 youling257
2018-06-18 8:43 ` Hans de Goede
0 siblings, 1 reply; 6+ messages in thread
From: youling257 @ 2018-06-17 23:58 UTC (permalink / raw)
To: linux-kernel
Cc: platform-driver-x86, linux-input, andy, dvhart, hdegoede, youling257
Add touchscreen info for the ONDA V891W Dual OS tablet
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: youling257 <youling257@gmail.com>
---
drivers/platform/x86/touchscreen_dmi.c | 27 ++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
index 6284946cb0d1..2ad9327c8c0f 100644
--- a/drivers/platform/x86/touchscreen_dmi.c
+++ b/drivers/platform/x86/touchscreen_dmi.c
@@ -221,6 +221,24 @@ static const struct ts_dmi_data onda_v891w_v1_data = {
.properties = onda_v891w_v1_props,
};
+static const struct property_entry onda_v891w_v3_props[] = {
+ PROPERTY_ENTRY_U32("touchscreen-min-x", 35),
+ PROPERTY_ENTRY_U32("touchscreen-min-y", 15),
+ PROPERTY_ENTRY_U32("touchscreen-size-x", 1625),
+ PROPERTY_ENTRY_U32("touchscreen-size-y", 1135),
+ PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
+ PROPERTY_ENTRY_STRING("firmware-name",
+ "gsl3676-onda-v891w-v3.fw"),
+ PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+ PROPERTY_ENTRY_BOOL("silead,home-button"),
+ { }
+};
+
+static const struct ts_dmi_data onda_v891w_v3_data = {
+ .acpi_name = "MSSL1680:00",
+ .properties = onda_v891w_v3_props,
+};
+
static const struct property_entry pipo_w2s_props[] = {
PROPERTY_ENTRY_U32("touchscreen-size-x", 1660),
PROPERTY_ENTRY_U32("touchscreen-size-y", 880),
@@ -481,6 +499,15 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
DMI_EXACT_MATCH(DMI_BIOS_VERSION, "ONDA.W89EBBN08"),
},
},
+ {
+ /* ONDA V891w Dual OS P891DCF2V1A01274 64GB */
+ .driver_data = (void *)&onda_v891w_v3_data,
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Insyde"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "ONDA Tablet"),
+ DMI_MATCH(DMI_BIOS_VERSION, "ONDA.D890HBBNR0A"),
+ },
+ },
{
/* Pipo W2S */
.driver_data = (void *)&pipo_w2s_data,
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v4] platform/x86: touchscreen_dmi: Add info for the ONDA V891W Dual OS tablet
2018-06-17 23:58 [PATCH v4] platform/x86: touchscreen_dmi: Add info for the ONDA V891W Dual OS tablet youling257
@ 2018-06-18 8:43 ` Hans de Goede
2018-06-18 12:54 ` Hans de Goede
0 siblings, 1 reply; 6+ messages in thread
From: Hans de Goede @ 2018-06-18 8:43 UTC (permalink / raw)
To: youling257, linux-kernel; +Cc: platform-driver-x86, linux-input, andy, dvhart
Hi,
On 18-06-18 01:58, youling257 wrote:
> Add touchscreen info for the ONDA V891W Dual OS tablet
Nitpick: still missing a period '.' at the end, this should be:
Add touchscreen info for the ONDA V891W Dual OS tablet.
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: youling257 <youling257@gmail.com>
As Andy indicated you need to use your real name when submitting
kernel patches, not an internet alias (or a nick).
So you need to re-submit this with something like this:
Signed-off-by: FirstName LastName <youling257@gmail.com>
Regards,
Hans
> ---
> drivers/platform/x86/touchscreen_dmi.c | 27 ++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> index 6284946cb0d1..2ad9327c8c0f 100644
> --- a/drivers/platform/x86/touchscreen_dmi.c
> +++ b/drivers/platform/x86/touchscreen_dmi.c
> @@ -221,6 +221,24 @@ static const struct ts_dmi_data onda_v891w_v1_data = {
> .properties = onda_v891w_v1_props,
> };
>
> +static const struct property_entry onda_v891w_v3_props[] = {
> + PROPERTY_ENTRY_U32("touchscreen-min-x", 35),
> + PROPERTY_ENTRY_U32("touchscreen-min-y", 15),
> + PROPERTY_ENTRY_U32("touchscreen-size-x", 1625),
> + PROPERTY_ENTRY_U32("touchscreen-size-y", 1135),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
> + PROPERTY_ENTRY_STRING("firmware-name",
> + "gsl3676-onda-v891w-v3.fw"),
> + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> + PROPERTY_ENTRY_BOOL("silead,home-button"),
> + { }
> +};
> +
> +static const struct ts_dmi_data onda_v891w_v3_data = {
> + .acpi_name = "MSSL1680:00",
> + .properties = onda_v891w_v3_props,
> +};
> +
> static const struct property_entry pipo_w2s_props[] = {
> PROPERTY_ENTRY_U32("touchscreen-size-x", 1660),
> PROPERTY_ENTRY_U32("touchscreen-size-y", 880),
> @@ -481,6 +499,15 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
> DMI_EXACT_MATCH(DMI_BIOS_VERSION, "ONDA.W89EBBN08"),
> },
> },
> + {
> + /* ONDA V891w Dual OS P891DCF2V1A01274 64GB */
> + .driver_data = (void *)&onda_v891w_v3_data,
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Insyde"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "ONDA Tablet"),
> + DMI_MATCH(DMI_BIOS_VERSION, "ONDA.D890HBBNR0A"),
> + },
> + },
> {
> /* Pipo W2S */
> .driver_data = (void *)&pipo_w2s_data,
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v4] platform/x86: touchscreen_dmi: Add info for the ONDA V891W Dual OS tablet
2018-06-18 8:43 ` Hans de Goede
@ 2018-06-18 12:54 ` Hans de Goede
2018-06-18 13:59 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Hans de Goede @ 2018-06-18 12:54 UTC (permalink / raw)
To: youling257, linux-kernel; +Cc: platform-driver-x86, linux-input, andy, dvhart
Hi,
On 18-06-18 10:43, Hans de Goede wrote:
> Hi,
>
> On 18-06-18 01:58, youling257 wrote:
>> Add touchscreen info for the ONDA V891W Dual OS tablet
>
> Nitpick: still missing a period '.' at the end, this should be:
>
> Add touchscreen info for the ONDA V891W Dual OS tablet.
>
>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>> Signed-off-by: youling257 <youling257@gmail.com>
>
> As Andy indicated you need to use your real name when submitting
> kernel patches, not an internet alias (or a nick).
>
> So you need to re-submit this with something like this:
>
> Signed-off-by: FirstName LastName <youling257@gmail.com>
youling has indicated to me (off-list) that he does not
want to use his real name.
He has already provided me with the touchscreen details
and dmi strings for this tablet a while ago and I had
writing the exact same quirk on my TODO list already.
As such I've no doubt that he created this patch and
has the rights to Submit it under the GPL license.
So I'm going to resubmit this with his S-o-b removed
and replaced with mine. Where the intent of my
S-o-b is to certify point c. of the certificate
of origin, quoting from:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
"c. The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it."
This seems better then me re-creating the exact
same patch from scratch.
Regards,
Hans
>> ---
>> drivers/platform/x86/touchscreen_dmi.c | 27 ++++++++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>>
>> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
>> index 6284946cb0d1..2ad9327c8c0f 100644
>> --- a/drivers/platform/x86/touchscreen_dmi.c
>> +++ b/drivers/platform/x86/touchscreen_dmi.c
>> @@ -221,6 +221,24 @@ static const struct ts_dmi_data onda_v891w_v1_data = {
>> .properties = onda_v891w_v1_props,
>> };
>> +static const struct property_entry onda_v891w_v3_props[] = {
>> + PROPERTY_ENTRY_U32("touchscreen-min-x", 35),
>> + PROPERTY_ENTRY_U32("touchscreen-min-y", 15),
>> + PROPERTY_ENTRY_U32("touchscreen-size-x", 1625),
>> + PROPERTY_ENTRY_U32("touchscreen-size-y", 1135),
>> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
>> + PROPERTY_ENTRY_STRING("firmware-name",
>> + "gsl3676-onda-v891w-v3.fw"),
>> + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
>> + PROPERTY_ENTRY_BOOL("silead,home-button"),
>> + { }
>> +};
>> +
>> +static const struct ts_dmi_data onda_v891w_v3_data = {
>> + .acpi_name = "MSSL1680:00",
>> + .properties = onda_v891w_v3_props,
>> +};
>> +
>> static const struct property_entry pipo_w2s_props[] = {
>> PROPERTY_ENTRY_U32("touchscreen-size-x", 1660),
>> PROPERTY_ENTRY_U32("touchscreen-size-y", 880),
>> @@ -481,6 +499,15 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
>> DMI_EXACT_MATCH(DMI_BIOS_VERSION, "ONDA.W89EBBN08"),
>> },
>> },
>> + {
>> + /* ONDA V891w Dual OS P891DCF2V1A01274 64GB */
>> + .driver_data = (void *)&onda_v891w_v3_data,
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "Insyde"),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "ONDA Tablet"),
>> + DMI_MATCH(DMI_BIOS_VERSION, "ONDA.D890HBBNR0A"),
>> + },
>> + },
>> {
>> /* Pipo W2S */
>> .driver_data = (void *)&pipo_w2s_data,
>>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v4] platform/x86: touchscreen_dmi: Add info for the ONDA V891W Dual OS tablet
2018-06-18 12:54 ` Hans de Goede
@ 2018-06-18 13:59 ` Andy Shevchenko
2018-06-18 22:05 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2018-06-18 13:59 UTC (permalink / raw)
To: Hans de Goede, Stephen Rothwell
Cc: youling257, Linux Kernel Mailing List, Platform Driver,
linux-input, Andy Shevchenko, Darren Hart
+Cc: Stephen
On Mon, Jun 18, 2018 at 3:54 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> Hi,
>
> On 18-06-18 10:43, Hans de Goede wrote:
>>
>> Hi,
>>
>> On 18-06-18 01:58, youling257 wrote:
>>>
>>> Add touchscreen info for the ONDA V891W Dual OS tablet
>>
>>
>> Nitpick: still missing a period '.' at the end, this should be:
>>
>> Add touchscreen info for the ONDA V891W Dual OS tablet.
>>
>>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>>> Signed-off-by: youling257 <youling257@gmail.com>
>>
>>
>> As Andy indicated you need to use your real name when submitting
>> kernel patches, not an internet alias (or a nick).
>>
>> So you need to re-submit this with something like this:
>>
>> Signed-off-by: FirstName LastName <youling257@gmail.com>
>
>
> youling has indicated to me (off-list) that he does not
> want to use his real name.
>
> He has already provided me with the touchscreen details
> and dmi strings for this tablet a while ago and I had
> writing the exact same quirk on my TODO list already.
>
> As such I've no doubt that he created this patch and
> has the rights to Submit it under the GPL license.
>
> So I'm going to resubmit this with his S-o-b removed
> and replaced with mine. Where the intent of my
> S-o-b is to certify point c. of the certificate
> of origin, quoting from:
>
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
>
> "c. The contribution was provided directly to me by some other person who
> certified (a), (b) or (c) and I have not modified it."
>
> This seems better then me re-creating the exact
> same patch from scratch.
I guess this will not pass checks Stephen has.
So, Stephen, how should we proceed?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] platform/x86: touchscreen_dmi: Add info for the ONDA V891W Dual OS tablet
2018-06-18 13:59 ` Andy Shevchenko
@ 2018-06-18 22:05 ` Stephen Rothwell
2018-07-02 12:22 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2018-06-18 22:05 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Hans de Goede, youling257, Linux Kernel Mailing List,
Platform Driver, linux-input, Andy Shevchenko, Darren Hart
[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]
Hi Andy,
On Mon, 18 Jun 2018 16:59:30 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>
> > youling has indicated to me (off-list) that he does not
> > want to use his real name.
> >
> > He has already provided me with the touchscreen details
> > and dmi strings for this tablet a while ago and I had
> > writing the exact same quirk on my TODO list already.
> >
> > As such I've no doubt that he created this patch and
> > has the rights to Submit it under the GPL license.
> >
> > So I'm going to resubmit this with his S-o-b removed
> > and replaced with mine. Where the intent of my
> > S-o-b is to certify point c. of the certificate
> > of origin, quoting from:
> >
> > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
> >
> > "c. The contribution was provided directly to me by some other person who
> > certified (a), (b) or (c) and I have not modified it."
> >
> > This seems better then me re-creating the exact
> > same patch from scratch.
>
> I guess this will not pass checks Stephen has.
> So, Stephen, how should we proceed?
That's fine. I amy report it (If I forget this email), but you can
just ignore the report. My scripted checks obviously can't take this
case into account.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] platform/x86: touchscreen_dmi: Add info for the ONDA V891W Dual OS tablet
2018-06-18 22:05 ` Stephen Rothwell
@ 2018-07-02 12:22 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2018-07-02 12:22 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Hans de Goede, youling257, Linux Kernel Mailing List,
Platform Driver, linux-input, Andy Shevchenko, Darren Hart
On Tue, Jun 19, 2018 at 1:05 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Mon, 18 Jun 2018 16:59:30 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>> > youling has indicated to me (off-list) that he does not
>> > want to use his real name.
>> >
>> > He has already provided me with the touchscreen details
>> > and dmi strings for this tablet a while ago and I had
>> > writing the exact same quirk on my TODO list already.
>> >
>> > As such I've no doubt that he created this patch and
>> > has the rights to Submit it under the GPL license.
>> >
>> > So I'm going to resubmit this with his S-o-b removed
>> > and replaced with mine. Where the intent of my
>> > S-o-b is to certify point c. of the certificate
>> > of origin, quoting from:
>> >
>> > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
>> >
>> > "c. The contribution was provided directly to me by some other person who
>> > certified (a), (b) or (c) and I have not modified it."
>> >
>> > This seems better then me re-creating the exact
>> > same patch from scratch.
>>
>> I guess this will not pass checks Stephen has.
>> So, Stephen, how should we proceed?
>
> That's fine. I amy report it (If I forget this email), but you can
> just ignore the report. My scripted checks obviously can't take this
> case into account.
Thanks!
I have pushed to my review and testing queue as is.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-02 12:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-17 23:58 [PATCH v4] platform/x86: touchscreen_dmi: Add info for the ONDA V891W Dual OS tablet youling257
2018-06-18 8:43 ` Hans de Goede
2018-06-18 12:54 ` Hans de Goede
2018-06-18 13:59 ` Andy Shevchenko
2018-06-18 22:05 ` Stephen Rothwell
2018-07-02 12:22 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).