linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] HID: quirks: Add USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for BYD zhaoxin notebook
@ 2020-09-04  1:48 Penghao
  2020-09-04  2:50 ` Lars Melin
  0 siblings, 1 reply; 5+ messages in thread
From: Penghao @ 2020-09-04  1:48 UTC (permalink / raw)
  To: gregkh
  Cc: johan, hdegoede, dlaz, stern, kerneldev, penghao, jonathan,
	tomasz, linux-usb, linux-kernel

Add a USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for the BYD zhaoxin notebook.
This notebook come with usb touchpad. And we would like to disable touchpad
wakeup on this notebook by default.

Signed-off-by: Penghao <penghao@uniontech.com>
---
 drivers/usb/core/quirks.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 7c1198f80c23..5fa3f2416967 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -387,6 +387,10 @@ static const struct usb_device_id usb_quirk_list[] = {
 	{ USB_DEVICE(0x0b05, 0x17e0), .driver_info =
 			USB_QUIRK_IGNORE_REMOTE_WAKEUP },
 
+	/* SONiX USB DEVICE Touchpad */
+	{ USB_DEVICE(0x0c45, 0x7056), .driver_info =
+			USB_QUIRK_IGNORE_REMOTE_WAKEUP },
+
 	/* Realtek hub in Dell WD19 (Type-C) */
 	{ USB_DEVICE(0x0bda, 0x0487), .driver_info = USB_QUIRK_NO_LPM },
 
-- 
2.11.0




^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] HID: quirks: Add USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for BYD zhaoxin notebook
  2020-09-04  1:48 [PATCH] HID: quirks: Add USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for BYD zhaoxin notebook Penghao
@ 2020-09-04  2:50 ` Lars Melin
  0 siblings, 0 replies; 5+ messages in thread
From: Lars Melin @ 2020-09-04  2:50 UTC (permalink / raw)
  To: Penghao, gregkh
  Cc: johan, hdegoede, dlaz, stern, kerneldev, jonathan, tomasz,
	linux-usb, linux-kernel

On 9/4/2020 08:48, Penghao wrote:

> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -387,6 +387,10 @@ static const struct usb_device_id usb_quirk_list[] = {
>   	{ USB_DEVICE(0x0b05, 0x17e0), .driver_info =
>   			USB_QUIRK_IGNORE_REMOTE_WAKEUP },
>   
> +	/* SONiX USB DEVICE Touchpad */
> +	{ USB_DEVICE(0x0c45, 0x7056), .driver_info =
> +			USB_QUIRK_IGNORE_REMOTE_WAKEUP },
> +
>   	/* Realtek hub in Dell WD19 (Type-C) */
>   	{ USB_DEVICE(0x0bda, 0x0487), .driver_info = USB_QUIRK_NO_LPM },
>   
> 

This list was sorted in a beautiful ascending order of vid, pid before 
you entered your quirk..

rgds
Lars

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] HID: quirks: Add USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for BYD zhaoxin notebook
  2020-09-03 10:03 Penghao
  2020-09-03 10:32 ` Hans de Goede
@ 2020-09-03 15:29 ` Alan Stern
  1 sibling, 0 replies; 5+ messages in thread
From: Alan Stern @ 2020-09-03 15:29 UTC (permalink / raw)
  To: Penghao
  Cc: gregkh, johan, hdegoede, dlaz, kerneldev, jonathan, tomasz,
	linux-usb, linux-kernel

On Thu, Sep 03, 2020 at 06:03:26PM +0800, Penghao wrote:
> Add a USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for the BYD zhaoxin notebook.
> This notebook come with usb touchpad. And we would like to disable touchpad
> wakeup on this notebook by default.
> 
> Signed-off-by: Penghao <penghao@uniontech.com>
> ---
>  drivers/usb/core/quirks.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 7c1198f80c23..5fa3f2416967 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -387,6 +387,10 @@ static const struct usb_device_id usb_quirk_list[] = {
>  	{ USB_DEVICE(0x0b05, 0x17e0), .driver_info =
>  			USB_QUIRK_IGNORE_REMOTE_WAKEUP },
>  
> +	/* SONiX USB DEVICE Touchpad */
> +	{ USB_DEVICE(0x0c45, 0x7056), .driver_info =
> +			USB_QUIRK_IGNORE_REMOTE_WAKEUP },
> +
>  	/* Realtek hub in Dell WD19 (Type-C) */
>  	{ USB_DEVICE(0x0bda, 0x0487), .driver_info = USB_QUIRK_NO_LPM },

Please follow the instructions at the start of the file about keeping 
the entries sorted by vendor ID and product ID.

Alan Stern

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] HID: quirks: Add USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for BYD zhaoxin notebook
  2020-09-03 10:03 Penghao
@ 2020-09-03 10:32 ` Hans de Goede
  2020-09-03 15:29 ` Alan Stern
  1 sibling, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2020-09-03 10:32 UTC (permalink / raw)
  To: Penghao, gregkh
  Cc: johan, dlaz, stern, kerneldev, jonathan, tomasz, linux-usb, linux-kernel

Hi,

On 9/3/20 12:03 PM, Penghao wrote:
> Add a USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for the BYD zhaoxin notebook.
> This notebook come with usb touchpad. And we would like to disable touchpad
> wakeup on this notebook by default.

2 questions:

1. Why do you want to enable remote wakeup by default ?
2. Is this a HID multi-touch touchpad?

Regards,

Hans


> 
> Signed-off-by: Penghao <penghao@uniontech.com>
> ---
>   drivers/usb/core/quirks.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 7c1198f80c23..5fa3f2416967 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -387,6 +387,10 @@ static const struct usb_device_id usb_quirk_list[] = {
>   	{ USB_DEVICE(0x0b05, 0x17e0), .driver_info =
>   			USB_QUIRK_IGNORE_REMOTE_WAKEUP },
>   
> +	/* SONiX USB DEVICE Touchpad */
> +	{ USB_DEVICE(0x0c45, 0x7056), .driver_info =
> +			USB_QUIRK_IGNORE_REMOTE_WAKEUP },
> +
>   	/* Realtek hub in Dell WD19 (Type-C) */
>   	{ USB_DEVICE(0x0bda, 0x0487), .driver_info = USB_QUIRK_NO_LPM },
>   
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] HID: quirks: Add USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for BYD zhaoxin notebook
@ 2020-09-03 10:03 Penghao
  2020-09-03 10:32 ` Hans de Goede
  2020-09-03 15:29 ` Alan Stern
  0 siblings, 2 replies; 5+ messages in thread
From: Penghao @ 2020-09-03 10:03 UTC (permalink / raw)
  To: gregkh
  Cc: johan, hdegoede, dlaz, stern, kerneldev, penghao, jonathan,
	tomasz, linux-usb, linux-kernel

Add a USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for the BYD zhaoxin notebook.
This notebook come with usb touchpad. And we would like to disable touchpad
wakeup on this notebook by default.

Signed-off-by: Penghao <penghao@uniontech.com>
---
 drivers/usb/core/quirks.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 7c1198f80c23..5fa3f2416967 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -387,6 +387,10 @@ static const struct usb_device_id usb_quirk_list[] = {
 	{ USB_DEVICE(0x0b05, 0x17e0), .driver_info =
 			USB_QUIRK_IGNORE_REMOTE_WAKEUP },
 
+	/* SONiX USB DEVICE Touchpad */
+	{ USB_DEVICE(0x0c45, 0x7056), .driver_info =
+			USB_QUIRK_IGNORE_REMOTE_WAKEUP },
+
 	/* Realtek hub in Dell WD19 (Type-C) */
 	{ USB_DEVICE(0x0bda, 0x0487), .driver_info = USB_QUIRK_NO_LPM },
 
-- 
2.11.0




^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-09-04  2:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-04  1:48 [PATCH] HID: quirks: Add USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for BYD zhaoxin notebook Penghao
2020-09-04  2:50 ` Lars Melin
  -- strict thread matches above, loose matches on Subject: below --
2020-09-03 10:03 Penghao
2020-09-03 10:32 ` Hans de Goede
2020-09-03 15:29 ` Alan Stern

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).