* [PATCH] fs/ubifs: remove useless parameter of lpt_heap_replace
@ 2018-02-28 2:22 Jiang Biao
2018-03-01 16:23 ` Richard Weinberger
0 siblings, 1 reply; 2+ messages in thread
From: Jiang Biao @ 2018-02-28 2:22 UTC (permalink / raw)
To: richard, dedekind1, adrian.hunter
Cc: linux-mtd, linux-kernel, jiang.biao2, zhong.weidong
The parameter *old_lprops* is never used in lpt_heap_replace(),
remove it to avoid compile warning.
Signed-off-by: Jiang Biao <jiang.biao2@zte.com.cn>
---
fs/ubifs/lprops.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/ubifs/lprops.c b/fs/ubifs/lprops.c
index 6c3a1ab..f5a4684 100644
--- a/fs/ubifs/lprops.c
+++ b/fs/ubifs/lprops.c
@@ -244,7 +244,6 @@ static void remove_from_lpt_heap(struct ubifs_info *c,
/**
* lpt_heap_replace - replace lprops in a category heap.
* @c: UBIFS file-system description object
- * @old_lprops: LEB properties to replace
* @new_lprops: LEB properties with which to replace
* @cat: LEB category
*
@@ -254,7 +253,6 @@ static void remove_from_lpt_heap(struct ubifs_info *c,
* lprops. This function does that.
*/
static void lpt_heap_replace(struct ubifs_info *c,
- struct ubifs_lprops *old_lprops,
struct ubifs_lprops *new_lprops, int cat)
{
struct ubifs_lpt_heap *heap;
@@ -362,7 +360,7 @@ void ubifs_replace_cat(struct ubifs_info *c, struct ubifs_lprops *old_lprops,
case LPROPS_DIRTY:
case LPROPS_DIRTY_IDX:
case LPROPS_FREE:
- lpt_heap_replace(c, old_lprops, new_lprops, cat);
+ lpt_heap_replace(c, new_lprops, cat);
break;
case LPROPS_UNCAT:
case LPROPS_EMPTY:
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs/ubifs: remove useless parameter of lpt_heap_replace
2018-02-28 2:22 [PATCH] fs/ubifs: remove useless parameter of lpt_heap_replace Jiang Biao
@ 2018-03-01 16:23 ` Richard Weinberger
0 siblings, 0 replies; 2+ messages in thread
From: Richard Weinberger @ 2018-03-01 16:23 UTC (permalink / raw)
To: Jiang Biao
Cc: dedekind1, adrian.hunter, linux-mtd, linux-kernel, zhong.weidong
Am Mittwoch, 28. Februar 2018, 03:22:37 CET schrieb Jiang Biao:
> The parameter *old_lprops* is never used in lpt_heap_replace(),
> remove it to avoid compile warning.
Makes sense. But what compiler warning do you get?
Thanks,
//richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-01 16:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-28 2:22 [PATCH] fs/ubifs: remove useless parameter of lpt_heap_replace Jiang Biao
2018-03-01 16:23 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).