* Linux-next 20190218: am57xx-evm: mmc1: ADMA error
@ 2019-02-18 13:27 Naresh Kamboju
2019-02-19 13:08 ` Faiz Abbas
0 siblings, 1 reply; 10+ messages in thread
From: Naresh Kamboju @ 2019-02-18 13:27 UTC (permalink / raw)
To: open list, devicetree, linux-mmc, linux-omap
Cc: t-kristo, nm, faiz_abbas, Mark Rutland, robh+dt
Do you see this error on am57xx-evm running Linux next 20190218 ?
I have tested on multiple devices and found this error.
Please find the full boot log [1].
Am i missing any pre required configs [2] ?
[ 5.620263] mmc1: ADMA error
[ 5.623266] mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
[ 5.629740] mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
[ 5.636215] mmc1: sdhci: Blk size: 0x00000200 | Blk cnt: 0x0000ffff
[ 5.642690] mmc1: sdhci: Argument: 0x002cec70 | Trn mode: 0x00000033
[ 5.649162] mmc1: sdhci: Present: 0x01f00000 | Host ctl: 0x00000010
[ 5.655634] mmc1: sdhci: Power: 0x0000000f | Blk gap: 0x00000000
[ 5.662108] mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
[ 5.668582] mmc1: sdhci: Timeout: 0x0000000c | Int stat: 0x00000000
[ 5.675055] mmc1: sdhci: Int enab: 0x027f000b | Sig enab: 0x027f000b
[ 5.681529] mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
[ 5.688002] mmc1: sdhci: Caps: 0x21e90080 | Caps_1: 0x00000f77
[ 5.694474] mmc1: sdhci: Cmd: 0x0000123a | Max curr: 0x00000000
[ 5.700949] mmc1: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0xffffffef
[ 5.707423] mmc1: sdhci: Resp[2]: 0x0f5903ff | Resp[3]: 0xd04f0132
[ 5.713896] mmc1: sdhci: Host ctl2: 0x00000004
[ 5.718364] mmc1: sdhci: ADMA Err: 0x00000007 | ADMA Ptr: 0xab868218
<>
[ 42.425587] print_req_error: I/O error, dev mmcblk1, sector 4542872 flags 1
[ 42.429013] mmc1: ADMA error
[ 42.432606] EXT4-fs warning (device mmcblk1p9): ext4_end_bio:324:
I/O error 10 writing to inode 35321 (offset 0 size 4096 starting block
567860)
[ 42.435475] mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
[ 42.448543] Buffer I/O error on device mmcblk1p9, logical block 226675
[ 42.454944] mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
[ 42.461528] EXT4-fs warning (device mmcblk1p9): ext4_end_bio:324:
I/O error 10 writing to inode 35322 (offset 0 size 4096 starting block
567861)
[ 42.467960] mmc1: sdhci: Blk size: 0x00000200 | Blk cnt: 0x0000ffff
[ 42.480982] Buffer I/O error on device mmcblk1p9, logical block 226676
[ 42.487427] mmc1: sdhci: Argument: 0x002cae20 | Trn mode: 0x00000033
[ 42.494007] EXT4-fs warning (device mmcblk1p9): ext4_end_bio:324:
I/O error 10 writing to inode 315 (offset 0 size 4096 starting block
567862)
Full boot log,
[1] https://lkft.validation.linaro.org/scheduler/job/610989#L4354
config,
[2] http://snapshots.linaro.org/openembedded/lkft/lkft/rocko/am57xx-evm/lkft/linux-next/467/config
Best regards
Naresh Kamboju
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Linux-next 20190218: am57xx-evm: mmc1: ADMA error
2019-02-18 13:27 Linux-next 20190218: am57xx-evm: mmc1: ADMA error Naresh Kamboju
@ 2019-02-19 13:08 ` Faiz Abbas
2019-02-25 13:16 ` Faiz Abbas
0 siblings, 1 reply; 10+ messages in thread
From: Faiz Abbas @ 2019-02-19 13:08 UTC (permalink / raw)
To: Naresh Kamboju, open list, devicetree, linux-mmc, linux-omap
Cc: t-kristo, nm, Mark Rutland, robh+dt
Hi Naresh,
On 18/02/19 6:57 PM, Naresh Kamboju wrote:
> Do you see this error on am57xx-evm running Linux next 20190218 ?
> I have tested on multiple devices and found this error.
> Please find the full boot log [1].
> Am i missing any pre required configs [2] ?
>
> [ 5.620263] mmc1: ADMA error
> [ 5.623266] mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
> [ 5.629740] mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
> [ 5.636215] mmc1: sdhci: Blk size: 0x00000200 | Blk cnt: 0x0000ffff
> [ 5.642690] mmc1: sdhci: Argument: 0x002cec70 | Trn mode: 0x00000033
> [ 5.649162] mmc1: sdhci: Present: 0x01f00000 | Host ctl: 0x00000010
> [ 5.655634] mmc1: sdhci: Power: 0x0000000f | Blk gap: 0x00000000
> [ 5.662108] mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
> [ 5.668582] mmc1: sdhci: Timeout: 0x0000000c | Int stat: 0x00000000
> [ 5.675055] mmc1: sdhci: Int enab: 0x027f000b | Sig enab: 0x027f000b
> [ 5.681529] mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
> [ 5.688002] mmc1: sdhci: Caps: 0x21e90080 | Caps_1: 0x00000f77
> [ 5.694474] mmc1: sdhci: Cmd: 0x0000123a | Max curr: 0x00000000
> [ 5.700949] mmc1: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0xffffffef
> [ 5.707423] mmc1: sdhci: Resp[2]: 0x0f5903ff | Resp[3]: 0xd04f0132
> [ 5.713896] mmc1: sdhci: Host ctl2: 0x00000004
> [ 5.718364] mmc1: sdhci: ADMA Err: 0x00000007 | ADMA Ptr: 0xab868218
>
I see this as well on my setup. Trying to bisect now. Will keep you posted.
Thanks,
Faiz
> <>
> [ 42.425587] print_req_error: I/O error, dev mmcblk1, sector 4542872 flags 1
> [ 42.429013] mmc1: ADMA error
> [ 42.432606] EXT4-fs warning (device mmcblk1p9): ext4_end_bio:324:
> I/O error 10 writing to inode 35321 (offset 0 size 4096 starting block
> 567860)
> [ 42.435475] mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
> [ 42.448543] Buffer I/O error on device mmcblk1p9, logical block 226675
> [ 42.454944] mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
> [ 42.461528] EXT4-fs warning (device mmcblk1p9): ext4_end_bio:324:
> I/O error 10 writing to inode 35322 (offset 0 size 4096 starting block
> 567861)
> [ 42.467960] mmc1: sdhci: Blk size: 0x00000200 | Blk cnt: 0x0000ffff
> [ 42.480982] Buffer I/O error on device mmcblk1p9, logical block 226676
> [ 42.487427] mmc1: sdhci: Argument: 0x002cae20 | Trn mode: 0x00000033
> [ 42.494007] EXT4-fs warning (device mmcblk1p9): ext4_end_bio:324:
> I/O error 10 writing to inode 315 (offset 0 size 4096 starting block
> 567862)
>
> Full boot log,
> [1] https://lkft.validation.linaro.org/scheduler/job/610989#L4354
> config,
> [2] http://snapshots.linaro.org/openembedded/lkft/lkft/rocko/am57xx-evm/lkft/linux-next/467/config
>
> Best regards
> Naresh Kamboju
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Linux-next 20190218: am57xx-evm: mmc1: ADMA error
2019-02-19 13:08 ` Faiz Abbas
@ 2019-02-25 13:16 ` Faiz Abbas
2019-02-26 1:41 ` Ming Lei
0 siblings, 1 reply; 10+ messages in thread
From: Faiz Abbas @ 2019-02-25 13:16 UTC (permalink / raw)
To: Naresh Kamboju, open list,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-mmc, linux-omap
Cc: t-kristo, nm, Mark Rutland, robh+dt, osandov, ming.lei, Jens Axboe
Hi Naresh,
+ Commit authors.
On 19/02/19 6:38 PM, Faiz Abbas wrote:
> Hi Naresh,
>
> On 18/02/19 6:57 PM, Naresh Kamboju wrote:
>> Do you see this error on am57xx-evm running Linux next 20190218 ?
>> I have tested on multiple devices and found this error.
>> Please find the full boot log [1].
>> Am i missing any pre required configs [2] ?
>>
>> [ 5.620263] mmc1: ADMA error
>> [ 5.623266] mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
>> [ 5.629740] mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
>> [ 5.636215] mmc1: sdhci: Blk size: 0x00000200 | Blk cnt: 0x0000ffff
>> [ 5.642690] mmc1: sdhci: Argument: 0x002cec70 | Trn mode: 0x00000033
>> [ 5.649162] mmc1: sdhci: Present: 0x01f00000 | Host ctl: 0x00000010
>> [ 5.655634] mmc1: sdhci: Power: 0x0000000f | Blk gap: 0x00000000
>> [ 5.662108] mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
>> [ 5.668582] mmc1: sdhci: Timeout: 0x0000000c | Int stat: 0x00000000
>> [ 5.675055] mmc1: sdhci: Int enab: 0x027f000b | Sig enab: 0x027f000b
>> [ 5.681529] mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
>> [ 5.688002] mmc1: sdhci: Caps: 0x21e90080 | Caps_1: 0x00000f77
>> [ 5.694474] mmc1: sdhci: Cmd: 0x0000123a | Max curr: 0x00000000
>> [ 5.700949] mmc1: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0xffffffef
>> [ 5.707423] mmc1: sdhci: Resp[2]: 0x0f5903ff | Resp[3]: 0xd04f0132
>> [ 5.713896] mmc1: sdhci: Host ctl2: 0x00000004
>> [ 5.718364] mmc1: sdhci: ADMA Err: 0x00000007 | ADMA Ptr: 0xab868218
>>
>
> I see this as well on my setup. Trying to bisect now. Will keep you posted.
Reverting the following commit fixes this.
commit 07173c3ec276cbb18dc0e0687d37d310e98a1480
Author: Ming Lei <ming.lei@redhat.com>
Date: Fri Feb 15 19:13:20 2019 +0800
block: enable multipage bvecs
This patch pulls the trigger for multi-page bvecs.
Reviewed-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
>> <>
>> [ 42.425587] print_req_error: I/O error, dev mmcblk1, sector 4542872 flags 1
>> [ 42.429013] mmc1: ADMA error
>> [ 42.432606] EXT4-fs warning (device mmcblk1p9): ext4_end_bio:324:
>> I/O error 10 writing to inode 35321 (offset 0 size 4096 starting block
>> 567860)
>> [ 42.435475] mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
>> [ 42.448543] Buffer I/O error on device mmcblk1p9, logical block 226675
>> [ 42.454944] mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
>> [ 42.461528] EXT4-fs warning (device mmcblk1p9): ext4_end_bio:324:
>> I/O error 10 writing to inode 35322 (offset 0 size 4096 starting block
>> 567861)
>> [ 42.467960] mmc1: sdhci: Blk size: 0x00000200 | Blk cnt: 0x0000ffff
>> [ 42.480982] Buffer I/O error on device mmcblk1p9, logical block 226676
>> [ 42.487427] mmc1: sdhci: Argument: 0x002cae20 | Trn mode: 0x00000033
>> [ 42.494007] EXT4-fs warning (device mmcblk1p9): ext4_end_bio:324:
>> I/O error 10 writing to inode 315 (offset 0 size 4096 starting block
>> 567862)
>>
>> Full boot log,
>> [1] https://lkft.validation.linaro.org/scheduler/job/610989#L4354
>> config,
>> [2] http://snapshots.linaro.org/openembedded/lkft/lkft/rocko/am57xx-evm/lkft/linux-next/467/config
>>
>> Best regards
>> Naresh Kamboju
>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Linux-next 20190218: am57xx-evm: mmc1: ADMA error
2019-02-25 13:16 ` Faiz Abbas
@ 2019-02-26 1:41 ` Ming Lei
2019-02-26 6:50 ` Faiz Abbas
0 siblings, 1 reply; 10+ messages in thread
From: Ming Lei @ 2019-02-26 1:41 UTC (permalink / raw)
To: Faiz Abbas
Cc: Naresh Kamboju, open list,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-mmc, linux-omap, Tero Kristo, nm, Mark Rutland,
Rob Herring, Omar Sandoval, Ming Lei, Jens Axboe
On Mon, Feb 25, 2019 at 9:14 PM Faiz Abbas <faiz_abbas@ti.com> wrote:
>
> Hi Naresh,
>
> + Commit authors.
>
> On 19/02/19 6:38 PM, Faiz Abbas wrote:
> > Hi Naresh,
> >
> > On 18/02/19 6:57 PM, Naresh Kamboju wrote:
> >> Do you see this error on am57xx-evm running Linux next 20190218 ?
> >> I have tested on multiple devices and found this error.
> >> Please find the full boot log [1].
> >> Am i missing any pre required configs [2] ?
> >>
> >> [ 5.620263] mmc1: ADMA error
> >> [ 5.623266] mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
> >> [ 5.629740] mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
> >> [ 5.636215] mmc1: sdhci: Blk size: 0x00000200 | Blk cnt: 0x0000ffff
> >> [ 5.642690] mmc1: sdhci: Argument: 0x002cec70 | Trn mode: 0x00000033
> >> [ 5.649162] mmc1: sdhci: Present: 0x01f00000 | Host ctl: 0x00000010
> >> [ 5.655634] mmc1: sdhci: Power: 0x0000000f | Blk gap: 0x00000000
> >> [ 5.662108] mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
> >> [ 5.668582] mmc1: sdhci: Timeout: 0x0000000c | Int stat: 0x00000000
> >> [ 5.675055] mmc1: sdhci: Int enab: 0x027f000b | Sig enab: 0x027f000b
> >> [ 5.681529] mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
> >> [ 5.688002] mmc1: sdhci: Caps: 0x21e90080 | Caps_1: 0x00000f77
> >> [ 5.694474] mmc1: sdhci: Cmd: 0x0000123a | Max curr: 0x00000000
> >> [ 5.700949] mmc1: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0xffffffef
> >> [ 5.707423] mmc1: sdhci: Resp[2]: 0x0f5903ff | Resp[3]: 0xd04f0132
> >> [ 5.713896] mmc1: sdhci: Host ctl2: 0x00000004
> >> [ 5.718364] mmc1: sdhci: ADMA Err: 0x00000007 | ADMA Ptr: 0xab868218
> >>
> >
> > I see this as well on my setup. Trying to bisect now. Will keep you posted.
>
>
> Reverting the following commit fixes this.
> commit 07173c3ec276cbb18dc0e0687d37d310e98a1480
> Author: Ming Lei <ming.lei@redhat.com>
> Date: Fri Feb 15 19:13:20 2019 +0800
>
> block: enable multipage bvecs
>
> This patch pulls the trigger for multi-page bvecs.
>
> Reviewed-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Hi,
Thanks for your report & bisect.
Could you test the following patch?
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-5.1/block&id=8f4e80da764ec1ca44c83f3e17dbc9bf0209bccc
Or simply run the latest -next?
Thanks,
Ming Lei
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Linux-next 20190218: am57xx-evm: mmc1: ADMA error
2019-02-26 1:41 ` Ming Lei
@ 2019-02-26 6:50 ` Faiz Abbas
2019-02-26 10:06 ` Ming Lei
0 siblings, 1 reply; 10+ messages in thread
From: Faiz Abbas @ 2019-02-26 6:50 UTC (permalink / raw)
To: Ming Lei
Cc: Naresh Kamboju, open list,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-mmc, linux-omap, Tero Kristo, nm, Mark Rutland,
Rob Herring, Omar Sandoval, Ming Lei, Jens Axboe
Hi Ming Lei,
On 26/02/19 7:11 AM, Ming Lei wrote:
> On Mon, Feb 25, 2019 at 9:14 PM Faiz Abbas <faiz_abbas@ti.com> wrote:
>>
>> Hi Naresh,
>>
>> + Commit authors.
>>
>> On 19/02/19 6:38 PM, Faiz Abbas wrote:
>>> Hi Naresh,
>>>
>>> On 18/02/19 6:57 PM, Naresh Kamboju wrote:
>>>> Do you see this error on am57xx-evm running Linux next 20190218 ?
>>>> I have tested on multiple devices and found this error.
>>>> Please find the full boot log [1].
>>>> Am i missing any pre required configs [2] ?
>>>>
>>>> [ 5.620263] mmc1: ADMA error
>>>> [ 5.623266] mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
>>>> [ 5.629740] mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
>>>> [ 5.636215] mmc1: sdhci: Blk size: 0x00000200 | Blk cnt: 0x0000ffff
>>>> [ 5.642690] mmc1: sdhci: Argument: 0x002cec70 | Trn mode: 0x00000033
>>>> [ 5.649162] mmc1: sdhci: Present: 0x01f00000 | Host ctl: 0x00000010
>>>> [ 5.655634] mmc1: sdhci: Power: 0x0000000f | Blk gap: 0x00000000
>>>> [ 5.662108] mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
>>>> [ 5.668582] mmc1: sdhci: Timeout: 0x0000000c | Int stat: 0x00000000
>>>> [ 5.675055] mmc1: sdhci: Int enab: 0x027f000b | Sig enab: 0x027f000b
>>>> [ 5.681529] mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
>>>> [ 5.688002] mmc1: sdhci: Caps: 0x21e90080 | Caps_1: 0x00000f77
>>>> [ 5.694474] mmc1: sdhci: Cmd: 0x0000123a | Max curr: 0x00000000
>>>> [ 5.700949] mmc1: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0xffffffef
>>>> [ 5.707423] mmc1: sdhci: Resp[2]: 0x0f5903ff | Resp[3]: 0xd04f0132
>>>> [ 5.713896] mmc1: sdhci: Host ctl2: 0x00000004
>>>> [ 5.718364] mmc1: sdhci: ADMA Err: 0x00000007 | ADMA Ptr: 0xab868218
>>>>
>>>
>>> I see this as well on my setup. Trying to bisect now. Will keep you posted.
>>
>>
>> Reverting the following commit fixes this.
>> commit 07173c3ec276cbb18dc0e0687d37d310e98a1480
>> Author: Ming Lei <ming.lei@redhat.com>
>> Date: Fri Feb 15 19:13:20 2019 +0800
>>
>> block: enable multipage bvecs
>>
>> This patch pulls the trigger for multi-page bvecs.
>>
>> Reviewed-by: Omar Sandoval <osandov@fb.com>
>> Signed-off-by: Ming Lei <ming.lei@redhat.com>
>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>
> Hi,
>
> Thanks for your report & bisect.
>
> Could you test the following patch?
>
> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-5.1/block&id=8f4e80da764ec1ca44c83f3e17dbc9bf0209bccc
>
> Or simply run the latest -next?
That didn't fix it for me. Still see ADMA error.
[ 13.126186] mmc0: ADMA error
[ 13.129084] mmc0: sdhci: ============ SDHCI REGISTER DUMP ===========
[ 13.135552] mmc0: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
[ 13.142019] mmc0: sdhci: Blk size: 0x00000200 | Blk cnt: 0x00000000
[ 13.148485] mmc0: sdhci: Argument: 0x00000089 | Trn mode: 0x00000033
[ 13.154952] mmc0: sdhci: Present: 0x00000000 | Host ctl: 0x00000012
[ 13.161418] mmc0: sdhci: Power: 0x0000000f | Blk gap: 0x00000000
[ 13.167885] mmc0: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
[ 13.174351] mmc0: sdhci: Timeout: 0x0000000a | Int stat: 0x00000000
[ 13.180817] mmc0: sdhci: Int enab: 0x027f000b | Sig enab: 0x027f000b
[ 13.187282] mmc0: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
[ 13.193748] mmc0: sdhci: Caps: 0x25e90080 | Caps_1: 0x00000f77
[ 13.200215] mmc0: sdhci: Cmd: 0x0000123a | Max curr: 0x00000000
[ 13.206682] mmc0: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0x3b377f80
[ 13.213148] mmc0: sdhci: Resp[2]: 0x5b590000 | Resp[3]: 0x400e0032
[ 13.219613] mmc0: sdhci: Host ctl2: 0x00000000
[ 13.224073] mmc0: sdhci: ADMA Err: 0x00000007 | ADMA Ptr: 0xae857288
[ 13.230538] mmc0: sdhci: ============================================
Full Log:
https://pastebin.ubuntu.com/p/4yGqgJCGZQ/
Thanks,
Faiz
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Linux-next 20190218: am57xx-evm: mmc1: ADMA error
2019-02-26 6:50 ` Faiz Abbas
@ 2019-02-26 10:06 ` Ming Lei
2019-02-26 11:31 ` Ming Lei
2019-02-26 11:34 ` Faiz Abbas
0 siblings, 2 replies; 10+ messages in thread
From: Ming Lei @ 2019-02-26 10:06 UTC (permalink / raw)
To: Faiz Abbas
Cc: Naresh Kamboju, open list,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-mmc, linux-omap, Tero Kristo, nm, Mark Rutland,
Rob Herring, Omar Sandoval, Ming Lei, Jens Axboe
On Tue, Feb 26, 2019 at 2:47 PM Faiz Abbas <faiz_abbas@ti.com> wrote:
>
> Hi Ming Lei,
>
> On 26/02/19 7:11 AM, Ming Lei wrote:
> > On Mon, Feb 25, 2019 at 9:14 PM Faiz Abbas <faiz_abbas@ti.com> wrote:
> >>
> >> Hi Naresh,
> >>
> >> + Commit authors.
> >>
> >> On 19/02/19 6:38 PM, Faiz Abbas wrote:
> >>> Hi Naresh,
> >>>
> >>> On 18/02/19 6:57 PM, Naresh Kamboju wrote:
> >>>> Do you see this error on am57xx-evm running Linux next 20190218 ?
> >>>> I have tested on multiple devices and found this error.
> >>>> Please find the full boot log [1].
> >>>> Am i missing any pre required configs [2] ?
> >>>>
> >>>> [ 5.620263] mmc1: ADMA error
> >>>> [ 5.623266] mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
> >>>> [ 5.629740] mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
> >>>> [ 5.636215] mmc1: sdhci: Blk size: 0x00000200 | Blk cnt: 0x0000ffff
> >>>> [ 5.642690] mmc1: sdhci: Argument: 0x002cec70 | Trn mode: 0x00000033
> >>>> [ 5.649162] mmc1: sdhci: Present: 0x01f00000 | Host ctl: 0x00000010
> >>>> [ 5.655634] mmc1: sdhci: Power: 0x0000000f | Blk gap: 0x00000000
> >>>> [ 5.662108] mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
> >>>> [ 5.668582] mmc1: sdhci: Timeout: 0x0000000c | Int stat: 0x00000000
> >>>> [ 5.675055] mmc1: sdhci: Int enab: 0x027f000b | Sig enab: 0x027f000b
> >>>> [ 5.681529] mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
> >>>> [ 5.688002] mmc1: sdhci: Caps: 0x21e90080 | Caps_1: 0x00000f77
> >>>> [ 5.694474] mmc1: sdhci: Cmd: 0x0000123a | Max curr: 0x00000000
> >>>> [ 5.700949] mmc1: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0xffffffef
> >>>> [ 5.707423] mmc1: sdhci: Resp[2]: 0x0f5903ff | Resp[3]: 0xd04f0132
> >>>> [ 5.713896] mmc1: sdhci: Host ctl2: 0x00000004
> >>>> [ 5.718364] mmc1: sdhci: ADMA Err: 0x00000007 | ADMA Ptr: 0xab868218
> >>>>
> >>>
> >>> I see this as well on my setup. Trying to bisect now. Will keep you posted.
> >>
> >>
> >> Reverting the following commit fixes this.
> >> commit 07173c3ec276cbb18dc0e0687d37d310e98a1480
> >> Author: Ming Lei <ming.lei@redhat.com>
> >> Date: Fri Feb 15 19:13:20 2019 +0800
> >>
> >> block: enable multipage bvecs
> >>
> >> This patch pulls the trigger for multi-page bvecs.
> >>
> >> Reviewed-by: Omar Sandoval <osandov@fb.com>
> >> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> >> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> >
> > Hi,
> >
> > Thanks for your report & bisect.
> >
> > Could you test the following patch?
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-5.1/block&id=8f4e80da764ec1ca44c83f3e17dbc9bf0209bccc
> >
> > Or simply run the latest -next?
>
> That didn't fix it for me. Still see ADMA error.
>
> [ 13.126186] mmc0: ADMA error
> [ 13.129084] mmc0: sdhci: ============ SDHCI REGISTER DUMP ===========
> [ 13.135552] mmc0: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
> [ 13.142019] mmc0: sdhci: Blk size: 0x00000200 | Blk cnt: 0x00000000
> [ 13.148485] mmc0: sdhci: Argument: 0x00000089 | Trn mode: 0x00000033
> [ 13.154952] mmc0: sdhci: Present: 0x00000000 | Host ctl: 0x00000012
> [ 13.161418] mmc0: sdhci: Power: 0x0000000f | Blk gap: 0x00000000
> [ 13.167885] mmc0: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
> [ 13.174351] mmc0: sdhci: Timeout: 0x0000000a | Int stat: 0x00000000
> [ 13.180817] mmc0: sdhci: Int enab: 0x027f000b | Sig enab: 0x027f000b
> [ 13.187282] mmc0: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
> [ 13.193748] mmc0: sdhci: Caps: 0x25e90080 | Caps_1: 0x00000f77
> [ 13.200215] mmc0: sdhci: Cmd: 0x0000123a | Max curr: 0x00000000
> [ 13.206682] mmc0: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0x3b377f80
> [ 13.213148] mmc0: sdhci: Resp[2]: 0x5b590000 | Resp[3]: 0x400e0032
> [ 13.219613] mmc0: sdhci: Host ctl2: 0x00000000
> [ 13.224073] mmc0: sdhci: ADMA Err: 0x00000007 | ADMA Ptr: 0xae857288
> [ 13.230538] mmc0: sdhci: ============================================
OK, I will write a debug patch to dump the sg data and see if it is
generated as wrong.
BTW, which kind of failure can you find from the mmc dma error log?
Thanks,
Ming Lei
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Linux-next 20190218: am57xx-evm: mmc1: ADMA error
2019-02-26 10:06 ` Ming Lei
@ 2019-02-26 11:31 ` Ming Lei
2019-02-26 11:34 ` Faiz Abbas
1 sibling, 0 replies; 10+ messages in thread
From: Ming Lei @ 2019-02-26 11:31 UTC (permalink / raw)
To: Faiz Abbas
Cc: Naresh Kamboju, open list,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-mmc, linux-omap, Tero Kristo, nm, Mark Rutland,
Rob Herring, Omar Sandoval, Ming Lei, Jens Axboe
[-- Attachment #1: Type: text/plain, Size: 4651 bytes --]
On Tue, Feb 26, 2019 at 6:06 PM Ming Lei <tom.leiming@gmail.com> wrote:
>
> On Tue, Feb 26, 2019 at 2:47 PM Faiz Abbas <faiz_abbas@ti.com> wrote:
> >
> > Hi Ming Lei,
> >
> > On 26/02/19 7:11 AM, Ming Lei wrote:
> > > On Mon, Feb 25, 2019 at 9:14 PM Faiz Abbas <faiz_abbas@ti.com> wrote:
> > >>
> > >> Hi Naresh,
> > >>
> > >> + Commit authors.
> > >>
> > >> On 19/02/19 6:38 PM, Faiz Abbas wrote:
> > >>> Hi Naresh,
> > >>>
> > >>> On 18/02/19 6:57 PM, Naresh Kamboju wrote:
> > >>>> Do you see this error on am57xx-evm running Linux next 20190218 ?
> > >>>> I have tested on multiple devices and found this error.
> > >>>> Please find the full boot log [1].
> > >>>> Am i missing any pre required configs [2] ?
> > >>>>
> > >>>> [ 5.620263] mmc1: ADMA error
> > >>>> [ 5.623266] mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
> > >>>> [ 5.629740] mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
> > >>>> [ 5.636215] mmc1: sdhci: Blk size: 0x00000200 | Blk cnt: 0x0000ffff
> > >>>> [ 5.642690] mmc1: sdhci: Argument: 0x002cec70 | Trn mode: 0x00000033
> > >>>> [ 5.649162] mmc1: sdhci: Present: 0x01f00000 | Host ctl: 0x00000010
> > >>>> [ 5.655634] mmc1: sdhci: Power: 0x0000000f | Blk gap: 0x00000000
> > >>>> [ 5.662108] mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
> > >>>> [ 5.668582] mmc1: sdhci: Timeout: 0x0000000c | Int stat: 0x00000000
> > >>>> [ 5.675055] mmc1: sdhci: Int enab: 0x027f000b | Sig enab: 0x027f000b
> > >>>> [ 5.681529] mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
> > >>>> [ 5.688002] mmc1: sdhci: Caps: 0x21e90080 | Caps_1: 0x00000f77
> > >>>> [ 5.694474] mmc1: sdhci: Cmd: 0x0000123a | Max curr: 0x00000000
> > >>>> [ 5.700949] mmc1: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0xffffffef
> > >>>> [ 5.707423] mmc1: sdhci: Resp[2]: 0x0f5903ff | Resp[3]: 0xd04f0132
> > >>>> [ 5.713896] mmc1: sdhci: Host ctl2: 0x00000004
> > >>>> [ 5.718364] mmc1: sdhci: ADMA Err: 0x00000007 | ADMA Ptr: 0xab868218
> > >>>>
> > >>>
> > >>> I see this as well on my setup. Trying to bisect now. Will keep you posted.
> > >>
> > >>
> > >> Reverting the following commit fixes this.
> > >> commit 07173c3ec276cbb18dc0e0687d37d310e98a1480
> > >> Author: Ming Lei <ming.lei@redhat.com>
> > >> Date: Fri Feb 15 19:13:20 2019 +0800
> > >>
> > >> block: enable multipage bvecs
> > >>
> > >> This patch pulls the trigger for multi-page bvecs.
> > >>
> > >> Reviewed-by: Omar Sandoval <osandov@fb.com>
> > >> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> > >> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> > >
> > > Hi,
> > >
> > > Thanks for your report & bisect.
> > >
> > > Could you test the following patch?
> > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-5.1/block&id=8f4e80da764ec1ca44c83f3e17dbc9bf0209bccc
> > >
> > > Or simply run the latest -next?
> >
> > That didn't fix it for me. Still see ADMA error.
> >
> > [ 13.126186] mmc0: ADMA error
> > [ 13.129084] mmc0: sdhci: ============ SDHCI REGISTER DUMP ===========
> > [ 13.135552] mmc0: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
> > [ 13.142019] mmc0: sdhci: Blk size: 0x00000200 | Blk cnt: 0x00000000
> > [ 13.148485] mmc0: sdhci: Argument: 0x00000089 | Trn mode: 0x00000033
> > [ 13.154952] mmc0: sdhci: Present: 0x00000000 | Host ctl: 0x00000012
> > [ 13.161418] mmc0: sdhci: Power: 0x0000000f | Blk gap: 0x00000000
> > [ 13.167885] mmc0: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
> > [ 13.174351] mmc0: sdhci: Timeout: 0x0000000a | Int stat: 0x00000000
> > [ 13.180817] mmc0: sdhci: Int enab: 0x027f000b | Sig enab: 0x027f000b
> > [ 13.187282] mmc0: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
> > [ 13.193748] mmc0: sdhci: Caps: 0x25e90080 | Caps_1: 0x00000f77
> > [ 13.200215] mmc0: sdhci: Cmd: 0x0000123a | Max curr: 0x00000000
> > [ 13.206682] mmc0: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0x3b377f80
> > [ 13.213148] mmc0: sdhci: Resp[2]: 0x5b590000 | Resp[3]: 0x400e0032
> > [ 13.219613] mmc0: sdhci: Host ctl2: 0x00000000
> > [ 13.224073] mmc0: sdhci: ADMA Err: 0x00000007 | ADMA Ptr: 0xae857288
> > [ 13.230538] mmc0: sdhci: ============================================
>
> OK, I will write a debug patch to dump the sg data and see if it is
> generated as wrong.
Hi Faiz,
Could you apply the attached debug patch and post the dmesg log?
Also please provide us the following log.
(cd /sys/block/mmcblk0/queue && find . -type f -exec grep -aH . {} \;)
Thanks,
Ming Lei
[-- Attachment #2: mmc-dbg.patch --]
[-- Type: text/x-patch, Size: 2148 bytes --]
diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
index aef1185f383d..ba9cf888aa87 100644
--- a/drivers/mmc/core/block.c
+++ b/drivers/mmc/core/block.c
@@ -1595,6 +1595,8 @@ static void mmc_blk_rw_rq_prep(struct mmc_queue_req *mqrq,
struct mmc_blk_data *md = mq->blkdata;
bool do_rel_wr, do_data_tag;
+ brq->mrq.rq = req;
+
mmc_blk_data_prep(mq, mqrq, disable_multi, &do_rel_wr, &do_data_tag);
brq->mrq.cmd = &brq->cmd;
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index eba9bcc92ad3..40e8424d8eaf 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -2842,6 +2842,31 @@ static void sdhci_cmd_irq(struct sdhci_host *host, u32 intmask, u32 *intmask_p)
sdhci_finish_command(host);
}
+#include <linux/blkdev.h>
+static void sdhci_dump_sg(struct sdhci_host *host)
+{
+ struct scatterlist *sg;
+ struct request *rq = host->data->mrq->rq;
+ struct req_iterator rq_iter;
+ struct bio_vec tmp;
+ int i = 0;
+
+ printk("%s: dump sg list\n", __func__);
+ for (sg = host->data->sg; sg; sg = sg_next(sg))
+ printk("\t %d: %lu %u %u\n",
+ i++,
+ (unsigned long)page_to_pfn(sg_page(sg)),
+ sg->offset, sg->length);
+
+ printk("%s: dump request bvec\n", __func__);
+ i = 0;
+ rq_for_each_bvec(tmp, rq, rq_iter)
+ printk("\t %d: %lu %u %u\n",
+ i++,
+ (unsigned long)page_to_pfn(tmp.bv_page),
+ tmp.bv_offset, tmp.bv_len);
+}
+
static void sdhci_adma_show_error(struct sdhci_host *host)
{
void *desc = host->adma_table;
@@ -2941,6 +2966,7 @@ static void sdhci_data_irq(struct sdhci_host *host, u32 intmask)
else if (intmask & SDHCI_INT_ADMA_ERROR) {
pr_err("%s: ADMA error\n", mmc_hostname(host->mmc));
sdhci_adma_show_error(host);
+ sdhci_dump_sg(host);
host->data->error = -EIO;
if (host->ops->adma_workaround)
host->ops->adma_workaround(host, intmask);
diff --git a/include/linux/mmc/core.h b/include/linux/mmc/core.h
index 134a6483347a..25565e640bfa 100644
--- a/include/linux/mmc/core.h
+++ b/include/linux/mmc/core.h
@@ -168,6 +168,7 @@ struct mmc_request {
bool cap_cmd_during_tfr;
int tag;
+ struct request *rq;
};
struct mmc_card;
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: Linux-next 20190218: am57xx-evm: mmc1: ADMA error
2019-02-26 10:06 ` Ming Lei
2019-02-26 11:31 ` Ming Lei
@ 2019-02-26 11:34 ` Faiz Abbas
2019-02-26 13:06 ` Ming Lei
1 sibling, 1 reply; 10+ messages in thread
From: Faiz Abbas @ 2019-02-26 11:34 UTC (permalink / raw)
To: Ming Lei
Cc: Naresh Kamboju, open list,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-mmc, linux-omap, Tero Kristo, nm, Mark Rutland,
Rob Herring, Omar Sandoval, Ming Lei, Jens Axboe
Hi,
On 26/02/19 3:36 PM, Ming Lei wrote:
> On Tue, Feb 26, 2019 at 2:47 PM Faiz Abbas <faiz_abbas@ti.com> wrote:
>>
>> Hi Ming Lei,
>>
>> On 26/02/19 7:11 AM, Ming Lei wrote:
>>> On Mon, Feb 25, 2019 at 9:14 PM Faiz Abbas <faiz_abbas@ti.com> wrote:
>>>>
>>>> Hi Naresh,
>>>>
>>>> + Commit authors.
>>>>
>>>> On 19/02/19 6:38 PM, Faiz Abbas wrote:
>>>>> Hi Naresh,
>>>>>
>>>>> On 18/02/19 6:57 PM, Naresh Kamboju wrote:
>>>>>> Do you see this error on am57xx-evm running Linux next 20190218 ?
>>>>>> I have tested on multiple devices and found this error.
>>>>>> Please find the full boot log [1].
>>>>>> Am i missing any pre required configs [2] ?
>>>>>>
>>>>>> [ 5.620263] mmc1: ADMA error
>>>>>> [ 5.623266] mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
>>>>>> [ 5.629740] mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
>>>>>> [ 5.636215] mmc1: sdhci: Blk size: 0x00000200 | Blk cnt: 0x0000ffff
>>>>>> [ 5.642690] mmc1: sdhci: Argument: 0x002cec70 | Trn mode: 0x00000033
>>>>>> [ 5.649162] mmc1: sdhci: Present: 0x01f00000 | Host ctl: 0x00000010
>>>>>> [ 5.655634] mmc1: sdhci: Power: 0x0000000f | Blk gap: 0x00000000
>>>>>> [ 5.662108] mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
>>>>>> [ 5.668582] mmc1: sdhci: Timeout: 0x0000000c | Int stat: 0x00000000
>>>>>> [ 5.675055] mmc1: sdhci: Int enab: 0x027f000b | Sig enab: 0x027f000b
>>>>>> [ 5.681529] mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
>>>>>> [ 5.688002] mmc1: sdhci: Caps: 0x21e90080 | Caps_1: 0x00000f77
>>>>>> [ 5.694474] mmc1: sdhci: Cmd: 0x0000123a | Max curr: 0x00000000
>>>>>> [ 5.700949] mmc1: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0xffffffef
>>>>>> [ 5.707423] mmc1: sdhci: Resp[2]: 0x0f5903ff | Resp[3]: 0xd04f0132
>>>>>> [ 5.713896] mmc1: sdhci: Host ctl2: 0x00000004
>>>>>> [ 5.718364] mmc1: sdhci: ADMA Err: 0x00000007 | ADMA Ptr: 0xab868218
>>>>>>
>>>>>
>>>>> I see this as well on my setup. Trying to bisect now. Will keep you posted.
>>>>
>>>>
>>>> Reverting the following commit fixes this.
>>>> commit 07173c3ec276cbb18dc0e0687d37d310e98a1480
>>>> Author: Ming Lei <ming.lei@redhat.com>
>>>> Date: Fri Feb 15 19:13:20 2019 +0800
>>>>
>>>> block: enable multipage bvecs
>>>>
>>>> This patch pulls the trigger for multi-page bvecs.
>>>>
>>>> Reviewed-by: Omar Sandoval <osandov@fb.com>
>>>> Signed-off-by: Ming Lei <ming.lei@redhat.com>
>>>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>>>
>>> Hi,
>>>
>>> Thanks for your report & bisect.
>>>
>>> Could you test the following patch?
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-5.1/block&id=8f4e80da764ec1ca44c83f3e17dbc9bf0209bccc
>>>
>>> Or simply run the latest -next?
>>
>> That didn't fix it for me. Still see ADMA error.
>>
>> [ 13.126186] mmc0: ADMA error
>> [ 13.129084] mmc0: sdhci: ============ SDHCI REGISTER DUMP ===========
>> [ 13.135552] mmc0: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
>> [ 13.142019] mmc0: sdhci: Blk size: 0x00000200 | Blk cnt: 0x00000000
>> [ 13.148485] mmc0: sdhci: Argument: 0x00000089 | Trn mode: 0x00000033
>> [ 13.154952] mmc0: sdhci: Present: 0x00000000 | Host ctl: 0x00000012
>> [ 13.161418] mmc0: sdhci: Power: 0x0000000f | Blk gap: 0x00000000
>> [ 13.167885] mmc0: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
>> [ 13.174351] mmc0: sdhci: Timeout: 0x0000000a | Int stat: 0x00000000
>> [ 13.180817] mmc0: sdhci: Int enab: 0x027f000b | Sig enab: 0x027f000b
>> [ 13.187282] mmc0: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
>> [ 13.193748] mmc0: sdhci: Caps: 0x25e90080 | Caps_1: 0x00000f77
>> [ 13.200215] mmc0: sdhci: Cmd: 0x0000123a | Max curr: 0x00000000
>> [ 13.206682] mmc0: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0x3b377f80
>> [ 13.213148] mmc0: sdhci: Resp[2]: 0x5b590000 | Resp[3]: 0x400e0032
>> [ 13.219613] mmc0: sdhci: Host ctl2: 0x00000000
>> [ 13.224073] mmc0: sdhci: ADMA Err: 0x00000007 | ADMA Ptr: 0xae857288
>> [ 13.230538] mmc0: sdhci: ============================================
>
> OK, I will write a debug patch to dump the sg data and see if it is
> generated as wrong.
>
> BTW, which kind of failure can you find from the mmc dma error log?
>
It looks like it only happens for some requests. More verbose log with
dma descriptor entries:
[ 14.840865] mmc0: ADMA error
[ 14.840869] mmc0: sdhci: ============ SDHCI REGISTER DUMP ===========
[ 14.840874] mmc0: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
[ 14.840879] mmc0: sdhci: Blk size: 0x00000200 | Blk cnt: 0x00000000
[ 14.840884] mmc0: sdhci: Argument: 0x00000200 | Trn mode: 0x00000033
[ 14.840889] mmc0: sdhci: Present: 0x00000000 | Host ctl: 0x00000012
[ 14.840893] mmc0: sdhci: Power: 0x0000000f | Blk gap: 0x00000000
[ 14.840898] mmc0: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
[ 14.840903] mmc0: sdhci: Timeout: 0x0000000a | Int stat: 0x00000000
[ 14.840908] mmc0: sdhci: Int enab: 0x027f000b | Sig enab: 0x027f000b
[ 14.840912] mmc0: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
[ 14.840917] mmc0: sdhci: Caps: 0x25e90080 | Caps_1: 0x00000f77
[ 14.840922] mmc0: sdhci: Cmd: 0x0000123a | Max curr: 0x00000000
[ 14.840926] mmc0: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0x20050044
[ 14.840931] mmc0: sdhci: Resp[2]: 0x53445531 | Resp[3]: 0x744a6055
[ 14.840935] mmc0: sdhci: Host ctl2: 0x00000000
[ 14.840939] mmc0: sdhci: ADMA Err: 0x00000007 | ADMA Ptr: 0xae857300
[ 14.840943] mmc0: sdhci: ============================================
[ 14.840950] mmc0: sdhci: be2c9004: DMA 0xab1bd000, LEN 0x1000, Attr=0x21
[ 14.840956] mmc0: sdhci: 92173e21: DMA 0xab1bc000, LEN 0x1000, Attr=0x21
[ 14.840962] mmc0: sdhci: c8a0cde4: DMA 0xab1bb000, LEN 0x1000, Attr=0x21
[ 14.840967] mmc0: sdhci: 4bb03017: DMA 0xab1ba000, LEN 0x1000, Attr=0x21
[ 14.840972] mmc0: sdhci: 2fb0d59e: DMA 0xab1b9000, LEN 0x1000, Attr=0x21
[ 14.840978] mmc0: sdhci: c3024ff2: DMA 0xab1b8000, LEN 0x1000, Attr=0x21
[ 14.840983] mmc0: sdhci: 0738188d: DMA 0xab179000, LEN 0x1000, Attr=0x21
[ 14.840989] mmc0: sdhci: 78ecca83: DMA 0xab178000, LEN 0x1000, Attr=0x21
[ 14.840994] mmc0: sdhci: 1432e5a9: DMA 0xab0d7000, LEN 0x1000, Attr=0x21
[ 14.840999] mmc0: sdhci: 8a36c77c: DMA 0xab0d6000, LEN 0x1000, Attr=0x21
[ 14.841005] mmc0: sdhci: b7196410: DMA 0xab0d5000, LEN 0x1000, Attr=0x21
[ 14.841010] mmc0: sdhci: dcb25259: DMA 0xab0d4000, LEN 0x1000, Attr=0x21
[ 14.841015] mmc0: sdhci: ef1e5d32: DMA 0xab0d3000, LEN 0x1000, Attr=0x21
[ 14.841020] mmc0: sdhci: 0319c66c: DMA 0xab0d2000, LEN 0x1000, Attr=0x21
[ 14.841026] mmc0: sdhci: 2e6b85d9: DMA 0xab0d1000, LEN 0x1000, Attr=0x21
[ 14.841031] mmc0: sdhci: d4dd19da: DMA 0xab0d0000, LEN 0x1000, Attr=0x21
[ 14.841036] mmc0: sdhci: 55cdc0f6: DMA 0xab27f000, LEN 0x1000, Attr=0x21
[ 14.841041] mmc0: sdhci: a172f4f3: DMA 0xab27e000, LEN 0x1000, Attr=0x21
[ 14.841046] mmc0: sdhci: ed27e53e: DMA 0xab27d000, LEN 0x1000, Attr=0x21
[ 14.841051] mmc0: sdhci: c04971ce: DMA 0xab27c000, LEN 0x1000, Attr=0x21
[ 14.841057] mmc0: sdhci: f43985d3: DMA 0xab27b000, LEN 0x1000, Attr=0x21
[ 14.841062] mmc0: sdhci: b977bd17: DMA 0xab27a000, LEN 0x1000, Attr=0x21
[ 14.841067] mmc0: sdhci: 8b74ee6f: DMA 0xab279000, LEN 0x1000, Attr=0x21
[ 14.841072] mmc0: sdhci: 12e52bc8: DMA 0xab30d000, LEN 0xffff, Attr=0x21
[ 14.841077] mmc0: sdhci: b39efa31: DMA 0xae857000, LEN 0x0001, Attr=0x21
[ 14.841082] mmc0: sdhci: bc4b71f0: DMA 0xab31d000, LEN 0x3000, Attr=0x21
[ 14.841087] mmc0: sdhci: 4cb5aa08: DMA 0xab2a8000, LEN 0x2000, Attr=0x21
[ 14.841092] mmc0: sdhci: 5e717781: DMA 0xab12a000, LEN 0x2000, Attr=0x21
[ 14.841098] mmc0: sdhci: 125d82b5: DMA 0xab2b4000, LEN 0x4000, Attr=0x21
[ 14.841103] mmc0: sdhci: b33874b9: DMA 0xab148000, LEN 0x4000, Attr=0x21
[ 14.841108] mmc0: sdhci: 9b0e47a5: DMA 0xab218000, LEN 0x8000, Attr=0x21
[ 14.841113] mmc0: sdhci: 47ce17da: DMA 0xab2a0000, LEN 0x2000, Attr=0x21
[ 14.841118] mmc0: sdhci: 97ea0d9f: DMA 0x00000000, LEN 0x0000, Attr=0x03
There is a big transfer of 0xffff length followed by a smaller transfer
of 0x1 (at address 0xae857000 above) and that is where it fails. This is
the same signature every time it happens.
Full Log:
https://pastebin.ubuntu.com/p/Rs4fzFbp4M/
Thanks,
Faiz
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Linux-next 20190218: am57xx-evm: mmc1: ADMA error
2019-02-26 11:34 ` Faiz Abbas
@ 2019-02-26 13:06 ` Ming Lei
2019-02-27 9:45 ` Faiz Abbas
0 siblings, 1 reply; 10+ messages in thread
From: Ming Lei @ 2019-02-26 13:06 UTC (permalink / raw)
To: Faiz Abbas
Cc: Ming Lei, Naresh Kamboju, open list,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-mmc, linux-omap, Tero Kristo, nm, Mark Rutland,
Rob Herring, Omar Sandoval, Jens Axboe
On Tue, Feb 26, 2019 at 05:04:40PM +0530, Faiz Abbas wrote:
> Hi,
>
> On 26/02/19 3:36 PM, Ming Lei wrote:
> > On Tue, Feb 26, 2019 at 2:47 PM Faiz Abbas <faiz_abbas@ti.com> wrote:
> >>
> >> Hi Ming Lei,
> >>
> >> On 26/02/19 7:11 AM, Ming Lei wrote:
> >>> On Mon, Feb 25, 2019 at 9:14 PM Faiz Abbas <faiz_abbas@ti.com> wrote:
> >>>>
> >>>> Hi Naresh,
> >>>>
> >>>> + Commit authors.
> >>>>
> >>>> On 19/02/19 6:38 PM, Faiz Abbas wrote:
> >>>>> Hi Naresh,
> >>>>>
> >>>>> On 18/02/19 6:57 PM, Naresh Kamboju wrote:
> >>>>>> Do you see this error on am57xx-evm running Linux next 20190218 ?
> >>>>>> I have tested on multiple devices and found this error.
> >>>>>> Please find the full boot log [1].
> >>>>>> Am i missing any pre required configs [2] ?
> >>>>>>
> >>>>>> [ 5.620263] mmc1: ADMA error
> >>>>>> [ 5.623266] mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
> >>>>>> [ 5.629740] mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
> >>>>>> [ 5.636215] mmc1: sdhci: Blk size: 0x00000200 | Blk cnt: 0x0000ffff
> >>>>>> [ 5.642690] mmc1: sdhci: Argument: 0x002cec70 | Trn mode: 0x00000033
> >>>>>> [ 5.649162] mmc1: sdhci: Present: 0x01f00000 | Host ctl: 0x00000010
> >>>>>> [ 5.655634] mmc1: sdhci: Power: 0x0000000f | Blk gap: 0x00000000
> >>>>>> [ 5.662108] mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
> >>>>>> [ 5.668582] mmc1: sdhci: Timeout: 0x0000000c | Int stat: 0x00000000
> >>>>>> [ 5.675055] mmc1: sdhci: Int enab: 0x027f000b | Sig enab: 0x027f000b
> >>>>>> [ 5.681529] mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
> >>>>>> [ 5.688002] mmc1: sdhci: Caps: 0x21e90080 | Caps_1: 0x00000f77
> >>>>>> [ 5.694474] mmc1: sdhci: Cmd: 0x0000123a | Max curr: 0x00000000
> >>>>>> [ 5.700949] mmc1: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0xffffffef
> >>>>>> [ 5.707423] mmc1: sdhci: Resp[2]: 0x0f5903ff | Resp[3]: 0xd04f0132
> >>>>>> [ 5.713896] mmc1: sdhci: Host ctl2: 0x00000004
> >>>>>> [ 5.718364] mmc1: sdhci: ADMA Err: 0x00000007 | ADMA Ptr: 0xab868218
> >>>>>>
> >>>>>
> >>>>> I see this as well on my setup. Trying to bisect now. Will keep you posted.
> >>>>
> >>>>
> >>>> Reverting the following commit fixes this.
> >>>> commit 07173c3ec276cbb18dc0e0687d37d310e98a1480
> >>>> Author: Ming Lei <ming.lei@redhat.com>
> >>>> Date: Fri Feb 15 19:13:20 2019 +0800
> >>>>
> >>>> block: enable multipage bvecs
> >>>>
> >>>> This patch pulls the trigger for multi-page bvecs.
> >>>>
> >>>> Reviewed-by: Omar Sandoval <osandov@fb.com>
> >>>> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> >>>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> >>>
> >>> Hi,
> >>>
> >>> Thanks for your report & bisect.
> >>>
> >>> Could you test the following patch?
> >>>
> >>> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-5.1/block&id=8f4e80da764ec1ca44c83f3e17dbc9bf0209bccc
> >>>
> >>> Or simply run the latest -next?
> >>
> >> That didn't fix it for me. Still see ADMA error.
> >>
> >> [ 13.126186] mmc0: ADMA error
> >> [ 13.129084] mmc0: sdhci: ============ SDHCI REGISTER DUMP ===========
> >> [ 13.135552] mmc0: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
> >> [ 13.142019] mmc0: sdhci: Blk size: 0x00000200 | Blk cnt: 0x00000000
> >> [ 13.148485] mmc0: sdhci: Argument: 0x00000089 | Trn mode: 0x00000033
> >> [ 13.154952] mmc0: sdhci: Present: 0x00000000 | Host ctl: 0x00000012
> >> [ 13.161418] mmc0: sdhci: Power: 0x0000000f | Blk gap: 0x00000000
> >> [ 13.167885] mmc0: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
> >> [ 13.174351] mmc0: sdhci: Timeout: 0x0000000a | Int stat: 0x00000000
> >> [ 13.180817] mmc0: sdhci: Int enab: 0x027f000b | Sig enab: 0x027f000b
> >> [ 13.187282] mmc0: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
> >> [ 13.193748] mmc0: sdhci: Caps: 0x25e90080 | Caps_1: 0x00000f77
> >> [ 13.200215] mmc0: sdhci: Cmd: 0x0000123a | Max curr: 0x00000000
> >> [ 13.206682] mmc0: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0x3b377f80
> >> [ 13.213148] mmc0: sdhci: Resp[2]: 0x5b590000 | Resp[3]: 0x400e0032
> >> [ 13.219613] mmc0: sdhci: Host ctl2: 0x00000000
> >> [ 13.224073] mmc0: sdhci: ADMA Err: 0x00000007 | ADMA Ptr: 0xae857288
> >> [ 13.230538] mmc0: sdhci: ============================================
> >
> > OK, I will write a debug patch to dump the sg data and see if it is
> > generated as wrong.
> >
> > BTW, which kind of failure can you find from the mmc dma error log?
> >
>
> It looks like it only happens for some requests. More verbose log with
> dma descriptor entries:
>
> [ 14.840865] mmc0: ADMA error
> [ 14.840869] mmc0: sdhci: ============ SDHCI REGISTER DUMP ===========
> [ 14.840874] mmc0: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
> [ 14.840879] mmc0: sdhci: Blk size: 0x00000200 | Blk cnt: 0x00000000
> [ 14.840884] mmc0: sdhci: Argument: 0x00000200 | Trn mode: 0x00000033
> [ 14.840889] mmc0: sdhci: Present: 0x00000000 | Host ctl: 0x00000012
> [ 14.840893] mmc0: sdhci: Power: 0x0000000f | Blk gap: 0x00000000
> [ 14.840898] mmc0: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
> [ 14.840903] mmc0: sdhci: Timeout: 0x0000000a | Int stat: 0x00000000
> [ 14.840908] mmc0: sdhci: Int enab: 0x027f000b | Sig enab: 0x027f000b
> [ 14.840912] mmc0: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
> [ 14.840917] mmc0: sdhci: Caps: 0x25e90080 | Caps_1: 0x00000f77
> [ 14.840922] mmc0: sdhci: Cmd: 0x0000123a | Max curr: 0x00000000
> [ 14.840926] mmc0: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0x20050044
> [ 14.840931] mmc0: sdhci: Resp[2]: 0x53445531 | Resp[3]: 0x744a6055
> [ 14.840935] mmc0: sdhci: Host ctl2: 0x00000000
> [ 14.840939] mmc0: sdhci: ADMA Err: 0x00000007 | ADMA Ptr: 0xae857300
> [ 14.840943] mmc0: sdhci: ============================================
> [ 14.840950] mmc0: sdhci: be2c9004: DMA 0xab1bd000, LEN 0x1000, Attr=0x21
> [ 14.840956] mmc0: sdhci: 92173e21: DMA 0xab1bc000, LEN 0x1000, Attr=0x21
> [ 14.840962] mmc0: sdhci: c8a0cde4: DMA 0xab1bb000, LEN 0x1000, Attr=0x21
> [ 14.840967] mmc0: sdhci: 4bb03017: DMA 0xab1ba000, LEN 0x1000, Attr=0x21
> [ 14.840972] mmc0: sdhci: 2fb0d59e: DMA 0xab1b9000, LEN 0x1000, Attr=0x21
> [ 14.840978] mmc0: sdhci: c3024ff2: DMA 0xab1b8000, LEN 0x1000, Attr=0x21
> [ 14.840983] mmc0: sdhci: 0738188d: DMA 0xab179000, LEN 0x1000, Attr=0x21
> [ 14.840989] mmc0: sdhci: 78ecca83: DMA 0xab178000, LEN 0x1000, Attr=0x21
> [ 14.840994] mmc0: sdhci: 1432e5a9: DMA 0xab0d7000, LEN 0x1000, Attr=0x21
> [ 14.840999] mmc0: sdhci: 8a36c77c: DMA 0xab0d6000, LEN 0x1000, Attr=0x21
> [ 14.841005] mmc0: sdhci: b7196410: DMA 0xab0d5000, LEN 0x1000, Attr=0x21
> [ 14.841010] mmc0: sdhci: dcb25259: DMA 0xab0d4000, LEN 0x1000, Attr=0x21
> [ 14.841015] mmc0: sdhci: ef1e5d32: DMA 0xab0d3000, LEN 0x1000, Attr=0x21
> [ 14.841020] mmc0: sdhci: 0319c66c: DMA 0xab0d2000, LEN 0x1000, Attr=0x21
> [ 14.841026] mmc0: sdhci: 2e6b85d9: DMA 0xab0d1000, LEN 0x1000, Attr=0x21
> [ 14.841031] mmc0: sdhci: d4dd19da: DMA 0xab0d0000, LEN 0x1000, Attr=0x21
> [ 14.841036] mmc0: sdhci: 55cdc0f6: DMA 0xab27f000, LEN 0x1000, Attr=0x21
> [ 14.841041] mmc0: sdhci: a172f4f3: DMA 0xab27e000, LEN 0x1000, Attr=0x21
> [ 14.841046] mmc0: sdhci: ed27e53e: DMA 0xab27d000, LEN 0x1000, Attr=0x21
> [ 14.841051] mmc0: sdhci: c04971ce: DMA 0xab27c000, LEN 0x1000, Attr=0x21
> [ 14.841057] mmc0: sdhci: f43985d3: DMA 0xab27b000, LEN 0x1000, Attr=0x21
> [ 14.841062] mmc0: sdhci: b977bd17: DMA 0xab27a000, LEN 0x1000, Attr=0x21
> [ 14.841067] mmc0: sdhci: 8b74ee6f: DMA 0xab279000, LEN 0x1000, Attr=0x21
> [ 14.841072] mmc0: sdhci: 12e52bc8: DMA 0xab30d000, LEN 0xffff, Attr=0x21
> [ 14.841077] mmc0: sdhci: b39efa31: DMA 0xae857000, LEN 0x0001, Attr=0x21
> [ 14.841082] mmc0: sdhci: bc4b71f0: DMA 0xab31d000, LEN 0x3000, Attr=0x21
> [ 14.841087] mmc0: sdhci: 4cb5aa08: DMA 0xab2a8000, LEN 0x2000, Attr=0x21
> [ 14.841092] mmc0: sdhci: 5e717781: DMA 0xab12a000, LEN 0x2000, Attr=0x21
> [ 14.841098] mmc0: sdhci: 125d82b5: DMA 0xab2b4000, LEN 0x4000, Attr=0x21
> [ 14.841103] mmc0: sdhci: b33874b9: DMA 0xab148000, LEN 0x4000, Attr=0x21
> [ 14.841108] mmc0: sdhci: 9b0e47a5: DMA 0xab218000, LEN 0x8000, Attr=0x21
> [ 14.841113] mmc0: sdhci: 47ce17da: DMA 0xab2a0000, LEN 0x2000, Attr=0x21
> [ 14.841118] mmc0: sdhci: 97ea0d9f: DMA 0x00000000, LEN 0x0000, Attr=0x03
>
> There is a big transfer of 0xffff length followed by a smaller transfer
> of 0x1 (at address 0xae857000 above) and that is where it fails. This is
> the same signature every time it happens.
Thanks for the investigation, and that is very helpful!
Then I guess it is caused by bad segment size, see sdhci_setup_host():
if (host->flags & SDHCI_USE_ADMA) {
if (host->quirks & SDHCI_QUIRK_BROKEN_ADMA_ZEROLEN_DESC)
mmc->max_seg_size = 65535;
else
mmc->max_seg_size = 65536;
} else {
mmc->max_seg_size = mmc->max_req_size;
}
Could you confirm it by collecting the following log?
(cd /sys/block/mmcblk0/queue && find . -type f -exec grep -aH . {} \;)
If 'max_segment_size' is 65535, we may need the following patch:
diff --git a/block/blk-settings.c b/block/blk-settings.c
index 6375afaedcec..6fb7a312b4ea 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -309,7 +309,7 @@ void blk_queue_max_segment_size(struct request_queue *q, unsigned int max_size)
__func__, max_size);
}
- q->limits.max_segment_size = max_size;
+ q->limits.max_segment_size = round_down(max_size, 512);
}
EXPORT_SYMBOL(blk_queue_max_segment_size);
Thanks,
Ming
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: Linux-next 20190218: am57xx-evm: mmc1: ADMA error
2019-02-26 13:06 ` Ming Lei
@ 2019-02-27 9:45 ` Faiz Abbas
0 siblings, 0 replies; 10+ messages in thread
From: Faiz Abbas @ 2019-02-27 9:45 UTC (permalink / raw)
To: Ming Lei
Cc: Ming Lei, Naresh Kamboju, open list,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-mmc, linux-omap, Tero Kristo, nm, Mark Rutland,
Rob Herring, Omar Sandoval, Jens Axboe
Hi,
On 26/02/19 6:36 PM, Ming Lei wrote:
> On Tue, Feb 26, 2019 at 05:04:40PM +0530, Faiz Abbas wrote:
>> Hi,
>>
>> On 26/02/19 3:36 PM, Ming Lei wrote:
>>> On Tue, Feb 26, 2019 at 2:47 PM Faiz Abbas <faiz_abbas@ti.com> wrote:
>>>>
>>>> Hi Ming Lei,
>>>>
>>>> On 26/02/19 7:11 AM, Ming Lei wrote:
>>>>> On Mon, Feb 25, 2019 at 9:14 PM Faiz Abbas <faiz_abbas@ti.com> wrote:
>>>>>>
>>>>>> Hi Naresh,
>>>>>>
>>>>>> + Commit authors.
>>>>>>
>>>>>> On 19/02/19 6:38 PM, Faiz Abbas wrote:
>>>>>>> Hi Naresh,
>>>>>>>
...
>> It looks like it only happens for some requests. More verbose log with
>> dma descriptor entries:
>>
>> [ 14.840865] mmc0: ADMA error
>> [ 14.840869] mmc0: sdhci: ============ SDHCI REGISTER DUMP ===========
>> [ 14.840874] mmc0: sdhci: Sys addr: 0x00000000 | Version: 0x00003302
>> [ 14.840879] mmc0: sdhci: Blk size: 0x00000200 | Blk cnt: 0x00000000
>> [ 14.840884] mmc0: sdhci: Argument: 0x00000200 | Trn mode: 0x00000033
>> [ 14.840889] mmc0: sdhci: Present: 0x00000000 | Host ctl: 0x00000012
>> [ 14.840893] mmc0: sdhci: Power: 0x0000000f | Blk gap: 0x00000000
>> [ 14.840898] mmc0: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107
>> [ 14.840903] mmc0: sdhci: Timeout: 0x0000000a | Int stat: 0x00000000
>> [ 14.840908] mmc0: sdhci: Int enab: 0x027f000b | Sig enab: 0x027f000b
>> [ 14.840912] mmc0: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000
>> [ 14.840917] mmc0: sdhci: Caps: 0x25e90080 | Caps_1: 0x00000f77
>> [ 14.840922] mmc0: sdhci: Cmd: 0x0000123a | Max curr: 0x00000000
>> [ 14.840926] mmc0: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0x20050044
>> [ 14.840931] mmc0: sdhci: Resp[2]: 0x53445531 | Resp[3]: 0x744a6055
>> [ 14.840935] mmc0: sdhci: Host ctl2: 0x00000000
>> [ 14.840939] mmc0: sdhci: ADMA Err: 0x00000007 | ADMA Ptr: 0xae857300
>> [ 14.840943] mmc0: sdhci: ============================================
>> [ 14.840950] mmc0: sdhci: be2c9004: DMA 0xab1bd000, LEN 0x1000, Attr=0x21
>> [ 14.840956] mmc0: sdhci: 92173e21: DMA 0xab1bc000, LEN 0x1000, Attr=0x21
>> [ 14.840962] mmc0: sdhci: c8a0cde4: DMA 0xab1bb000, LEN 0x1000, Attr=0x21
>> [ 14.840967] mmc0: sdhci: 4bb03017: DMA 0xab1ba000, LEN 0x1000, Attr=0x21
>> [ 14.840972] mmc0: sdhci: 2fb0d59e: DMA 0xab1b9000, LEN 0x1000, Attr=0x21
>> [ 14.840978] mmc0: sdhci: c3024ff2: DMA 0xab1b8000, LEN 0x1000, Attr=0x21
>> [ 14.840983] mmc0: sdhci: 0738188d: DMA 0xab179000, LEN 0x1000, Attr=0x21
>> [ 14.840989] mmc0: sdhci: 78ecca83: DMA 0xab178000, LEN 0x1000, Attr=0x21
>> [ 14.840994] mmc0: sdhci: 1432e5a9: DMA 0xab0d7000, LEN 0x1000, Attr=0x21
>> [ 14.840999] mmc0: sdhci: 8a36c77c: DMA 0xab0d6000, LEN 0x1000, Attr=0x21
>> [ 14.841005] mmc0: sdhci: b7196410: DMA 0xab0d5000, LEN 0x1000, Attr=0x21
>> [ 14.841010] mmc0: sdhci: dcb25259: DMA 0xab0d4000, LEN 0x1000, Attr=0x21
>> [ 14.841015] mmc0: sdhci: ef1e5d32: DMA 0xab0d3000, LEN 0x1000, Attr=0x21
>> [ 14.841020] mmc0: sdhci: 0319c66c: DMA 0xab0d2000, LEN 0x1000, Attr=0x21
>> [ 14.841026] mmc0: sdhci: 2e6b85d9: DMA 0xab0d1000, LEN 0x1000, Attr=0x21
>> [ 14.841031] mmc0: sdhci: d4dd19da: DMA 0xab0d0000, LEN 0x1000, Attr=0x21
>> [ 14.841036] mmc0: sdhci: 55cdc0f6: DMA 0xab27f000, LEN 0x1000, Attr=0x21
>> [ 14.841041] mmc0: sdhci: a172f4f3: DMA 0xab27e000, LEN 0x1000, Attr=0x21
>> [ 14.841046] mmc0: sdhci: ed27e53e: DMA 0xab27d000, LEN 0x1000, Attr=0x21
>> [ 14.841051] mmc0: sdhci: c04971ce: DMA 0xab27c000, LEN 0x1000, Attr=0x21
>> [ 14.841057] mmc0: sdhci: f43985d3: DMA 0xab27b000, LEN 0x1000, Attr=0x21
>> [ 14.841062] mmc0: sdhci: b977bd17: DMA 0xab27a000, LEN 0x1000, Attr=0x21
>> [ 14.841067] mmc0: sdhci: 8b74ee6f: DMA 0xab279000, LEN 0x1000, Attr=0x21
>> [ 14.841072] mmc0: sdhci: 12e52bc8: DMA 0xab30d000, LEN 0xffff, Attr=0x21
>> [ 14.841077] mmc0: sdhci: b39efa31: DMA 0xae857000, LEN 0x0001, Attr=0x21
>> [ 14.841082] mmc0: sdhci: bc4b71f0: DMA 0xab31d000, LEN 0x3000, Attr=0x21
>> [ 14.841087] mmc0: sdhci: 4cb5aa08: DMA 0xab2a8000, LEN 0x2000, Attr=0x21
>> [ 14.841092] mmc0: sdhci: 5e717781: DMA 0xab12a000, LEN 0x2000, Attr=0x21
>> [ 14.841098] mmc0: sdhci: 125d82b5: DMA 0xab2b4000, LEN 0x4000, Attr=0x21
>> [ 14.841103] mmc0: sdhci: b33874b9: DMA 0xab148000, LEN 0x4000, Attr=0x21
>> [ 14.841108] mmc0: sdhci: 9b0e47a5: DMA 0xab218000, LEN 0x8000, Attr=0x21
>> [ 14.841113] mmc0: sdhci: 47ce17da: DMA 0xab2a0000, LEN 0x2000, Attr=0x21
>> [ 14.841118] mmc0: sdhci: 97ea0d9f: DMA 0x00000000, LEN 0x0000, Attr=0x03
>>
>> There is a big transfer of 0xffff length followed by a smaller transfer
>> of 0x1 (at address 0xae857000 above) and that is where it fails. This is
>> the same signature every time it happens.
>
> Thanks for the investigation, and that is very helpful!
>
> Then I guess it is caused by bad segment size, see sdhci_setup_host():
>
> if (host->flags & SDHCI_USE_ADMA) {
> if (host->quirks & SDHCI_QUIRK_BROKEN_ADMA_ZEROLEN_DESC)
> mmc->max_seg_size = 65535;
> else
> mmc->max_seg_size = 65536;
> } else {
> mmc->max_seg_size = mmc->max_req_size;
> }
>
> Could you confirm it by collecting the following log?
>
> (cd /sys/block/mmcblk0/queue && find . -type f -exec grep -aH . {} \;)
The max_segment_size is 65535.
root@dra7xx-evm:~# (cd /sys/block/mmcblk0/queue && find . -type f -exec
grep -aH . {} \;)
./hw_sector_size:512
./max_discard_segments:1
./max_segment_size:65535
./physical_block_size:512
./discard_max_bytes:4194304
./rotational:0
./iosched/fifo_batch:16
./iosched/read_expire:500
./iosched/writes_starved:2
./iosched/write_expire:5000
./iosched/front_merges:1
./write_same_max_bytes:0
./zoned:none
./max_sectors_kb:512
./discard_zeroes_data:0
./read_ahead_kb:128
./discard_max_hw_bytes:4194304
./nomerges:0
./max_segments:128
./rq_affinity:1
./iostats:1
./dax:0
./minimum_io_size:512
./chunk_sectors:0
./io_poll:0
./write_zeroes_max_bytes:0
./max_hw_sectors_kb:512
./add_random:0
./optimal_io_size:0
./nr_requests:128
./scheduler:[mq-deadline] kyber none
./io_timeout:60000
./discard_granularity:4194304
./logical_block_size:512
./nr_zones:0
./fua:1
./io_poll_delay:-1
./max_integrity_segments:0
./write_cache:write back
root@dra7xx-evm:~#
>
> If 'max_segment_size' is 65535, we may need the following patch:
>
> diff --git a/block/blk-settings.c b/block/blk-settings.c
> index 6375afaedcec..6fb7a312b4ea 100644
> --- a/block/blk-settings.c
> +++ b/block/blk-settings.c
> @@ -309,7 +309,7 @@ void blk_queue_max_segment_size(struct request_queue *q, unsigned int max_size)
> __func__, max_size);
> }
>
> - q->limits.max_segment_size = max_size;
> + q->limits.max_segment_size = round_down(max_size, 512);
> }
> EXPORT_SYMBOL(blk_queue_max_segment_size);
>
This patch fixes it for me. Thanks!
Regards,
Faiz
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-02-27 9:42 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-18 13:27 Linux-next 20190218: am57xx-evm: mmc1: ADMA error Naresh Kamboju
2019-02-19 13:08 ` Faiz Abbas
2019-02-25 13:16 ` Faiz Abbas
2019-02-26 1:41 ` Ming Lei
2019-02-26 6:50 ` Faiz Abbas
2019-02-26 10:06 ` Ming Lei
2019-02-26 11:31 ` Ming Lei
2019-02-26 11:34 ` Faiz Abbas
2019-02-26 13:06 ` Ming Lei
2019-02-27 9:45 ` Faiz Abbas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).