* [PATCH 1/2] dt-bindings: remoteproc: qcom,adsp: Add SM6375 MPSS
@ 2022-12-10 13:58 Konrad Dybcio
2022-12-10 13:58 ` [PATCH 2/2] remoteproc: qcom: pas: " Konrad Dybcio
2022-12-11 20:25 ` [PATCH 1/2] dt-bindings: remoteproc: qcom,adsp: " Krzysztof Kozlowski
0 siblings, 2 replies; 4+ messages in thread
From: Konrad Dybcio @ 2022-12-10 13:58 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: patches, Konrad Dybcio, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Manivannan Sadhasivam, linux-remoteproc,
devicetree, linux-kernel
Add entries for SM6375 MPSS. Unlike most other modems, this one only
expects a single (cx) power domain.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
index a9219c7c8349..434d34578fc5 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
@@ -42,6 +42,7 @@ properties:
- qcom,sm6350-mpss-pas
- qcom,sm6375-adsp-pas
- qcom,sm6375-cdsp-pas
+ - qcom,sm6375-mpss-pas
- qcom,sm8150-adsp-pas
- qcom,sm8150-cdsp-pas
- qcom,sm8150-mpss-pas
@@ -201,6 +202,7 @@ allOf:
- qcom,sm6350-mpss-pas
- qcom,sm6375-adsp-pas
- qcom,sm6375-cdsp-pas
+ - qcom,sm6375-mpss-pas
- qcom,sm8150-adsp-pas
- qcom,sm8150-cdsp-pas
- qcom,sm8150-mpss-pas
@@ -350,6 +352,7 @@ allOf:
- qcom,sc8180x-mpss-pas
- qcom,sdx55-mpss-pas
- qcom,sm6350-mpss-pas
+ - qcom,sm6375-mpss-pas
- qcom,sm8150-mpss-pas
- qcom,sm8350-mpss-pas
- qcom,sm8450-mpss-pas
@@ -379,6 +382,7 @@ allOf:
- qcom,msm8996-adsp-pil
- qcom,msm8998-adsp-pas
- qcom,sm6375-cdsp-pas
+ - qcom,sm6375-mpss-pas
- qcom,sm8150-adsp-pas
- qcom,sm8150-cdsp-pas
then:
--
2.38.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] remoteproc: qcom: pas: Add SM6375 MPSS
2022-12-10 13:58 [PATCH 1/2] dt-bindings: remoteproc: qcom,adsp: Add SM6375 MPSS Konrad Dybcio
@ 2022-12-10 13:58 ` Konrad Dybcio
2022-12-11 20:25 ` [PATCH 1/2] dt-bindings: remoteproc: qcom,adsp: " Krzysztof Kozlowski
1 sibling, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2022-12-10 13:58 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: patches, Konrad Dybcio, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Manivannan Sadhasivam, linux-remoteproc,
devicetree, linux-kernel
Add a config for the MPSS present on SM6375.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
drivers/remoteproc/qcom_q6v5_pas.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index 920f8e54db36..405a144c9c3e 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -854,6 +854,22 @@ static const struct adsp_data slpi_resource_init = {
.ssctl_id = 0x16,
};
+static const struct adsp_data sm6375_mpss_resource = {
+ .crash_reason_smem = 421,
+ .firmware_name = "modem.mdt",
+ .pas_id = 4,
+ .minidump_id = 3,
+ .has_aggre2_clk = false,
+ .auto_boot = false,
+ .proxy_pd_names = (char*[]){
+ "cx",
+ NULL
+ },
+ .ssr_name = "mpss",
+ .sysmon_name = "modem",
+ .ssctl_id = 0x12,
+};
+
static const struct adsp_data sm8150_slpi_resource = {
.crash_reason_smem = 424,
.firmware_name = "slpi.mdt",
@@ -977,6 +993,7 @@ static const struct of_device_id adsp_of_match[] = {
{ .compatible = "qcom,sm6350-mpss-pas", .data = &mpss_resource_init},
{ .compatible = "qcom,sm6375-adsp-pas", .data = &sm6350_adsp_resource},
{ .compatible = "qcom,sm6375-cdsp-pas", .data = &sm8150_cdsp_resource},
+ { .compatible = "qcom,sm6375-mpss-pas", .data = &sm6375_mpss_resource},
{ .compatible = "qcom,sm8150-adsp-pas", .data = &sm8150_adsp_resource},
{ .compatible = "qcom,sm8150-cdsp-pas", .data = &sm8150_cdsp_resource},
{ .compatible = "qcom,sm8150-mpss-pas", .data = &mpss_resource_init},
--
2.38.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: remoteproc: qcom,adsp: Add SM6375 MPSS
2022-12-10 13:58 [PATCH 1/2] dt-bindings: remoteproc: qcom,adsp: Add SM6375 MPSS Konrad Dybcio
2022-12-10 13:58 ` [PATCH 2/2] remoteproc: qcom: pas: " Konrad Dybcio
@ 2022-12-11 20:25 ` Krzysztof Kozlowski
2022-12-12 9:06 ` Konrad Dybcio
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-11 20:25 UTC (permalink / raw)
To: Konrad Dybcio, linux-arm-msm, andersson, agross
Cc: patches, Mathieu Poirier, Rob Herring, Krzysztof Kozlowski,
Manivannan Sadhasivam, linux-remoteproc, devicetree,
linux-kernel
On 10/12/2022 14:58, Konrad Dybcio wrote:
> Add entries for SM6375 MPSS. Unlike most other modems, this one only
> expects a single (cx) power domain.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> index a9219c7c8349..434d34578fc5 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> @@ -42,6 +42,7 @@ properties:
> - qcom,sm6350-mpss-pas
> - qcom,sm6375-adsp-pas
> - qcom,sm6375-cdsp-pas
There is no such entry... Do you base on some other patchset?
> + - qcom,sm6375-mpss-pas
I propose to rebase it on my series:
https://lore.kernel.org/all/20221124184333.133911-1-krzysztof.kozlowski@linaro.org/
and then either add it as new file or maybe it will fit to one of the
device schemas.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: remoteproc: qcom,adsp: Add SM6375 MPSS
2022-12-11 20:25 ` [PATCH 1/2] dt-bindings: remoteproc: qcom,adsp: " Krzysztof Kozlowski
@ 2022-12-12 9:06 ` Konrad Dybcio
0 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2022-12-12 9:06 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-arm-msm, andersson, agross
Cc: patches, Mathieu Poirier, Rob Herring, Krzysztof Kozlowski,
Manivannan Sadhasivam, linux-remoteproc, devicetree,
linux-kernel
On 11.12.2022 21:25, Krzysztof Kozlowski wrote:
> On 10/12/2022 14:58, Konrad Dybcio wrote:
>> Add entries for SM6375 MPSS. Unlike most other modems, this one only
>> expects a single (cx) power domain.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> index a9219c7c8349..434d34578fc5 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> @@ -42,6 +42,7 @@ properties:
>> - qcom,sm6350-mpss-pas
>> - qcom,sm6375-adsp-pas
>> - qcom,sm6375-cdsp-pas
>
> There is no such entry... Do you base on some other patchset?
Yep, this one [1].. I thought it was merged, as Bjorn pulled in the
DT part (which stated dependency on [1])..
Konrad
[1] https://lore.kernel.org/linux-arm-msm/20221109170822.58281-1-konrad.dybcio@linaro.org/
>
>> + - qcom,sm6375-mpss-pas
>
> I propose to rebase it on my series:
> https://lore.kernel.org/all/20221124184333.133911-1-krzysztof.kozlowski@linaro.org/
>
> and then either add it as new file or maybe it will fit to one of the
> device schemas.
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-12 9:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-10 13:58 [PATCH 1/2] dt-bindings: remoteproc: qcom,adsp: Add SM6375 MPSS Konrad Dybcio
2022-12-10 13:58 ` [PATCH 2/2] remoteproc: qcom: pas: " Konrad Dybcio
2022-12-11 20:25 ` [PATCH 1/2] dt-bindings: remoteproc: qcom,adsp: " Krzysztof Kozlowski
2022-12-12 9:06 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).