From: Markus Elfring <Markus.Elfring@web.de>
To: "Bernard Zhao" <bernard@vivo.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Chunming Zhou" <David1.Zhou@amd.com>
Cc: linux-kernel@vger.kernel.org, opensource.kernel@vivo.com,
"Andrzej Pietrasiewicz" <andrzej.p@collabora.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@linux.ie>,
"José Roberto de Souza" <jose.souza@intel.com>,
"Lyude Paul" <lyude@redhat.com>,
"Sam Ravnborg" <sam@ravnborg.org>
Subject: Re: [PATCH v2] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()
Date: Tue, 21 Apr 2020 11:00:31 +0200 [thread overview]
Message-ID: <34ec6ec4-77aa-9514-f9b2-62c3392d0473@web.de> (raw)
> The "if(!encoder)" branch return the same value 0 of the success
> branch, maybe return -EINVAL is more better.
I suggest to improve the commit message.
* Are you still unsure about the next changes?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=ae83d0b416db002fe95601e7f97f64b59514d936#n151
* Would you like to adjust the patch subject another bit?
* How do you think about to add the tag “Fixes”
because of adjustments for the exception handling?
It can be nicer if all patch reviewers (including me) will be explicitly specified
as recipients for such messages, can't it?
Regards,
Markus
reply other threads:[~2020-04-21 9:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34ec6ec4-77aa-9514-f9b2-62c3392d0473@web.de \
--to=markus.elfring@web.de \
--cc=David1.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrzej.p@collabora.com \
--cc=bernard@vivo.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=opensource.kernel@vivo.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).