From: Andrew Lunn <andrew@lunn.ch>
To: Lukasz Majewski <lukma@denx.de>
Cc: Vladimir Oltean <olteanv@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 3/3] net: dsa: mv88e6xxx: add support for MV88E6071 switch
Date: Tue, 23 May 2023 19:37:24 +0200 [thread overview]
Message-ID: <357c733d-77fa-42e3-ba0c-ef6e50ff04ef@lunn.ch> (raw)
In-Reply-To: <20230523142912.2086985-4-lukma@denx.de>
On Tue, May 23, 2023 at 04:29:12PM +0200, Lukasz Majewski wrote:
> A mv88e6250 family (i.e. "LinkStreet") switch with 5 internal PHYs,
> 2 RMIIs and no PTP support.
chip.h says:
MV88E6XXX_FAMILY_6250, /* 6220 6250 */
Please update this comment.
I would also suggest you don't call the mv88e6250 family
"LinkStreet". All Marvell SoHo switches are LinkStreet, all switches
supported by the mv88e6xxx driver are "LinkStreet".
With these changes:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2023-05-23 17:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 14:29 [PATCH v7 0/3] dsa: marvell: Add support for mv88e6071 and 6020 switches Lukasz Majewski
2023-05-23 14:29 ` [PATCH v7 1/3] dsa: marvell: Define .set_max_frame_size() function for mv88e6250 SoC family Lukasz Majewski
2023-05-23 14:38 ` Russell King (Oracle)
2023-05-24 12:53 ` Lukasz Majewski
2023-05-23 14:43 ` Russell King (Oracle)
2023-05-24 12:06 ` Lukasz Majewski
2023-05-24 12:08 ` Russell King (Oracle)
2023-05-23 14:29 ` [PATCH v7 2/3] net: dsa: mv88e6xxx: add support for MV88E6020 switch Lukasz Majewski
2023-05-23 14:29 ` [PATCH v7 3/3] net: dsa: mv88e6xxx: add support for MV88E6071 switch Lukasz Majewski
2023-05-23 17:37 ` Andrew Lunn [this message]
2023-05-23 17:26 ` [PATCH v7 0/3] dsa: marvell: Add support for mv88e6071 and 6020 switches Andrew Lunn
2023-05-24 12:17 ` Lukasz Majewski
2023-05-24 12:37 ` Russell King (Oracle)
2023-05-24 13:48 ` Andrew Lunn
2023-05-29 9:02 ` Lukasz Majewski
2023-05-29 10:51 ` Vladimir Oltean
2023-05-29 11:03 ` Lukasz Majewski
2023-05-29 11:23 ` Vladimir Oltean
2023-05-29 14:16 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=357c733d-77fa-42e3-ba0c-ef6e50ff04ef@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukma@denx.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).