From: Lukasz Majewski <lukma@denx.de>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Russell King <linux@armlinux.org.uk>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 0/3] dsa: marvell: Add support for mv88e6071 and 6020 switches
Date: Mon, 29 May 2023 13:03:14 +0200 [thread overview]
Message-ID: <20230529130314.0d4c474e@wsk> (raw)
In-Reply-To: <20230529105132.h673mnjddubl7und@skbuf>
[-- Attachment #1: Type: text/plain, Size: 2561 bytes --]
Hi Vladimir,
> Hello Lukasz,
>
> On Mon, May 29, 2023 at 11:02:22AM +0200, Lukasz Majewski wrote:
> > Dear All,
> >
> > > After the commit (SHA1: 7e9517375a14f44ee830ca1c3278076dd65fcc8f);
> > > "net: dsa: mv88e6xxx: fix max_mtu of 1492 on 6165, 6191, 6220,
> > > 6250, 6290" the error when mv88e6020 or mv88e6071 is used is not
> > > present anymore.
> > >
> >
> > Are there any more comments for this patch set?
>
> Has your email client eaten these comments too?
>
> https://lore.kernel.org/netdev/c39f4127-e1fe-4d38-83eb-f372ca2ebcd3@lunn.ch/
> | On Wed, May 24, 2023 at 03:48:02PM +0200, Andrew Lunn wrote:
> | > > > Vladimir indicates here that it is not known how to change
> the max MTU | > > > for the MV88E6250. Where did you get the
> information from to implement | > > > it?
> | > >
> | > > Please refer to [1].
> | > >
> | > > The mv88e6185_g1_set_max_frame_size() function can be reused (as
> | > > registers' offsets and bits are the same for mv88e60{71|20}).
> | >
> | > So you have the datasheet? You get the information to implement
> this | > from the data sheet?
> | >
This I've replied to Andrew in a private mail.
> | > Andrew
>
> https://lore.kernel.org/netdev/ZG4E+wd03cKipsib@shell.armlinux.org.uk/
> | On Wed, May 24, 2023 at 01:37:15PM +0100, Russell King (Oracle)
> wrote: | > On Wed, May 24, 2023 at 02:17:43PM +0200, Lukasz Majewski
> wrote: | > > Please refer to [1].
> | > >
> | > > The mv88e6185_g1_set_max_frame_size() function can be reused (as
> | > > registers' offsets and bits are the same for mv88e60{71|20}).
> | > >
> | > > After using Vladimir's patch there is no need to add max_frame
> size | > > field and related patches from v6 can be dropped.
> | >
> | > However, you haven't responded to:
> | >
> | >
> https://lore.kernel.org/all/ZGzP0qEjQkCFnXnr@shell.armlinux.org.uk/ |
> > | > to explain why what you're doing (adding this function) is safe.
> | >
> | > Thanks.
> | >
The above question has been replied:
https://lore.kernel.org/all/20230524145357.3928f261@wsk/
> | > --
> | > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> | > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Do you have any more comments?
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-05-29 11:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 14:29 [PATCH v7 0/3] dsa: marvell: Add support for mv88e6071 and 6020 switches Lukasz Majewski
2023-05-23 14:29 ` [PATCH v7 1/3] dsa: marvell: Define .set_max_frame_size() function for mv88e6250 SoC family Lukasz Majewski
2023-05-23 14:38 ` Russell King (Oracle)
2023-05-24 12:53 ` Lukasz Majewski
2023-05-23 14:43 ` Russell King (Oracle)
2023-05-24 12:06 ` Lukasz Majewski
2023-05-24 12:08 ` Russell King (Oracle)
2023-05-23 14:29 ` [PATCH v7 2/3] net: dsa: mv88e6xxx: add support for MV88E6020 switch Lukasz Majewski
2023-05-23 14:29 ` [PATCH v7 3/3] net: dsa: mv88e6xxx: add support for MV88E6071 switch Lukasz Majewski
2023-05-23 17:37 ` Andrew Lunn
2023-05-23 17:26 ` [PATCH v7 0/3] dsa: marvell: Add support for mv88e6071 and 6020 switches Andrew Lunn
2023-05-24 12:17 ` Lukasz Majewski
2023-05-24 12:37 ` Russell King (Oracle)
2023-05-24 13:48 ` Andrew Lunn
2023-05-29 9:02 ` Lukasz Majewski
2023-05-29 10:51 ` Vladimir Oltean
2023-05-29 11:03 ` Lukasz Majewski [this message]
2023-05-29 11:23 ` Vladimir Oltean
2023-05-29 14:16 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230529130314.0d4c474e@wsk \
--to=lukma@denx.de \
--cc=alexander.duyck@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).