From: "Heiko Stübner" <heiko@sntech.de>
To: Peter Geis <pgwipeout@gmail.com>,
Jianqun Xu <jay.xu@rock-chips.com>,
huangtao@rock-chips.com, kever.yang@rock-chips.com,
linus.walleij@linaro.org, Johan Jonker <jbx6244@gmail.com>
Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] gpio: separate gpio driver from pinctrl-rockchip driver
Date: Sun, 11 Apr 2021 19:55:07 +0200 [thread overview]
Message-ID: <3591437.LM0AJKV5NW@diego> (raw)
In-Reply-To: <5308a59c-29e9-75a4-2c9a-4aeb3d37bf6e@gmail.com>
Hi Johan,
Am Sonntag, 11. April 2021, 19:51:52 CEST schrieb Johan Jonker:
> Hi,
>
> When I check "rockchip,gpio-bank" with YAML it turns out that
> rk3288-veyron-XXX has 'gpio-line-names' as 'extra' property.
> It is not defined in the "rockchip,pinctrl.txt" document, but in
> ~/.local/lib/python3.5/site-packages/dtschema/schemas/gpio/gpio.yaml
>
> Where is that in use?
> In this driver or external?
> Can it be removed from mainline dts?
gpio-line-names gets defined in devicetree/bindings/gpio/gpio.txt
which isn't converted to yaml yet:
Optionally, a GPIO controller may have a "gpio-line-names" property. This is
an array of strings defining the names of the GPIO lines going out of the
GPIO controller.
So that property is perfectly fine where it is.
Heiko
>
> Johan
>
> /arch/arm/boot/dts/rk3288-veyron-fievel.dt.yaml: gpio7@ff7e0000:
> 'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+'
> From schema:
> /Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
>
> On 4/11/21 3:30 PM, Peter Geis wrote:
> > From: Jianqun Xu <jay.xu@rock-chips.com>
> >
> > Separate the gpio driver from the pinctrl driver.
> >
> > Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
> > ---
>
next prev parent reply other threads:[~2021-04-11 17:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-11 13:30 [PATCH v2 0/7] gpio-rockchip driver Peter Geis
2021-04-11 13:30 ` [PATCH v2 1/7] pinctrl/rockchip: separate struct rockchip_pin_bank to a head file Peter Geis
2021-04-11 13:30 ` [PATCH v2 2/7] pinctrl/pinctrl-rockchip.h: add pinctrl device to gpio bank struct Peter Geis
2021-04-11 13:30 ` [PATCH v2 3/7] gpio: separate gpio driver from pinctrl-rockchip driver Peter Geis
2021-04-11 17:51 ` Johan Jonker
2021-04-11 17:55 ` Heiko Stübner [this message]
2021-04-11 17:58 ` Ezequiel Garcia
2021-04-13 9:48 ` Johan Jonker
2021-04-11 13:30 ` [PATCH v2 4/7] gpio/rockchip: use struct rockchip_gpio_regs for gpio controller Peter Geis
2021-04-11 13:30 ` [PATCH v2 5/7] gpio/rockchip: support next version " Peter Geis
2021-04-11 13:30 ` [PATCH v2 6/7] gpio/rockchip: always enable clock for " Peter Geis
2021-04-11 13:30 ` [PATCH v2 7/7] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type Peter Geis
2021-04-12 12:13 ` [PATCH v2 0/7] gpio-rockchip driver Andy Shevchenko
2021-04-12 13:30 ` Heiko Stübner
2021-04-12 13:33 ` Andy Shevchenko
2021-04-12 15:00 ` Peter Geis
2021-04-14 7:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3591437.LM0AJKV5NW@diego \
--to=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=jay.xu@rock-chips.com \
--cc=jbx6244@gmail.com \
--cc=kever.yang@rock-chips.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).