From: Neil Armstrong <neil.armstrong@linaro.org>
To: Johan Hovold <johan@kernel.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Johan Hovold <johan+linaro@kernel.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
dri-devel@lists.freedesktop.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] drm/meson: fix missing component unbind on bind errors
Date: Tue, 21 Mar 2023 14:27:08 +0100 [thread overview]
Message-ID: <35aa4401-8b35-09b5-9d97-59867d1df15c@linaro.org> (raw)
In-Reply-To: <ZBmtu4klxYwQyN7R@hovoldconsulting.com>
On 21/03/2023 14:14, Johan Hovold wrote:
> On Thu, Mar 09, 2023 at 10:41:18PM +0100, Martin Blumenstingl wrote:
>
>> On Mon, Mar 6, 2023 at 11:35 AM Johan Hovold <johan+linaro@kernel.org> wrote:
>> [...]
>>> @@ -325,23 +325,23 @@ static int meson_drv_bind_master(struct device *dev, bool has_components)
>>>
>>> ret = meson_encoder_hdmi_init(priv);
>
>> I'm wondering if component_bind_all() can be moved further down.
>> Right now it's between meson_encoder_cvbs_init() and
>> meson_encoder_hdmi_init(). So it seems that encoders don't rely on
>> component registration.
>
> Perhaps it can, but that would be a separate change (unless there is
> something inherently wrong with the current initialisation order).
The CVBS doesn't rely on any components unlike HDMI, this explains the
current position of component_bind_all().
>
>> Unfortunately I am also not familiar with this and I'm hoping that
>> Neil can comment on this.
>
> Any comments on this one, Neil?
Yep, components should be bind for HDMI encoder/bridge init.
Anyway for this patch, sorry for the delay, but it's looks fine:
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
>
> Johan
next prev parent reply other threads:[~2023-03-21 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 10:35 [PATCH] drm/meson: fix missing component unbind on bind errors Johan Hovold
2023-03-09 21:41 ` Martin Blumenstingl
2023-03-21 13:14 ` Johan Hovold
2023-03-21 13:27 ` Neil Armstrong [this message]
2023-03-21 13:33 ` Johan Hovold
2023-03-22 17:03 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35aa4401-8b35-09b5-9d97-59867d1df15c@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbrunet@baylibre.com \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).