From: Jason Yan <yanaijie@huawei.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
<sean.j.christopherson@intel.com>, <vkuznets@redhat.com>,
<wanpengli@tencent.com>, <jmattson@google.com>, <joro@8bytes.org>,
<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<x86@kernel.org>, <hpa@zytor.com>, <kvm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] x86/kvm: make steal_time static
Date: Thu, 16 Apr 2020 10:15:58 +0800 [thread overview]
Message-ID: <35c3890e-0c45-0dac-e9f0-f2a9446a387d@huawei.com> (raw)
In-Reply-To: <d1700173-29c1-2e7c-46bd-471876d96762@redhat.com>
在 2020/4/15 22:42, Paolo Bonzini 写道:
> On 15/04/20 10:49, Jason Yan wrote:
>> Fix the following sparse warning:
>>
>> arch/x86/kernel/kvm.c:58:1: warning: symbol '__pcpu_scope_steal_time'
>> was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
>> ---
>> arch/x86/kernel/kvm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
>> index 6efe0410fb72..f75010cde5d5 100644
>> --- a/arch/x86/kernel/kvm.c
>> +++ b/arch/x86/kernel/kvm.c
>> @@ -55,7 +55,7 @@ static int __init parse_no_stealacc(char *arg)
>> early_param("no-steal-acc", parse_no_stealacc);
>>
>> static DEFINE_PER_CPU_DECRYPTED(struct kvm_vcpu_pv_apf_data, apf_reason) __aligned(64);
>> -DEFINE_PER_CPU_DECRYPTED(struct kvm_steal_time, steal_time) __aligned(64) __visible;
>> +static DEFINE_PER_CPU_DECRYPTED(struct kvm_steal_time, steal_time) __aligned(64) __visible;
>> static int has_steal_clock = 0;
>>
>> /*
>>
>
> Queued, thanks.
>
Sorry that I found 14e581c381b9 ("x86/kvm: Make steal_time visible")
said that it is used by assembler code but I didn't find where.
Please drop this patch if it's true.
Sorry to make this trouble again.
Thanks,
Jason
> Paolo
>
>
> .
>
next prev parent reply other threads:[~2020-04-16 2:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 8:49 [PATCH] x86/kvm: make steal_time static Jason Yan
2020-04-15 14:42 ` Paolo Bonzini
2020-04-16 2:15 ` Jason Yan [this message]
2020-04-16 11:14 ` Paolo Bonzini
2020-04-15 20:29 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35c3890e-0c45-0dac-e9f0-f2a9446a387d@huawei.com \
--to=yanaijie@huawei.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=hulkci@huawei.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).