* [PATCH] crypto: nx: constify vio_device_id
@ 2017-08-17 13:14 Arvind Yadav
2017-08-17 13:14 ` [PATCH] crypto: nx: 842: " Arvind Yadav
2017-09-22 10:12 ` [PATCH] crypto: nx: " Herbert Xu
0 siblings, 2 replies; 4+ messages in thread
From: Arvind Yadav @ 2017-08-17 13:14 UTC (permalink / raw)
To: herbert, davem, benh, leosilva, pfsmorigo
Cc: linux-kernel, linux-crypto, linuxppc-dev
vio_device_id are not supposed to change at runtime. All functions
working with vio_device_id provided by <asm/vio.h> work with
const vio_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/crypto/nx/nx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/nx/nx.c b/drivers/crypto/nx/nx.c
index 036057a..3a5e31b 100644
--- a/drivers/crypto/nx/nx.c
+++ b/drivers/crypto/nx/nx.c
@@ -833,7 +833,7 @@ static void __exit nx_fini(void)
vio_unregister_driver(&nx_driver.viodriver);
}
-static struct vio_device_id nx_crypto_driver_ids[] = {
+static const struct vio_device_id nx_crypto_driver_ids[] = {
{ "ibm,sym-encryption-v1", "ibm,sym-encryption" },
{ "", "" }
};
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] crypto: nx: 842: constify vio_device_id
2017-08-17 13:14 [PATCH] crypto: nx: constify vio_device_id Arvind Yadav
@ 2017-08-17 13:14 ` Arvind Yadav
2017-09-22 10:12 ` Herbert Xu
2017-09-22 10:12 ` [PATCH] crypto: nx: " Herbert Xu
1 sibling, 1 reply; 4+ messages in thread
From: Arvind Yadav @ 2017-08-17 13:14 UTC (permalink / raw)
To: herbert, davem, benh, leosilva, pfsmorigo
Cc: linux-kernel, linux-crypto, linuxppc-dev
vio_device_id are not supposed to change at runtime. All functions
working with vio_device_id provided by <asm/vio.h> work with
const vio_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/crypto/nx/nx-842-pseries.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/nx/nx-842-pseries.c b/drivers/crypto/nx/nx-842-pseries.c
index cddc6d8..bf52cd1 100644
--- a/drivers/crypto/nx/nx-842-pseries.c
+++ b/drivers/crypto/nx/nx-842-pseries.c
@@ -1082,7 +1082,7 @@ static int nx842_remove(struct vio_dev *viodev)
return 0;
}
-static struct vio_device_id nx842_vio_driver_ids[] = {
+static const struct vio_device_id nx842_vio_driver_ids[] = {
{"ibm,compression-v1", "ibm,compression"},
{"", ""},
};
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: nx: constify vio_device_id
2017-08-17 13:14 [PATCH] crypto: nx: constify vio_device_id Arvind Yadav
2017-08-17 13:14 ` [PATCH] crypto: nx: 842: " Arvind Yadav
@ 2017-09-22 10:12 ` Herbert Xu
1 sibling, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2017-09-22 10:12 UTC (permalink / raw)
To: Arvind Yadav
Cc: davem, benh, leosilva, pfsmorigo, linux-kernel, linux-crypto,
linuxppc-dev
On Thu, Aug 17, 2017 at 06:44:10PM +0530, Arvind Yadav wrote:
> vio_device_id are not supposed to change at runtime. All functions
> working with vio_device_id provided by <asm/vio.h> work with
> const vio_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: nx: 842: constify vio_device_id
2017-08-17 13:14 ` [PATCH] crypto: nx: 842: " Arvind Yadav
@ 2017-09-22 10:12 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2017-09-22 10:12 UTC (permalink / raw)
To: Arvind Yadav
Cc: davem, benh, leosilva, pfsmorigo, linux-kernel, linux-crypto,
linuxppc-dev
On Thu, Aug 17, 2017 at 06:44:11PM +0530, Arvind Yadav wrote:
> vio_device_id are not supposed to change at runtime. All functions
> working with vio_device_id provided by <asm/vio.h> work with
> const vio_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-22 10:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-17 13:14 [PATCH] crypto: nx: constify vio_device_id Arvind Yadav
2017-08-17 13:14 ` [PATCH] crypto: nx: 842: " Arvind Yadav
2017-09-22 10:12 ` Herbert Xu
2017-09-22 10:12 ` [PATCH] crypto: nx: " Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).