* [RFC PATCH] ARM: dts: stm32f469-disco: use the same 3v3 for SD and DSI nodes
@ 2023-09-04 18:06 Dario Binacchi
2023-09-14 8:56 ` Alexandre TORGUE
0 siblings, 1 reply; 4+ messages in thread
From: Dario Binacchi @ 2023-09-04 18:06 UTC (permalink / raw)
To: linux-kernel
Cc: linux-amarula, Dario Binacchi, Alexandre Torgue, Conor Dooley,
Krzysztof Kozlowski, Maxime Coquelin, Rob Herring, devicetree,
linux-arm-kernel, linux-stm32
In the board schematic, the power supply for the SD card is the same 3.3
volts used to power the LCD panel and other peripherals. By generalizing
the name of the voltage regulator, it simplifies the device tree and makes
it more readable.
Link: https://www.st.com/en/evaluation-tools/32f469idiscovery.html#cad-resources
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
arch/arm/boot/dts/st/stm32f469-disco.dts | 15 ++++-----------
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/arch/arm/boot/dts/st/stm32f469-disco.dts b/arch/arm/boot/dts/st/stm32f469-disco.dts
index cbbd521bf010..8a4f8ddd083d 100644
--- a/arch/arm/boot/dts/st/stm32f469-disco.dts
+++ b/arch/arm/boot/dts/st/stm32f469-disco.dts
@@ -69,16 +69,9 @@ aliases {
serial0 = &usart3;
};
- mmc_vcard: mmc_vcard {
+ vcc_3v3: vcc-3v3 {
compatible = "regulator-fixed";
- regulator-name = "mmc_vcard";
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
- };
-
- vdd_dsi: vdd-dsi {
- compatible = "regulator-fixed";
- regulator-name = "vdd_dsi";
+ regulator-name = "vcc_3v3";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
};
@@ -164,7 +157,7 @@ panel@0 {
compatible = "orisetech,otm8009a";
reg = <0>; /* dsi virtual channel (0..3) */
reset-gpios = <&gpioh 7 GPIO_ACTIVE_LOW>;
- power-supply = <&vdd_dsi>;
+ power-supply = <&vcc_3v3>;
status = "okay";
port {
@@ -219,7 +212,7 @@ timer@2 {
&sdio {
status = "okay";
- vmmc-supply = <&mmc_vcard>;
+ vmmc-supply = <&vcc_3v3>;
cd-gpios = <&gpiog 2 GPIO_ACTIVE_LOW>;
broken-cd;
pinctrl-names = "default", "opendrain";
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RFC PATCH] ARM: dts: stm32f469-disco: use the same 3v3 for SD and DSI nodes
2023-09-04 18:06 [RFC PATCH] ARM: dts: stm32f469-disco: use the same 3v3 for SD and DSI nodes Dario Binacchi
@ 2023-09-14 8:56 ` Alexandre TORGUE
2023-10-23 11:00 ` Dario Binacchi
0 siblings, 1 reply; 4+ messages in thread
From: Alexandre TORGUE @ 2023-09-14 8:56 UTC (permalink / raw)
To: Dario Binacchi, linux-kernel
Cc: linux-amarula, Conor Dooley, Krzysztof Kozlowski,
Maxime Coquelin, Rob Herring, devicetree, linux-arm-kernel,
linux-stm32
On 9/4/23 20:06, Dario Binacchi wrote:
> In the board schematic, the power supply for the SD card is the same 3.3
> volts used to power the LCD panel and other peripherals. By generalizing
> the name of the voltage regulator, it simplifies the device tree and makes
> it more readable.
>
It makes sens as it is the same discret regulator (no pmic involved).
regards
Alex
> Link: https://www.st.com/en/evaluation-tools/32f469idiscovery.html#cad-resources
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>
> ---
>
> arch/arm/boot/dts/st/stm32f469-disco.dts | 15 ++++-----------
> 1 file changed, 4 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm/boot/dts/st/stm32f469-disco.dts b/arch/arm/boot/dts/st/stm32f469-disco.dts
> index cbbd521bf010..8a4f8ddd083d 100644
> --- a/arch/arm/boot/dts/st/stm32f469-disco.dts
> +++ b/arch/arm/boot/dts/st/stm32f469-disco.dts
> @@ -69,16 +69,9 @@ aliases {
> serial0 = &usart3;
> };
>
> - mmc_vcard: mmc_vcard {
> + vcc_3v3: vcc-3v3 {
> compatible = "regulator-fixed";
> - regulator-name = "mmc_vcard";
> - regulator-min-microvolt = <3300000>;
> - regulator-max-microvolt = <3300000>;
> - };
> -
> - vdd_dsi: vdd-dsi {
> - compatible = "regulator-fixed";
> - regulator-name = "vdd_dsi";
> + regulator-name = "vcc_3v3";
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> };
> @@ -164,7 +157,7 @@ panel@0 {
> compatible = "orisetech,otm8009a";
> reg = <0>; /* dsi virtual channel (0..3) */
> reset-gpios = <&gpioh 7 GPIO_ACTIVE_LOW>;
> - power-supply = <&vdd_dsi>;
> + power-supply = <&vcc_3v3>;
> status = "okay";
>
> port {
> @@ -219,7 +212,7 @@ timer@2 {
>
> &sdio {
> status = "okay";
> - vmmc-supply = <&mmc_vcard>;
> + vmmc-supply = <&vcc_3v3>;
> cd-gpios = <&gpiog 2 GPIO_ACTIVE_LOW>;
> broken-cd;
> pinctrl-names = "default", "opendrain";
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC PATCH] ARM: dts: stm32f469-disco: use the same 3v3 for SD and DSI nodes
2023-09-14 8:56 ` Alexandre TORGUE
@ 2023-10-23 11:00 ` Dario Binacchi
2023-11-08 13:38 ` Alexandre TORGUE
0 siblings, 1 reply; 4+ messages in thread
From: Dario Binacchi @ 2023-10-23 11:00 UTC (permalink / raw)
To: Alexandre TORGUE
Cc: linux-kernel, linux-amarula, Conor Dooley, Krzysztof Kozlowski,
Maxime Coquelin, Rob Herring, devicetree, linux-arm-kernel,
linux-stm32
Hello Alexandre,
On Thu, Sep 14, 2023 at 10:57 AM Alexandre TORGUE
<alexandre.torgue@foss.st.com> wrote:
>
> On 9/4/23 20:06, Dario Binacchi wrote:
> > In the board schematic, the power supply for the SD card is the same 3.3
> > volts used to power the LCD panel and other peripherals. By generalizing
> > the name of the voltage regulator, it simplifies the device tree and makes
> > it more readable.
> >
>
> It makes sens as it is the same discret regulator (no pmic involved).
>
I don't see it applied to linux-stm32/next. Is something missing?
Thanks and regards,
Dario
> regards
> Alex
>
> > Link: https://www.st.com/en/evaluation-tools/32f469idiscovery.html#cad-resources
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> >
> > ---
> >
> > arch/arm/boot/dts/st/stm32f469-disco.dts | 15 ++++-----------
> > 1 file changed, 4 insertions(+), 11 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/st/stm32f469-disco.dts b/arch/arm/boot/dts/st/stm32f469-disco.dts
> > index cbbd521bf010..8a4f8ddd083d 100644
> > --- a/arch/arm/boot/dts/st/stm32f469-disco.dts
> > +++ b/arch/arm/boot/dts/st/stm32f469-disco.dts
> > @@ -69,16 +69,9 @@ aliases {
> > serial0 = &usart3;
> > };
> >
> > - mmc_vcard: mmc_vcard {
> > + vcc_3v3: vcc-3v3 {
> > compatible = "regulator-fixed";
> > - regulator-name = "mmc_vcard";
> > - regulator-min-microvolt = <3300000>;
> > - regulator-max-microvolt = <3300000>;
> > - };
> > -
> > - vdd_dsi: vdd-dsi {
> > - compatible = "regulator-fixed";
> > - regulator-name = "vdd_dsi";
> > + regulator-name = "vcc_3v3";
> > regulator-min-microvolt = <3300000>;
> > regulator-max-microvolt = <3300000>;
> > };
> > @@ -164,7 +157,7 @@ panel@0 {
> > compatible = "orisetech,otm8009a";
> > reg = <0>; /* dsi virtual channel (0..3) */
> > reset-gpios = <&gpioh 7 GPIO_ACTIVE_LOW>;
> > - power-supply = <&vdd_dsi>;
> > + power-supply = <&vcc_3v3>;
> > status = "okay";
> >
> > port {
> > @@ -219,7 +212,7 @@ timer@2 {
> >
> > &sdio {
> > status = "okay";
> > - vmmc-supply = <&mmc_vcard>;
> > + vmmc-supply = <&vcc_3v3>;
> > cd-gpios = <&gpiog 2 GPIO_ACTIVE_LOW>;
> > broken-cd;
> > pinctrl-names = "default", "opendrain";
>
--
Dario Binacchi
Senior Embedded Linux Developer
dario.binacchi@amarulasolutions.com
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@amarulasolutions.com
www.amarulasolutions.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC PATCH] ARM: dts: stm32f469-disco: use the same 3v3 for SD and DSI nodes
2023-10-23 11:00 ` Dario Binacchi
@ 2023-11-08 13:38 ` Alexandre TORGUE
0 siblings, 0 replies; 4+ messages in thread
From: Alexandre TORGUE @ 2023-11-08 13:38 UTC (permalink / raw)
To: Dario Binacchi
Cc: linux-kernel, linux-amarula, Conor Dooley, Krzysztof Kozlowski,
Maxime Coquelin, Rob Herring, devicetree, linux-arm-kernel,
linux-stm32
Hi Dario
On 10/23/23 13:00, Dario Binacchi wrote:
> Hello Alexandre,
>
> On Thu, Sep 14, 2023 at 10:57 AM Alexandre TORGUE
> <alexandre.torgue@foss.st.com> wrote:
>>
>> On 9/4/23 20:06, Dario Binacchi wrote:
>>> In the board schematic, the power supply for the SD card is the same 3.3
>>> volts used to power the LCD panel and other peripherals. By generalizing
>>> the name of the voltage regulator, it simplifies the device tree and makes
>>> it more readable.
>>>
>>
>> It makes sens as it is the same discret regulator (no pmic involved).
>>
>
> I don't see it applied to linux-stm32/next. Is something missing?
ok, It is because the [RFC..] has been kept. Please resend by dropping it.
Cheers
Alex
>
> Thanks and regards,
> Dario
>
>> regards
>> Alex
>>
>>> Link: https://www.st.com/en/evaluation-tools/32f469idiscovery.html#cad-resources
>>> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>>>
>>> ---
>>>
>>> arch/arm/boot/dts/st/stm32f469-disco.dts | 15 ++++-----------
>>> 1 file changed, 4 insertions(+), 11 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/st/stm32f469-disco.dts b/arch/arm/boot/dts/st/stm32f469-disco.dts
>>> index cbbd521bf010..8a4f8ddd083d 100644
>>> --- a/arch/arm/boot/dts/st/stm32f469-disco.dts
>>> +++ b/arch/arm/boot/dts/st/stm32f469-disco.dts
>>> @@ -69,16 +69,9 @@ aliases {
>>> serial0 = &usart3;
>>> };
>>>
>>> - mmc_vcard: mmc_vcard {
>>> + vcc_3v3: vcc-3v3 {
>>> compatible = "regulator-fixed";
>>> - regulator-name = "mmc_vcard";
>>> - regulator-min-microvolt = <3300000>;
>>> - regulator-max-microvolt = <3300000>;
>>> - };
>>> -
>>> - vdd_dsi: vdd-dsi {
>>> - compatible = "regulator-fixed";
>>> - regulator-name = "vdd_dsi";
>>> + regulator-name = "vcc_3v3";
>>> regulator-min-microvolt = <3300000>;
>>> regulator-max-microvolt = <3300000>;
>>> };
>>> @@ -164,7 +157,7 @@ panel@0 {
>>> compatible = "orisetech,otm8009a";
>>> reg = <0>; /* dsi virtual channel (0..3) */
>>> reset-gpios = <&gpioh 7 GPIO_ACTIVE_LOW>;
>>> - power-supply = <&vdd_dsi>;
>>> + power-supply = <&vcc_3v3>;
>>> status = "okay";
>>>
>>> port {
>>> @@ -219,7 +212,7 @@ timer@2 {
>>>
>>> &sdio {
>>> status = "okay";
>>> - vmmc-supply = <&mmc_vcard>;
>>> + vmmc-supply = <&vcc_3v3>;
>>> cd-gpios = <&gpiog 2 GPIO_ACTIVE_LOW>;
>>> broken-cd;
>>> pinctrl-names = "default", "opendrain";
>>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-08 13:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-04 18:06 [RFC PATCH] ARM: dts: stm32f469-disco: use the same 3v3 for SD and DSI nodes Dario Binacchi
2023-09-14 8:56 ` Alexandre TORGUE
2023-10-23 11:00 ` Dario Binacchi
2023-11-08 13:38 ` Alexandre TORGUE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).