linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] Bluetooth: btusb: Add gpio reset way for qca btsoc in  cmd_timeout
@ 2021-09-16  8:41 tjiang
  2021-09-21  8:48 ` Marcel Holtmann
  0 siblings, 1 reply; 2+ messages in thread
From: tjiang @ 2021-09-16  8:41 UTC (permalink / raw)
  To: marcel, johan.hedberg, luiz.dentz
  Cc: linux-kernel, linux-bluetooth, linux-arm-msm, bgodavar, c-hbandi,
	hemantg, mka, rjliao, zijuhu, tjiang

if platform provide gpio connect to BT_EN reset pin of qca btsoc chip,
we can do hardware reset instead of usb port reset.

Signed-off-by: Tim Jiang <tjiang@codeaurora.org>
---
  drivers/bluetooth/btusb.c | 22 ++++++++++++++++++++++
  1 file changed, 22 insertions(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 8ef4e0f6e0bb..da85cc14f931 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -657,11 +657,33 @@ static void btusb_rtl_cmd_timeout(struct hci_dev 
*hdev)
  static void btusb_qca_cmd_timeout(struct hci_dev *hdev)
  {
  	struct btusb_data *data = hci_get_drvdata(hdev);
+	struct gpio_desc *reset_gpio = data->reset_gpio;
  	int err;

  	if (++data->cmd_timeout_cnt < 5)
  		return;

+	if (reset_gpio) {
+		bt_dev_err(hdev, "Reset qca device via bt_en gpio");
+
+		/* Toggle the hard reset line. The qca bt device is going to
+		 * yank itself off the USB and then replug. The cleanup is handled
+		 * correctly on the way out (standard USB disconnect), and the new
+		 * device is detected cleanly and bound to the driver again like
+		 * it should be.
+		 */
+		if (test_and_set_bit(BTUSB_HW_RESET_ACTIVE, &data->flags)) {
+			bt_dev_err(hdev, "last reset failed? Not resetting again");
+			return;
+		}
+
+		gpiod_set_value_cansleep(reset_gpio, 0);
+		msleep(200);
+		gpiod_set_value_cansleep(reset_gpio, 1);
+
+		return;
+	}
+
  	bt_dev_err(hdev, "Multiple cmd timeouts seen. Resetting usb device.");
  	/* This is not an unbalanced PM reference since the device will reset 
*/
  	err = usb_autopm_get_interface(data->intf);
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum, a Linux Foundation Collaborative Project

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] Bluetooth: btusb: Add gpio reset way for qca btsoc in  cmd_timeout
  2021-09-16  8:41 [PATCH v1] Bluetooth: btusb: Add gpio reset way for qca btsoc in cmd_timeout tjiang
@ 2021-09-21  8:48 ` Marcel Holtmann
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2021-09-21  8:48 UTC (permalink / raw)
  To: tjiang
  Cc: Johan Hedberg, Luiz Augusto von Dentz, open list,
	linux-bluetooth, MSM, Balakrishna Godavarthi, c-hbandi, Hemantg,
	Matthias Kaehlcke, Rocky Liao, zijuhu

Hi Tim,

> if platform provide gpio connect to BT_EN reset pin of qca btsoc chip,
> we can do hardware reset instead of usb port reset.
> 
> Signed-off-by: Tim Jiang <tjiang@codeaurora.org>
> ---
> drivers/bluetooth/btusb.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-21  8:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16  8:41 [PATCH v1] Bluetooth: btusb: Add gpio reset way for qca btsoc in cmd_timeout tjiang
2021-09-21  8:48 ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).