* Re: [PATCH -next] usb: typec: fusb302: Make fusb302_irq_work static
2019-03-20 14:12 [PATCH -next] usb: typec: fusb302: Make fusb302_irq_work static Yue Haibing
@ 2019-03-20 14:58 ` Guenter Roeck
2019-03-20 15:02 ` Heikki Krogerus
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2019-03-20 14:58 UTC (permalink / raw)
To: Yue Haibing; +Cc: heikki.krogerus, gregkh, linux-kernel, linux-usb
On Wed, Mar 20, 2019 at 10:12:02PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/usb/typec/tcpm/fusb302.c:1454:6: warning:
> symbol 'fusb302_irq_work' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/usb/typec/tcpm/fusb302.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 261b829..457fe7a 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1451,7 +1451,7 @@ static irqreturn_t fusb302_irq_intn(int irq, void *dev_id)
> return IRQ_HANDLED;
> }
>
> -void fusb302_irq_work(struct work_struct *work)
> +static void fusb302_irq_work(struct work_struct *work)
> {
> struct fusb302_chip *chip = container_of(work, struct fusb302_chip,
> irq_work);
> --
> 2.7.0
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] usb: typec: fusb302: Make fusb302_irq_work static
2019-03-20 14:12 [PATCH -next] usb: typec: fusb302: Make fusb302_irq_work static Yue Haibing
2019-03-20 14:58 ` Guenter Roeck
@ 2019-03-20 15:02 ` Heikki Krogerus
2019-03-20 19:25 ` Mukesh Ojha
2019-03-20 19:51 ` Mukesh Ojha
3 siblings, 0 replies; 5+ messages in thread
From: Heikki Krogerus @ 2019-03-20 15:02 UTC (permalink / raw)
To: Yue Haibing; +Cc: linux, gregkh, linux-kernel, linux-usb
On Wed, Mar 20, 2019 at 10:12:02PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/usb/typec/tcpm/fusb302.c:1454:6: warning:
> symbol 'fusb302_irq_work' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/fusb302.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 261b829..457fe7a 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1451,7 +1451,7 @@ static irqreturn_t fusb302_irq_intn(int irq, void *dev_id)
> return IRQ_HANDLED;
> }
>
> -void fusb302_irq_work(struct work_struct *work)
> +static void fusb302_irq_work(struct work_struct *work)
> {
> struct fusb302_chip *chip = container_of(work, struct fusb302_chip,
> irq_work);
thanks,
--
heikki
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] usb: typec: fusb302: Make fusb302_irq_work static
2019-03-20 14:12 [PATCH -next] usb: typec: fusb302: Make fusb302_irq_work static Yue Haibing
2019-03-20 14:58 ` Guenter Roeck
2019-03-20 15:02 ` Heikki Krogerus
@ 2019-03-20 19:25 ` Mukesh Ojha
2019-03-20 19:51 ` Mukesh Ojha
3 siblings, 0 replies; 5+ messages in thread
From: Mukesh Ojha @ 2019-03-20 19:25 UTC (permalink / raw)
To: Yue Haibing, linux, heikki.krogerus, gregkh; +Cc: linux-kernel, linux-usb
On 3/20/2019 7:42 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/usb/typec/tcpm/fusb302.c:1454:6: warning:
> symbol 'fusb302_irq_work' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/usb/typec/tcpm/fusb302.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 261b829..457fe7a 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1451,7 +1451,7 @@ static irqreturn_t fusb302_irq_intn(int irq, void *dev_id)
> return IRQ_HANDLED;
> }
>
> -void fusb302_irq_work(struct work_struct *work)
> +static void fusb302_irq_work(struct work_struct *work)
> {
> struct fusb302_chip *chip = container_of(work, struct fusb302_chip,
> irq_work);
Good to see the work on sparse warning as well.
Acked-by: Mukesh Ojha <mojha@codeaurora.org>
Thanks,
Mukesh
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] usb: typec: fusb302: Make fusb302_irq_work static
2019-03-20 14:12 [PATCH -next] usb: typec: fusb302: Make fusb302_irq_work static Yue Haibing
` (2 preceding siblings ...)
2019-03-20 19:25 ` Mukesh Ojha
@ 2019-03-20 19:51 ` Mukesh Ojha
3 siblings, 0 replies; 5+ messages in thread
From: Mukesh Ojha @ 2019-03-20 19:51 UTC (permalink / raw)
To: Yue Haibing, linux, heikki.krogerus, gregkh; +Cc: linux-kernel, linux-usb
On 3/20/2019 7:42 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/usb/typec/tcpm/fusb302.c:1454:6: warning:
> symbol 'fusb302_irq_work' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/usb/typec/tcpm/fusb302.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 261b829..457fe7a 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1451,7 +1451,7 @@ static irqreturn_t fusb302_irq_intn(int irq, void *dev_id)
> return IRQ_HANDLED;
> }
>
> -void fusb302_irq_work(struct work_struct *work)
> +static void fusb302_irq_work(struct work_struct *work)
> {
> struct fusb302_chip *chip = container_of(work, struct fusb302_chip,
> irq_work);
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
^ permalink raw reply [flat|nested] 5+ messages in thread