* [PATCH] memory: jz4780-nemc: build depend on OF
@ 2018-07-23 11:38 Corentin Labbe
2018-07-23 15:35 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Corentin Labbe @ 2018-07-23 11:38 UTC (permalink / raw)
To: Zubair.Kakakhel, gregkh, alex; +Cc: linux-kernel, Corentin Labbe
jz4780-nemc use of_ functions, so it needs to depend on OF
This fix the following build failure on x86
drivers/memory/jz4780-nemc.c: In function ‘jz4780_nemc_num_banks’:
drivers/memory/jz4780-nemc.c:72:10: error: implicit declaration of function ‘of_read_number’ [-Werror=implicit-function-declaration]
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
drivers/memory/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
index a642552..faa1a23 100644
--- a/drivers/memory/Kconfig
+++ b/drivers/memory/Kconfig
@@ -124,6 +124,7 @@ config JZ4780_NEMC
default y
depends on MACH_JZ4780 || COMPILE_TEST
depends on HAS_IOMEM
+ depends on OF
help
This driver is for the NAND/External Memory Controller (NEMC) in
the Ingenic JZ4780. This controller is used to handle external
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] memory: jz4780-nemc: build depend on OF
2018-07-23 11:38 [PATCH] memory: jz4780-nemc: build depend on OF Corentin Labbe
@ 2018-07-23 15:35 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2018-07-23 15:35 UTC (permalink / raw)
To: Corentin Labbe, Zubair.Kakakhel, gregkh, alex; +Cc: linux-kernel
On 07/23/2018 04:38 AM, Corentin Labbe wrote:
> jz4780-nemc use of_ functions, so it needs to depend on OF
>
> This fix the following build failure on x86
> drivers/memory/jz4780-nemc.c: In function ‘jz4780_nemc_num_banks’:
> drivers/memory/jz4780-nemc.c:72:10: error: implicit declaration of function ‘of_read_number’ [-Werror=implicit-function-declaration]
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> drivers/memory/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> index a642552..faa1a23 100644
> --- a/drivers/memory/Kconfig
> +++ b/drivers/memory/Kconfig
> @@ -124,6 +124,7 @@ config JZ4780_NEMC
> default y
> depends on MACH_JZ4780 || COMPILE_TEST
> depends on HAS_IOMEM
> + depends on OF
> help
> This driver is for the NAND/External Memory Controller (NEMC) in
> the Ingenic JZ4780. This controller is used to handle external
>
Duplicate of https://lore.kernel.org/lkml/20180721200049.7553-1-anders.roxell@linaro.org/
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-23 15:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-23 11:38 [PATCH] memory: jz4780-nemc: build depend on OF Corentin Labbe
2018-07-23 15:35 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).