From: "Heiko Stübner" <heiko@sntech.de>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: linux-kernel@vger.kernel.org,
Shawn Lin <shawn.lin@rock-chips.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] spi: rockchip: Signal unfinished DMA transfers
Date: Wed, 08 Jun 2016 14:26:51 +0200 [thread overview]
Message-ID: <3685265.1KrVuCJFto@diego> (raw)
In-Reply-To: <1465371171-20810-1-git-send-email-tomeu.vizoso@collabora.com>
Am Mittwoch, 8. Juni 2016, 09:32:51 schrieb Tomeu Vizoso:
> When using DMA, the transfer_one callback should return 1 because the
> transfer hasn't finished yet.
>
> A previous commit changed the function to return 0 when the DMA channels
> were correctly prepared.
>
> This manifested in Veyron boards with this message:
>
> [ 1.983605] cros-ec-spi spi0.0: EC failed to respond in time
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Fixes: ea9849113343 ("spi: rockchip: check return value of
> dmaengine_prep_slave_sg")
> Cc: Shawn Lin <shawn.lin@rock-chips.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Javier Martinez Canillas <javier@osg.samsung.com>
looks like Mark already applied it, but nevertheless I was able to verify that
this patch fixes the issue on my veyron jerry chromebook as well, so
Tested-by: Heiko Stuebner <heiko@sntech.de>
prev parent reply other threads:[~2016-06-08 12:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 7:32 [PATCH] spi: rockchip: Signal unfinished DMA transfers Tomeu Vizoso
2016-06-08 10:55 ` Mark Brown
2016-06-08 10:56 ` Applied "spi: rockchip: Signal unfinished DMA transfers" to the spi tree Mark Brown
2016-06-08 12:26 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3685265.1KrVuCJFto@diego \
--to=heiko@sntech.de \
--cc=broonie@kernel.org \
--cc=javier@osg.samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).