From: "Chen, Yu C" <yu.c.chen@intel.com>
To: "Zheng, Lv" <lv.zheng@intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"lenb@kernel.org" <lenb@kernel.org>,
"matthew.garrett@nebula.com" <matthew.garrett@nebula.com>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>
Subject: RE: [PATCH][v3] ACPI: Do not report _OSI("Darwin") when acpi_osi=!Darwin provided
Date: Mon, 22 Feb 2016 07:59:12 +0000 [thread overview]
Message-ID: <36DF59CE26D8EE47B0655C516E9CE640286C6882@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1AE640813FDE7649BE1B193DEA596E883BB4DAB4@SHSMSX101.ccr.corp.intel.com>
> -----Original Message-----
> From: Zheng, Lv
> Sent: Monday, February 22, 2016 3:57 PM
> To: Chen, Yu C; linux-acpi@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org; rjw@rjwysocki.net; lenb@kernel.org;
> matthew.garrett@nebula.com; andy.shevchenko@gmail.com; Chen, Yu C
> Subject: RE: [PATCH][v3] ACPI: Do not report _OSI("Darwin") when
> acpi_osi=!Darwin provided
>
> Hi, Yu
>
> > From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-
> > owner@vger.kernel.org] On Behalf Of Chen Yu
> > Subject: [PATCH][v3] ACPI: Do not report _OSI("Darwin") when
> > acpi_osi=!Darwin provided
> >
> > Commit 7bc5a2bad0b8 ("ACPI: Support _OSI("Darwin") correctly") always
> > reports positive value when Apple hardware queries _OSI("Darwin").
> > But sometimes the users might want to tell the hardware they don't
> > need the Darwin feature, for example, users may leverage the hardware
> > to power off the Thunderbolt, by appending acpi_osi=!Darwin in command
> > line, thus Apple hardware regards it as an incompatible OS X system,
> > hence turns off the Thunderbolt.
> [Lv Zheng]
> Both this patch and the original commit that is from Matthew look wrong to
> me.
> IMO, the feature should be done with an entirely different approach.
> Without test, I'm not sure if my comment is helpful for you.
> So could you let me take over to fix this issue?
>
Yes, sure, thanks.
yu
next prev parent reply other threads:[~2016-02-22 7:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 1:41 [PATCH][v3] ACPI: Do not report _OSI("Darwin") when acpi_osi=!Darwin provided Chen Yu
2016-02-22 7:57 ` Zheng, Lv
2016-02-22 7:59 ` Chen, Yu C [this message]
2016-02-22 8:55 ` Zheng, Lv
2016-03-14 14:17 ` Chen, Yu C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36DF59CE26D8EE47B0655C516E9CE640286C6882@shsmsx102.ccr.corp.intel.com \
--to=yu.c.chen@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=matthew.garrett@nebula.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).