From: Rodolfo Giometti <giometti@enneenne.com>
To: Yicong Yang <yangyicong@hisilicon.com>,
gregkh@linuxfoundation.org, jdelvare@suse.com,
linux@roeck-us.net, abbotti@mev.co.uk,
hsweeten@visionengravers.com, kw@linux.com, helgaas@kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-hwmon@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kbuild@vger.kernel.org, masahiroy@kernel.org,
michal.lkml@markovi.net
Cc: prime.zeng@huawei.com, linuxarm@openeuler.org
Subject: Re: [PATCH v2 3/4] pps: Use subdir-ccflags-* to inherit debug flag
Date: Tue, 9 Feb 2021 13:26:48 +0100 [thread overview]
Message-ID: <36b30ed8-a930-d1c3-2725-c6653f23490c@enneenne.com> (raw)
In-Reply-To: <1612868899-9185-4-git-send-email-yangyicong@hisilicon.com>
On 09/02/21 12:08, Yicong Yang wrote:
> From: Junhao He <hejunhao2@hisilicon.com>
>
> We use ccflags-$(CONFIG_PPS_DEBUG) for the debug
> message in drivers/pps, but the DEBUG flag will not pass to
> the subdirectory.
>
> Considering CONFIG_HWMON_DEBUG_CHIP intends to turn on debug
> recursively under driver/pps, so it will be clearer to use
> subdir-ccflags-* instead of ccflags-* to inherit
> the debug settings from Kconfig when traversing subdirectories.
>
> Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
> Signed-off-by: Junhao He <hejunhao2@hisilicon.com>
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
> ---
> drivers/pps/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pps/Makefile b/drivers/pps/Makefile
> index ceaf65c..7a2d3f7 100644
> --- a/drivers/pps/Makefile
> +++ b/drivers/pps/Makefile
> @@ -8,4 +8,4 @@ pps_core-$(CONFIG_NTP_PPS) += kc.o
> obj-$(CONFIG_PPS) := pps_core.o
> obj-y += clients/ generators/
>
> -ccflags-$(CONFIG_PPS_DEBUG) := -DDEBUG
> +subdir-ccflags-$(CONFIG_PPS_DEBUG) := -DDEBUG
>
Acked-by: Rodolfo Giometti <giometti@enneenne.com>
--
GNU/Linux Solutions e-mail: giometti@enneenne.com
Linux Device Driver giometti@linux.it
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti
next prev parent reply other threads:[~2021-02-09 12:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 11:08 [PATCH v2 0/4] Use subdir-ccflags-* to inherit debug flag Yicong Yang
2021-02-09 11:08 ` [PATCH v2 1/4] driver core: " Yicong Yang
2021-02-09 11:08 ` [PATCH v2 2/4] hwmon: " Yicong Yang
2021-02-09 15:06 ` Guenter Roeck
2021-02-10 9:42 ` Yicong Yang
2021-02-09 11:08 ` [PATCH v2 3/4] pps: " Yicong Yang
2021-02-09 12:26 ` Rodolfo Giometti [this message]
2021-02-09 11:08 ` [PATCH v2 4/4] staging: comedi: " Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36b30ed8-a930-d1c3-2725-c6653f23490c@enneenne.com \
--to=giometti@enneenne.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=hsweeten@visionengravers.com \
--cc=jdelvare@suse.com \
--cc=kw@linux.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxarm@openeuler.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=prime.zeng@huawei.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).