[PATCH] dt-bindings: leds: Add LED_FUNCTION_WAN_ONLINE for Internet access

[PATCH] dt-bindings: leds: Add LED_FUNCTION_WAN_ONLINE for Internet access

[Rafał Miłecki]

From: Rafał Miłecki <rafal@milecki.pl>

It's common for routers to have LED indicating link on the WAN port.

Some devices however have an extra LED that's meant to be used if WAN
connection is actually "online" (there is Internet access available).

It was suggested to add #define for such use case.

Link: https://lore.kernel.org/linux-devicetree/80e92209-5578-44e7-bd4b-603a29053ddf@collabora.com/T/#u
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 include/dt-bindings/leds/common.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
index c56785bb9c9c..ecea167930d9 100644
--- a/include/dt-bindings/leds/common.h
+++ b/include/dt-bindings/leds/common.h
@@ -100,6 +100,7 @@
 #define LED_FUNCTION_TX "tx"
 #define LED_FUNCTION_USB "usb"
 #define LED_FUNCTION_WAN "wan"
+#define LED_FUNCTION_WAN_ONLINE "wan-online"
 #define LED_FUNCTION_WLAN "wlan"
 #define LED_FUNCTION_WLAN_2GHZ "wlan-2ghz"
 #define LED_FUNCTION_WLAN_5GHZ "wlan-5ghz"
-- 
2.35.3

Re: [PATCH] dt-bindings: leds: Add LED_FUNCTION_WAN_ONLINE for Internet access

[AngeloGioacchino Del Regno]

Il 23/02/24 12:22, Rafał Miłecki ha scritto:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> It's common for routers to have LED indicating link on the WAN port.
> 
> Some devices however have an extra LED that's meant to be used if WAN
> connection is actually "online" (there is Internet access available).
> 
> It was suggested to add #define for such use case.

In this case, you can use the Suggested-by tag, but I'm not picky anyway :-)

> 
> Link: https://lore.kernel.org/linux-devicetree/80e92209-5578-44e7-bd4b-603a29053ddf@collabora.com/T/#u
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Re: (subset) [PATCH] dt-bindings: leds: Add LED_FUNCTION_WAN_ONLINE for Internet access

[Lee Jones]

On Fri, 23 Feb 2024 12:22:23 +0100, Rafał Miłecki wrote:
> It's common for routers to have LED indicating link on the WAN port.
> 
> Some devices however have an extra LED that's meant to be used if WAN
> connection is actually "online" (there is Internet access available).
> 
> It was suggested to add #define for such use case.
> 
> [...]

Applied, thanks!

[1/1] dt-bindings: leds: Add LED_FUNCTION_WAN_ONLINE for Internet access
      commit: c0ef9799df8756968c236720658e492fbe636064

--
Lee Jones [李琼斯]

Re: [PATCH] dt-bindings: leds: Add LED_FUNCTION_WAN_ONLINE for Internet access

[Linus Walleij]

On Fri, Feb 23, 2024 at 12:22 PM Rafał Miłecki <zajec5@gmail.com> wrote:

> From: Rafał Miłecki <rafal@milecki.pl>
>
> It's common for routers to have LED indicating link on the WAN port.
>
> Some devices however have an extra LED that's meant to be used if WAN
> connection is actually "online" (there is Internet access available).
>
> It was suggested to add #define for such use case.
>
> Link: https://lore.kernel.org/linux-devicetree/80e92209-5578-44e7-bd4b-603a29053ddf@collabora.com/T/#u
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

That looks helpful.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij