From: Marc Zyngier <marc.zyngier@arm.com>
To: Mason <slash.tmp@free.fr>, Thomas Gleixner <tglx@linutronix.de>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>,
David Laight <david.laight@aculab.com>,
linux-pci <linux-pci@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Thibaud Cornic <thibaud_cornic@sigmadesigns.com>,
Phuong Nguyen <phuong_nguyen@sigmadesigns.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v0.2] PCI: Add support for tango PCIe host bridge
Date: Wed, 12 Apr 2017 10:59:13 +0100 [thread overview]
Message-ID: <37cd6172-b04e-fcad-18fc-4fbb26cc611b@arm.com> (raw)
In-Reply-To: <241b130e-1fb7-ecd4-034e-eb02065ada66@free.fr>
On 12/04/17 10:50, Mason wrote:
> On 12/04/2017 10:08, Marc Zyngier wrote:
>
>> On 11/04/17 18:52, Mason wrote:
>>
>>> so data->irq is the virq (30, 34, 35, 36)
>>> and data->hwirq is the domain hwirq (0, 524288, 524289, 524290)
>>>
>>> Is there a way to map hwirq 524288 to MSI 0, hwirq 524289 to MSI 1, etc?
>>
>> Why would you need to do such a thing?
>> - In MSI domain: IRQ34 -> hwirq 524288
>> - In foo domain: IRQ34 -> hwirq [whatever your driver has allocated]
>>
>> The data is already there, at your fingertips. Just deal with with your
>> "foo" irqchip.
>
> OK, let me take a step back, I may have missed the forest for
> the trees.
>
> In my original code (copied from the Altera driver) I unmasked
> a given MSI in the tango_irq_domain_alloc() function. You said
> this was the wrong place, as it should be done in the irqchip
> unmask callback. Did I understand correctly, so far?
Yes.
> I have registered custom mask/unmask callbacks for both irq_chips.
And that's *wrong*. I've repeatedly said that you only need to deal with
*your* irqchip. End of story. Nowhere else. Please leave the MSI irqchip
alone, it is very unlikely that you have to provide anything at all to it.
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2017-04-12 9:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 13:05 [RFC PATCH v0.2] PCI: Add support for tango PCIe host bridge Mason
2017-03-23 14:22 ` Marc Zyngier
2017-03-23 17:03 ` Mason
2017-03-23 23:40 ` Mason
2017-03-24 18:22 ` Marc Zyngier
2017-03-27 14:35 ` Mason
2017-03-27 14:46 ` Thomas Gleixner
2017-03-27 15:18 ` Mason
2017-03-24 18:47 ` Marc Zyngier
2017-03-27 15:53 ` Mason
2017-03-27 17:09 ` Marc Zyngier
2017-03-27 19:44 ` Mason
2017-03-27 21:07 ` Marc Zyngier
2017-03-27 22:04 ` Mason
2017-03-28 8:21 ` Marc Zyngier
2017-04-11 15:13 ` Mason
2017-04-11 15:49 ` Marc Zyngier
2017-04-11 16:26 ` Mason
2017-04-11 16:43 ` Marc Zyngier
2017-04-11 17:52 ` Mason
2017-04-12 8:08 ` Marc Zyngier
2017-04-12 9:50 ` Mason
2017-04-12 9:59 ` Marc Zyngier [this message]
2017-04-19 11:19 ` Mason
2017-04-20 8:20 ` Mason
2017-04-20 9:43 ` Marc Zyngier
2017-03-29 11:39 ` Mason
2017-03-30 11:09 ` Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37cd6172-b04e-fcad-18fc-4fbb26cc611b@arm.com \
--to=marc.zyngier@arm.com \
--cc=david.laight@aculab.com \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=phuong_nguyen@sigmadesigns.com \
--cc=robin.murphy@arm.com \
--cc=slash.tmp@free.fr \
--cc=tglx@linutronix.de \
--cc=thibaud_cornic@sigmadesigns.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).