From: <Claudiu.Beznea@microchip.com>
To: <alexandre.belloni@bootlin.com>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <Nicolas.Ferre@microchip.com>,
<Ludovic.Desroches@microchip.com>
Cc: <linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: at91: sam9x60: remove atmel,osc-bypass support
Date: Wed, 2 Dec 2020 13:38:56 +0000 [thread overview]
Message-ID: <37d33058-f766-4afb-3948-da04f95925d0@microchip.com> (raw)
In-Reply-To: <20201202125816.168618-1-alexandre.belloni@bootlin.com>
On 02.12.2020 14:58, Alexandre Belloni wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The sam9x60 doesn't have the MOSCXTBY bit to enable the crystal oscillator
> bypass.
>
> Fixes: 01e2113de9a5 ("clk: at91: add sam9x60 pmc driver")
> Reported-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Tested-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> drivers/clk/at91/sam9x60.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c
> index 3c4c95603595..c8cbec5308f0 100644
> --- a/drivers/clk/at91/sam9x60.c
> +++ b/drivers/clk/at91/sam9x60.c
> @@ -174,7 +174,6 @@ static void __init sam9x60_pmc_setup(struct device_node *np)
> struct regmap *regmap;
> struct clk_hw *hw;
> int i;
> - bool bypass;
>
> i = of_property_match_string(np, "clock-names", "td_slck");
> if (i < 0)
> @@ -209,10 +208,7 @@ static void __init sam9x60_pmc_setup(struct device_node *np)
> if (IS_ERR(hw))
> goto err_free;
>
> - bypass = of_property_read_bool(np, "atmel,osc-bypass");
> -
> - hw = at91_clk_register_main_osc(regmap, "main_osc", mainxtal_name,
> - bypass);
> + hw = at91_clk_register_main_osc(regmap, "main_osc", mainxtal_name, 0);
> if (IS_ERR(hw))
> goto err_free;
> main_osc_hw = hw;
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-12-02 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 12:58 [PATCH] clk: at91: sam9x60: remove atmel,osc-bypass support Alexandre Belloni
2020-12-02 13:38 ` Claudiu.Beznea [this message]
2020-12-19 23:32 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37d33058-f766-4afb-3948-da04f95925d0@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).