* [PATCH] clk: at91: sam9x60: remove atmel,osc-bypass support
@ 2020-12-02 12:58 Alexandre Belloni
2020-12-02 13:38 ` Claudiu.Beznea
2020-12-19 23:32 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Alexandre Belloni @ 2020-12-02 12:58 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Nicolas Ferre,
Alexandre Belloni, Ludovic Desroches
Cc: Claudiu Beznea, linux-clk, linux-arm-kernel, linux-kernel
The sam9x60 doesn't have the MOSCXTBY bit to enable the crystal oscillator
bypass.
Fixes: 01e2113de9a5 ("clk: at91: add sam9x60 pmc driver")
Reported-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
drivers/clk/at91/sam9x60.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c
index 3c4c95603595..c8cbec5308f0 100644
--- a/drivers/clk/at91/sam9x60.c
+++ b/drivers/clk/at91/sam9x60.c
@@ -174,7 +174,6 @@ static void __init sam9x60_pmc_setup(struct device_node *np)
struct regmap *regmap;
struct clk_hw *hw;
int i;
- bool bypass;
i = of_property_match_string(np, "clock-names", "td_slck");
if (i < 0)
@@ -209,10 +208,7 @@ static void __init sam9x60_pmc_setup(struct device_node *np)
if (IS_ERR(hw))
goto err_free;
- bypass = of_property_read_bool(np, "atmel,osc-bypass");
-
- hw = at91_clk_register_main_osc(regmap, "main_osc", mainxtal_name,
- bypass);
+ hw = at91_clk_register_main_osc(regmap, "main_osc", mainxtal_name, 0);
if (IS_ERR(hw))
goto err_free;
main_osc_hw = hw;
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: at91: sam9x60: remove atmel,osc-bypass support
2020-12-02 12:58 [PATCH] clk: at91: sam9x60: remove atmel,osc-bypass support Alexandre Belloni
@ 2020-12-02 13:38 ` Claudiu.Beznea
2020-12-19 23:32 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Claudiu.Beznea @ 2020-12-02 13:38 UTC (permalink / raw)
To: alexandre.belloni, mturquette, sboyd, Nicolas.Ferre, Ludovic.Desroches
Cc: linux-clk, linux-arm-kernel, linux-kernel
On 02.12.2020 14:58, Alexandre Belloni wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The sam9x60 doesn't have the MOSCXTBY bit to enable the crystal oscillator
> bypass.
>
> Fixes: 01e2113de9a5 ("clk: at91: add sam9x60 pmc driver")
> Reported-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Tested-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> drivers/clk/at91/sam9x60.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c
> index 3c4c95603595..c8cbec5308f0 100644
> --- a/drivers/clk/at91/sam9x60.c
> +++ b/drivers/clk/at91/sam9x60.c
> @@ -174,7 +174,6 @@ static void __init sam9x60_pmc_setup(struct device_node *np)
> struct regmap *regmap;
> struct clk_hw *hw;
> int i;
> - bool bypass;
>
> i = of_property_match_string(np, "clock-names", "td_slck");
> if (i < 0)
> @@ -209,10 +208,7 @@ static void __init sam9x60_pmc_setup(struct device_node *np)
> if (IS_ERR(hw))
> goto err_free;
>
> - bypass = of_property_read_bool(np, "atmel,osc-bypass");
> -
> - hw = at91_clk_register_main_osc(regmap, "main_osc", mainxtal_name,
> - bypass);
> + hw = at91_clk_register_main_osc(regmap, "main_osc", mainxtal_name, 0);
> if (IS_ERR(hw))
> goto err_free;
> main_osc_hw = hw;
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: at91: sam9x60: remove atmel,osc-bypass support
2020-12-02 12:58 [PATCH] clk: at91: sam9x60: remove atmel,osc-bypass support Alexandre Belloni
2020-12-02 13:38 ` Claudiu.Beznea
@ 2020-12-19 23:32 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2020-12-19 23:32 UTC (permalink / raw)
To: Alexandre Belloni, Ludovic Desroches, Michael Turquette, Nicolas Ferre
Cc: Claudiu Beznea, linux-clk, linux-arm-kernel, linux-kernel
Quoting Alexandre Belloni (2020-12-02 04:58:15)
> The sam9x60 doesn't have the MOSCXTBY bit to enable the crystal oscillator
> bypass.
>
> Fixes: 01e2113de9a5 ("clk: at91: add sam9x60 pmc driver")
> Reported-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-19 23:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-02 12:58 [PATCH] clk: at91: sam9x60: remove atmel,osc-bypass support Alexandre Belloni
2020-12-02 13:38 ` Claudiu.Beznea
2020-12-19 23:32 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).