From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xen.org
Cc: linux-kernel@vger.kernel.org, jgross@suse.com,
Stefano Stabellini <stefano@aporeto.com>
Subject: Re: [PATCH v3 08/13] xen/pvcalls: implement accept command
Date: Mon, 14 Aug 2017 22:04:59 -0400 [thread overview]
Message-ID: <37d72529-c8d4-96e1-422c-342a19af9055@oracle.com> (raw)
In-Reply-To: <1a368546-fec3-7f10-cc1b-296e095c9ba1@oracle.com>
>> +
>> + ret = bedata->rsp[req_id].ret;
>
> You can just return bedata->rsp[req_id].ret;
Or maybe not. The slot may get reused by the time you get to the end.
-boris
>
> -boris
>
>> + /* read ret, then set this rsp slot to be reused */
>> + smp_mb();
>> + WRITE_ONCE(bedata->rsp[req_id].req_id, PVCALLS_INVALID_ID);
>> + WRITE_ONCE(map->passive.inflight_req_id, PVCALLS_INVALID_ID);
>> + return ret;
>> +}
next prev parent reply other threads:[~2017-08-15 2:05 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 22:57 [PATCH v3 00/13] introduce the Xen PV Calls frontend Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 01/13] xen/pvcalls: introduce the pvcalls xenbus frontend Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 02/13] xen/pvcalls: implement frontend disconnect Stefano Stabellini
2017-08-11 22:43 ` Boris Ostrovsky
2017-09-09 0:07 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 03/13] xen/pvcalls: connect to the backend Stefano Stabellini
2017-08-11 22:55 ` Boris Ostrovsky
2017-09-09 0:14 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 04/13] xen/pvcalls: implement socket command and handle events Stefano Stabellini
2017-08-13 0:42 ` Boris Ostrovsky
2017-09-08 23:20 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 05/13] xen/pvcalls: implement connect command Stefano Stabellini
2017-08-13 1:12 ` Boris Ostrovsky
2017-09-08 21:23 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 06/13] xen/pvcalls: implement bind command Stefano Stabellini
2017-08-13 1:22 ` Boris Ostrovsky
2017-09-08 21:46 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 07/13] xen/pvcalls: implement listen command Stefano Stabellini
2017-08-13 1:28 ` Boris Ostrovsky
2017-07-31 22:57 ` [PATCH v3 08/13] xen/pvcalls: implement accept command Stefano Stabellini
2017-08-15 2:00 ` Boris Ostrovsky
2017-08-15 2:04 ` Boris Ostrovsky [this message]
2017-09-08 21:58 ` Stefano Stabellini
2017-09-08 22:16 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 09/13] xen/pvcalls: implement sendmsg Stefano Stabellini
2017-08-15 2:31 ` Boris Ostrovsky
2017-09-08 23:48 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 10/13] xen/pvcalls: implement recvmsg Stefano Stabellini
2017-08-15 2:39 ` Boris Ostrovsky
2017-09-08 23:11 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 11/13] xen/pvcalls: implement poll command Stefano Stabellini
2017-08-15 20:30 ` Boris Ostrovsky
2017-09-08 23:03 ` Stefano Stabellini
2017-09-12 14:14 ` Boris Ostrovsky
2017-09-12 22:17 ` Stefano Stabellini
2017-09-12 23:04 ` Boris Ostrovsky
2017-09-12 23:13 ` Stefano Stabellini
2017-09-12 23:18 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 12/13] xen/pvcalls: implement release command Stefano Stabellini
2017-08-15 20:44 ` Boris Ostrovsky
2017-09-08 23:09 ` Stefano Stabellini
2017-07-31 22:57 ` [PATCH v3 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend Stefano Stabellini
2017-08-11 22:36 ` [PATCH v3 01/13] xen/pvcalls: introduce the pvcalls xenbus frontend Boris Ostrovsky
2017-08-10 15:07 ` [PATCH v3 00/13] introduce the Xen PV Calls frontend Boris Ostrovsky
2017-08-10 18:15 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37d72529-c8d4-96e1-422c-342a19af9055@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=stefano@aporeto.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).