* [PATCH 1/2 linux-next] gfs2: check rename2 flags at once
@ 2017-05-03 18:27 Fabian Frederick
2017-05-04 13:28 ` Bob Peterson
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2017-05-03 18:27 UTC (permalink / raw)
To: Steven Whitehouse, Bob Peterson
Cc: cluster-devel, linux-fsdevel, linux-kernel, fabf
There's no need to update flags in gfs2_rename2()
This will ease whiteout addition.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
fs/gfs2/inode.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 9f605ea..9698796 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -1706,9 +1706,7 @@ static int gfs2_rename2(struct inode *odir, struct dentry *odentry,
struct inode *ndir, struct dentry *ndentry,
unsigned int flags)
{
- flags &= ~RENAME_NOREPLACE;
-
- if (flags & ~RENAME_EXCHANGE)
+ if (flags & ~(RENAME_NOREPLACE | RENAME_EXCHANGE))
return -EINVAL;
if (flags & RENAME_EXCHANGE)
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2 linux-next] gfs2: check rename2 flags at once
2017-05-03 18:27 [PATCH 1/2 linux-next] gfs2: check rename2 flags at once Fabian Frederick
@ 2017-05-04 13:28 ` Bob Peterson
0 siblings, 0 replies; 2+ messages in thread
From: Bob Peterson @ 2017-05-04 13:28 UTC (permalink / raw)
To: Fabian Frederick
Cc: Steven Whitehouse, cluster-devel, linux-fsdevel, linux-kernel
----- Original Message -----
| There's no need to update flags in gfs2_rename2()
| This will ease whiteout addition.
|
| Signed-off-by: Fabian Frederick <fabf@skynet.be>
| ---
Hi Fabian,
Your patches look good. I'll push them to the for-next branch of our
repo after the merge window is closed.
Regards,
Bob Peterson
Red Hat File Systems
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-04 13:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-03 18:27 [PATCH 1/2 linux-next] gfs2: check rename2 flags at once Fabian Frederick
2017-05-04 13:28 ` Bob Peterson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).