From: Sander Vanheule <sander@svanheule.net>
To: Yury Norov <yury.norov@gmail.com>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Brendan Higgins" <brendan.higgins@linux.dev>,
"David Gow" <davidgow@google.com>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
"Maíra Canal" <mairacanal@riseup.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/5] cpumask: KUnit test suite fixes and improvements
Date: Sun, 21 Aug 2022 15:25:54 +0200 [thread overview]
Message-ID: <38507e4b4ab6972fa76d32d74da1911d6c4224d3.camel@svanheule.net> (raw)
In-Reply-To: <YwFa0xiM/b0N5X0w@yury-laptop>
Hi Yury,
On Sat, 2022-08-20 at 15:06 -0700, Yury Norov wrote:
> On Sat, Aug 20, 2022 at 05:03:08PM +0200, Sander Vanheule wrote:
> > This series fixes the reported issues, and implements the suggested
> > improvements, for the version of the cpumask tests [1] that was merged
> > with commit c41e8866c28c ("lib/test: introduce cpumask KUnit test
> > suite").
> >
> > These changes include fixes for the tests, and better alignment with the
> > KUnit style guidelines.
>
> I wrote a couple comments, but the series looks OK to me in general.
> So for 2, 3 and 5:
> Acked-by: Yury Norov <yury.norov@gmail.com>
>
> It's named as 'fix', but it fixes a test, and the kernel code itself
> looks correct. So, do you want to take it into 6.0-rc, or in 6.1?
>
> I'm OK to do it this way or another, but for later -rc's it may look
> too noisy. And I'm not sure where to put a threshold.
Broken tests are worse than no tests IMHO, so I would at least like patches 1
and 2 to be merged for 6.0-rc. I don't want people to end up with false
positives, like Maíra did, for an entire release cycle.
Preferably I would also like to see 3 in 6.0-rc, so no renames will be needed in
6.1 anymore. Not that I expect anything to depend on this symbol (or filename)
by then, but I feel it's better not to risk that by waiting for 6.1.
Patches 4 and 5 can go with 6.1, as far as I'm concerned. Especially as the mask
logging patch (4) may need some work still.
Best,
Sander
prev parent reply other threads:[~2022-08-21 13:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 15:03 [PATCH v2 0/5] cpumask: KUnit test suite fixes and improvements Sander Vanheule
2022-08-20 15:03 ` [PATCH v2 1/5] lib/test_cpumask: drop cpu_possible_mask full test Sander Vanheule
2022-08-20 21:35 ` Yury Norov
2022-08-21 13:08 ` Sander Vanheule
[not found] ` <CAAH8bW9yZUMn2shYAB1LaDyzgFMYtWCRUXxq=bMCiFys=gzKig@mail.gmail.com>
2022-08-21 13:27 ` Sander Vanheule
2022-08-20 15:03 ` [PATCH v2 2/5] lib/test_cpumask: fix cpu_possible_mask last test Sander Vanheule
2022-08-20 15:03 ` [PATCH v2 3/5] lib/test_cpumask: follow KUnit style guidelines Sander Vanheule
2022-08-20 15:03 ` [PATCH v2 4/5] lib/cpumask_kunit: log mask contents Sander Vanheule
2022-08-20 21:46 ` Yury Norov
2022-08-21 13:13 ` Sander Vanheule
2022-08-21 14:02 ` Maíra Canal
2022-08-21 16:39 ` Sander Vanheule
2022-08-20 15:03 ` [PATCH v2 5/5] lib/cpumask_kunit: add tests file to MAINTAINERS Sander Vanheule
2022-08-20 22:06 ` [PATCH v2 0/5] cpumask: KUnit test suite fixes and improvements Yury Norov
2022-08-21 13:25 ` Sander Vanheule [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38507e4b4ab6972fa76d32d74da1911d6c4224d3.camel@svanheule.net \
--to=sander@svanheule.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mairacanal@riseup.net \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).