* [PATCH] ACPI: event: replace strcpy() by strscpy()
@ 2019-04-22 16:39 Gustavo A. R. Silva
2019-05-01 10:12 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2019-04-22 16:39 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown
Cc: linux-acpi, linux-kernel, Gustavo A. R. Silva
The strcpy() function is being deprecated. Replace it by the safer
strscpy() and fix the following Coverity warnings:
"You might overrun the 15-character fixed-size string event->bus_id
by copying bus_id without checking the length."
"You might overrun the 20-character fixed-size string event->device_class
by copying device_class without checking the length."
Addresses-Coverity-ID: 139001 ("Copy into fixed size buffer")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/acpi/event.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/event.c b/drivers/acpi/event.c
index 5a127f3f2d5c..47f21599f2ab 100644
--- a/drivers/acpi/event.c
+++ b/drivers/acpi/event.c
@@ -131,8 +131,8 @@ int acpi_bus_generate_netlink_event(const char *device_class,
event = nla_data(attr);
memset(event, 0, sizeof(struct acpi_genl_event));
- strcpy(event->device_class, device_class);
- strcpy(event->bus_id, bus_id);
+ strscpy(event->device_class, device_class, sizeof(event->device_class));
+ strscpy(event->bus_id, bus_id, sizeof(event->bus_id));
event->type = type;
event->data = data;
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPI: event: replace strcpy() by strscpy()
2019-04-22 16:39 [PATCH] ACPI: event: replace strcpy() by strscpy() Gustavo A. R. Silva
@ 2019-05-01 10:12 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2019-05-01 10:12 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Len Brown, linux-acpi, linux-kernel
On Monday, April 22, 2019 6:39:34 PM CEST Gustavo A. R. Silva wrote:
> The strcpy() function is being deprecated. Replace it by the safer
> strscpy() and fix the following Coverity warnings:
>
> "You might overrun the 15-character fixed-size string event->bus_id
> by copying bus_id without checking the length."
>
> "You might overrun the 20-character fixed-size string event->device_class
> by copying device_class without checking the length."
>
> Addresses-Coverity-ID: 139001 ("Copy into fixed size buffer")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/acpi/event.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/event.c b/drivers/acpi/event.c
> index 5a127f3f2d5c..47f21599f2ab 100644
> --- a/drivers/acpi/event.c
> +++ b/drivers/acpi/event.c
> @@ -131,8 +131,8 @@ int acpi_bus_generate_netlink_event(const char *device_class,
> event = nla_data(attr);
> memset(event, 0, sizeof(struct acpi_genl_event));
>
> - strcpy(event->device_class, device_class);
> - strcpy(event->bus_id, bus_id);
> + strscpy(event->device_class, device_class, sizeof(event->device_class));
> + strscpy(event->bus_id, bus_id, sizeof(event->bus_id));
> event->type = type;
> event->data = data;
>
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-01 10:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-22 16:39 [PATCH] ACPI: event: replace strcpy() by strscpy() Gustavo A. R. Silva
2019-05-01 10:12 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).