From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: taozha@codeaurora.org
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Tingwei Zhang <tingwei@codeaurora.org>,
Mao Jinlong <jinlmao@codeaurora.org>,
Yuanfang Zhang <zhangyuanfang@codeaurora.org>
Subject: Re: [PATCH v1] coresight: add node to reset all coresight devices
Date: Wed, 28 Apr 2021 11:09:19 +0100 [thread overview]
Message-ID: <38865567-8557-e48d-779b-ca257e318c19@arm.com> (raw)
In-Reply-To: <4036d63a8759ac67a26fd8798b9adf6b@codeaurora.org>
On 28/04/2021 10:57, taozha@codeaurora.org wrote:
> On 2021-04-23 21:20, Suzuki K Poulose wrote:
>> On 23/04/2021 09:29, Tao Zhang wrote:
>>> Add new reset_source_sink node to be able to disable all active
>>> coresight devices.
>>> In this way, we no longer need to manually disable all active
>>> coresight devices one by one. After enabling multiple coresight
>>> paths, users can reset their status more conveniently by this
>>> node.
>>>
>>
>> What is the use case here ? Why would you trigger a reset for all the
>> sources/sink without gracefully completing any on-going sessions
>> (including the perf ones, which are driven by the kernel perf layer)
>>
> We have a tool needs a command that could reset all active devices.
> Since the tool cannot what dvices are activated, we add this new node
> to sysFS for our tool could reset all active device by one command.
> We hope that this patch can also provide a more convenient option
> for the other users with the same needs.
There is sysfs handles to do this already. See the testcase under perf,
e.g, that can walk the sysfs and figure out the source devices and the
"sinks" that can be reached from the given device.
If some information is missing, to achieve this. we could provide that.
But simply because a tool wants to do something without bothering to use
the provided ABI, is not a justification to add something to the kernel.
Suzuki
prev parent reply other threads:[~2021-04-28 10:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 8:29 [PATCH v1] coresight: add node to reset all coresight devices Tao Zhang
2021-04-23 10:02 ` Greg Kroah-Hartman
2021-04-28 9:58 ` taozha
2021-04-23 13:20 ` Suzuki K Poulose
2021-04-28 9:57 ` taozha
2021-04-28 10:09 ` Suzuki K Poulose [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38865567-8557-e48d-779b-ca257e318c19@arm.com \
--to=suzuki.poulose@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jinlmao@codeaurora.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=taozha@codeaurora.org \
--cc=tingwei@codeaurora.org \
--cc=zhangyuanfang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).