From: taozha@codeaurora.org
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Tingwei Zhang <tingwei@codeaurora.org>,
Mao Jinlong <jinlmao@codeaurora.org>,
Yuanfang Zhang <zhangyuanfang@codeaurora.org>
Subject: Re: [PATCH v1] coresight: add node to reset all coresight devices
Date: Wed, 28 Apr 2021 17:58:34 +0800 [thread overview]
Message-ID: <5d9d5127a2f3e42380c78f77cfc719cd@codeaurora.org> (raw)
In-Reply-To: <YIKbJ/WafuFnqGvr@kroah.com>
On 2021-04-23 18:02, Greg Kroah-Hartman wrote:
> On Fri, Apr 23, 2021 at 04:29:38PM +0800, Tao Zhang wrote:
>> Add new reset_source_sink node to be able to disable all active
>> coresight devices.
>> In this way, we no longer need to manually disable all active
>> coresight devices one by one. After enabling multiple coresight
>> paths, users can reset their status more conveniently by this
>> node.
>>
>> This patch base on coresight-next repo
>> http://git.linaro.org/kernel/coresight.git/log/?h=next
>>
>> And this patch depends on the following patch
>> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2551216.html
>>
>> Signed-off-by: Tingwei Zhang <tingwei@codeaurora.org>
>> Signed-off-by: Mao Jinlong <jinlmao@codeaurora.org>
>> Signed-off-by: Tao Zhang <taozha@codeaurora.org>
>> ---
>> drivers/hwtracing/coresight/coresight-core.c | 72
>> ++++++++++++++++++++++++----
>> 1 file changed, 64 insertions(+), 8 deletions(-)
>
> You added new sysfs files with no new Documentation/ABI entries, so we
> have no idea how to review this code to determine if it does what you
> want it to do :(
>
> thanks,
>
> greg k-h
I will update this part according to your suggestion in patch v2.
Best,
Tao
next prev parent reply other threads:[~2021-04-28 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 8:29 [PATCH v1] coresight: add node to reset all coresight devices Tao Zhang
2021-04-23 10:02 ` Greg Kroah-Hartman
2021-04-28 9:58 ` taozha [this message]
2021-04-23 13:20 ` Suzuki K Poulose
2021-04-28 9:57 ` taozha
2021-04-28 10:09 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d9d5127a2f3e42380c78f77cfc719cd@codeaurora.org \
--to=taozha@codeaurora.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jinlmao@codeaurora.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
--cc=tingwei@codeaurora.org \
--cc=zhangyuanfang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).